Re: [PATCH] ext4: fix uniniatilized extend splitting error.

2008-01-11 Thread Amit K. Arora
On Thu, Jan 10, 2008 at 02:31:03PM -0700, Andreas Dilger wrote: On Jan 10, 2008 17:31 +0300, Dmitry Monakhov wrote: While playing with new fancy fallocate interface on ext4 i've triggered bug which corrupted my grub :). I notice I'm CC'd on this, but in fact Amit wrote the code. I've CC'd

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

2008-01-11 Thread Paul Mundt
On Fri, Jan 11, 2008 at 12:04:14PM +0100, Roel Kluin wrote: Paul Mundt wrote: Take a look at how CONFIG_PCMCIA_DEBUG is handled. In drivers/pcmcia/Makefile, when CONFIG_PCMCIA_DEBUG=y, it gives EXTRA_CFLAGS += -DDEBUG which causes the definition of DEBUG as a macro, with definition 1.

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

2008-01-11 Thread Roel Kluin
Paul Mundt wrote: On Fri, Jan 11, 2008 at 10:45:30AM +0100, Roel Kluin wrote: Paul Mundt wrote: On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote: On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote: -#define DEBUG(x,args...) printk(__FUNCTION__ : x,##args) +#define

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

2008-01-11 Thread Paul Mundt
On Fri, Jan 11, 2008 at 10:45:30AM +0100, Roel Kluin wrote: Paul Mundt wrote: On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote: On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote: -#define DEBUG(x,args...) printk(__FUNCTION__ : x,##args) +#define DEBUG(x, args...)

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

2008-01-11 Thread Roel Kluin
Paul Mundt wrote: On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote: On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote: -#define DEBUG(x,args...) printk(__FUNCTION__ : x,##args) +#define DEBUG(x, args...) printk(%s: , __func__, x, ##args) Can this really be expected to

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

2008-01-11 Thread Roel Kluin
Paul Mundt wrote: On Fri, Jan 11, 2008 at 12:04:14PM +0100, Roel Kluin wrote: Paul Mundt wrote: Take a look at how CONFIG_PCMCIA_DEBUG is handled. In drivers/pcmcia/Makefile, when CONFIG_PCMCIA_DEBUG=y, it gives EXTRA_CFLAGS += -DDEBUG which causes the definition of DEBUG as a macro, with

Re: Problems with mballoc and uninit_groups option

2008-01-11 Thread Aneesh Kumar K.V
On Fri, Jan 11, 2008 at 03:04:08PM +0100, Valerie Clement wrote: Hi, I've got problems with mballoc when I create the ext4 filesystem with the uninit_groups option enabled. First, I do a single test on a filesystem created without the uninit_groups option and mounted with the defaults

Problems with mballoc and uninit_groups option

2008-01-11 Thread Valerie Clement
Hi, I've got problems with mballoc when I create the ext4 filesystem with the uninit_groups option enabled. First, I do a single test on a filesystem created without the uninit_groups option and mounted with the defaults option: dd if=/dev/zero of=/mnt/test/foo bs=1M count=1024 In this

[PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG

2008-01-11 Thread Jose R. Santos
commit 38a4134f29b06229843bfe838c23e28f8d323b86 Author: Jose R. Santos [EMAIL PROTECTED] Date: Fri Jan 11 11:03:03 2008 -0600 New bitmap and inode table allocation for FLEX_BG Change the way we allocate bitmaps and inode tables if the FLEX_BG feature is used at mke2fs time. It

[PATCH] New inode allocation for FLEX_BG meta-data groups.

2008-01-11 Thread Jose R. Santos
commit 8eef19455beb97319a78511b35b1da42a1d48eb2 Author: Jose R. Santos [EMAIL PROTECTED] Date: Fri Jan 11 11:04:25 2008 -0600 New inode allocation for FLEX_BG meta-data groups. This patch mostly controls the way inode are allocated in order to make ialloc aware of flex_bg block

[Fwd: [Bug 9732] New: oops in extent code via ext4_fallocate]

2008-01-11 Thread Eric Sandeen
---BeginMessage--- http://bugzilla.kernel.org/show_bug.cgi?id=9732 Summary: oops in extent code via ext4_fallocate Product: File System Version: 2.5 KernelVersion: 2.6.24-rc7 Platform: All OS/Version: Linux Tree: Mainline

Re: [PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG

2008-01-11 Thread Andreas Dilger
On Jan 11, 2008 11:28 -0600, Jose R. Santos wrote: +blk_t ext2fs_flexbg_offset(ext2_filsys fs, dgrp_t group, int flexbg_size, +ext2fs_block_bitmap bmap, int offset, int size) Could you please add some comments for what this function is trying to do? + last_grp =

Re: [PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG

2008-01-11 Thread Jose R. Santos
On Fri, 11 Jan 2008 14:01:04 -0700 Andreas Dilger [EMAIL PROTECTED] wrote: On Jan 11, 2008 11:28 -0600, Jose R. Santos wrote: +blk_t ext2fs_flexbg_offset(ext2_filsys fs, dgrp_t group, int flexbg_size, + ext2fs_block_bitmap bmap, int offset, int size) OK. Could you

Re: [PATCH] New inode allocation for FLEX_BG meta-data groups.

2008-01-11 Thread Andreas Dilger
On Jan 11, 2008 11:28 -0600, Jose R. Santos wrote: @@ -127,6 +127,8 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh, mark_bitmap_end(group_blocks, sb-s_blocksize * 8, bh-b_data); } + if (sbi-s_log_groups_per_flex) +

Re: [PATCH] New inode allocation for FLEX_BG meta-data groups.

2008-01-11 Thread Jose R. Santos
On Fri, 11 Jan 2008 14:46:58 -0700 Andreas Dilger [EMAIL PROTECTED] wrote: On Jan 11, 2008 11:28 -0600, Jose R. Santos wrote: @@ -127,6 +127,8 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh, mark_bitmap_end(group_blocks, sb-s_blocksize * 8,