Ext4 patch queue comments

2008-01-21 Thread Theodore Ts'o
Hey Mingming, I thought I should mention to you (and other people who maintain the ext4 patch queue) that I'm continuing to have to fix up certain issues in the patch queue to make sure the patch comments look good when imported into git via guilt. Basically, I have a git branch called ext4dev

Re: [PATCH] ext4: Fix the BUG_ON in jbd2_journal_commit_transaction

2008-01-21 Thread Theodore Tso
On Mon, Jan 21, 2008 at 11:26:06AM +0530, Aneesh Kumar K.V wrote: kunmap_atomic was passed the wrong argument. Thanks for pointing this out! I've applied your fix to jbd2-journal-chksum.patch in the ext4 patch queue. - Ted - To unsubscribe from this

[PATCH 39/49] ext4: Add ext4_find_next_bit()

2008-01-21 Thread Theodore Ts'o
From: Aneesh Kumar K.V [EMAIL PROTECTED] This function is used by the ext4 multi block allocator patches. Also add generic_find_next_le_bit Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] Cc: linux-ext4@vger.kernel.org Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[PATCH 26/49] jbd2: Fix assertion failure in fs/jbd2/checkpoint.c

2008-01-21 Thread Theodore Ts'o
From: Jan Kara [EMAIL PROTECTED] Before we start committing a transaction, we call __journal_clean_checkpoint_list() to cleanup transaction's written-back buffers. If this call happens to remove all of them (and there were already some buffers), __journal_remove_checkpoint() will decide to free

Re: [RFC] Parallelize IO for e2fsck

2008-01-21 Thread David Chinner
On Mon, Jan 21, 2008 at 04:00:41PM -0700, Andreas Dilger wrote: On Jan 16, 2008 13:30 -0800, Valerie Henson wrote: I have a partial solution that sort of blindly manages the buffer cache. First, the user passes e2fsck a parameter saying how much memory is available as buffer cache. The

Re: [RFC] Parallelize IO for e2fsck

2008-01-21 Thread Valdis . Kletnieks
On Tue, 22 Jan 2008 14:38:30 +1100, David Chinner said: Perhaps instead of swapping immediately, a SIGLOWMEM could be sent to a processes that aren't masking the signal followed by a short grace period to allow the processes to free up some memory before swapping out pages from that process?

Re: [RFC] Parallelize IO for e2fsck

2008-01-21 Thread Andreas Dilger
On Jan 21, 2008 23:17 -0500, [EMAIL PROTECTED] wrote: On Tue, 22 Jan 2008 14:38:30 +1100, David Chinner said: Perhaps instead of swapping immediately, a SIGLOWMEM could be sent to a processes that aren't masking the signal followed by a short grace period to allow the processes to free up

Re: [RFC] Parallelize IO for e2fsck

2008-01-21 Thread Andreas Dilger
On Jan 22, 2008 14:38 +1100, David Chinner wrote: On Mon, Jan 21, 2008 at 04:00:41PM -0700, Andreas Dilger wrote: I discussed this with Ted at one point also. This is a generic problem, not just for readahead, because fsck can run multiple e2fsck in parallel and in case of many large