Re: [PATCH 36/49] ext4: Add EXT4_IOC_MIGRATE ioctl

2008-01-26 Thread Aneesh Kumar K.V
On Fri, Jan 25, 2008 at 11:15:00PM -0500, Theodore Tso wrote: On Thu, Jan 24, 2008 at 11:25:32AM +0530, Aneesh Kumar K.V wrote: +static int free_ext_idx(handle_t *handle, struct inode *inode, + struct ext4_extent_idx *ix) +{ + int i, retval = 0; +

Re: [RFC] Parallelize IO for e2fsck

2008-01-26 Thread KOSAKI Motohiro
The commentary on the mem_notify threads claimed that the signal is easily provided by setting up the file handle for SIGIO. BTW: Of cource, you can receive any signal instead SIGIO by use fcntl(F_SETSIG) :-) - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of

Re: [RFC] Parallelize IO for e2fsck

2008-01-26 Thread KOSAKI Motohiro
And from a performance point of view letting applications voluntarily free some memory is better even than starting to swap. Absolutely. the mem_notify patch can realize just before starting swapping notification :) to be honest, I don't know fs guys requirement. if lacking feature of fs

Re: [RFC] Parallelize IO for e2fsck

2008-01-26 Thread Theodore Tso
On Fri, Jan 25, 2008 at 05:55:51PM -0800, Bryan Henderson wrote: I was surprised to see AIX do late allocation by default, because IBM's traditional style is bulletproof systems. A system where a process can be killed at unpredictable times because of resource demands of unrelated

Re: [PATCH 24/49] ext4: add block bitmap validation

2008-01-26 Thread Theodore Tso
On Wed, Jan 23, 2008 at 02:06:54PM -0800, Andrew Morton wrote: brelse() should only be used when the bh might be NULL - put_bh() can be used here. Please review all ext4/jbd2 code for this trivial speedup. I've reviewed all of the pending patches in the stable queue for this speedup, and

Re: Patch for 2.6.25 queue

2008-01-26 Thread Theodore Tso
On Sat, Jan 26, 2008 at 05:08:49PM +0530, Aneesh Kumar K.V wrote: This diff contain mballoc fixes and update for ext3-4 migrate patch. I will fold these patches into the patch queue in the proper places (and adjust other patches as necessary). diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c

Re: Patch for 2.6.25 queue

2008-01-26 Thread Theodore Tso
On Sat, Jan 26, 2008 at 12:03:31PM -0500, Theodore Tso wrote: This patch hunk causes a failure due to a botched brelse-put_bh conversion, but removing it isn't the right fix. Err, sorry, the above should read, This patch hunk FIXES a failure... and if it wasn't clear, I was responsible for the

Re: [RFC] ext3 freeze feature

2008-01-26 Thread Christoph Hellwig
On Fri, Jan 25, 2008 at 09:42:30PM +0900, Takashi Sato wrote: Hi, I am also wondering whether we should have system call(s) for these: On Jan 25, 2008 12:59 PM, Takashi Sato [EMAIL PROTECTED] wrote: + case EXT3_IOC_FREEZE: { + case EXT3_IOC_THAW: { And just convert XFS to

Re: [PATCH e2fsprogs] teach libblkid about ext4(dev)

2008-01-26 Thread Theodore Tso
On Tue, Jan 22, 2008 at 05:11:11PM -0600, Eric Sandeen wrote: Returns ext4dev for now; will need to change to ext4 at the appropriate time I guess. This is what I ultimately ended up committing. - Ted commit

Re: [PATCH e2fsprogs] UPDATED: ignore safe flag differences when fsck compares superblocks

2008-01-26 Thread Theodore Tso
This is what I've checked in. See the comment about why we can't ignore a difference for the extended attribute feature. - Ted commit a8cde73acbf6e0f9c0a3601e4f5fac2b01a27bd2 Author: Theodore Ts'o [EMAIL PROTECTED] Date: Sat Jan 26 23:17:50 2008

Re: [PATCH e2fsprogs] UPDATED: ignore safe flag differences when fsck compares superblocks

2008-01-26 Thread Eric Sandeen
Theodore Tso wrote: This is what I've checked in. See the comment about why we can't ignore a difference for the extended attribute feature. Ok. Unfortunately, that one really hurts on fedora, or any distro which writes xattrs during install. The installer mkfs's, mounts, installs with

Re: Integrating patches in SLES10 e2fsprogs

2008-01-26 Thread Theodore Tso
Wow. You have a lot of patches in the SLES 10 e2fsprogs. I'm not sure why of them are there, though. For example: Patch0: elf.diff I'm not sure what this one is for. Patch1: e2fsprogs-1.35-libdir.diff This one does two different things. One is include AC_HEADER_TIME in