Re: BUG_ON at mballoc.c:3752

* Aneesh Kumar K.V ([EMAIL PROTECTED]) wrote: > On Thu, Jan 31, 2008 at 04:42:07PM +0100, Eric Sesterhenn wrote: > > * Eric Sesterhenn ([EMAIL PROTECTED]) wrote: > > > hi, > > > > > > while running a modified version of fsfuzzer i triggered the BUG() in > > > ext4_mb_release_inode_pa(). Sadly I am

Re: [PATCH] Fix ext4 bitops

> > > > | fs/ext4/mballoc.c: In function 'ext4_mb_generate_buddy': > > > > | fs/ext4/mballoc.c:954: error: implicit declaration of function > > > > 'generic_find_next_le_bit' > > > > > > > > The s390 specific bitops uses parts of the generic implementation. > > > > Include the correct header. > >

Re: [PATCH] Fix ext4 bitops

On Mon, Feb 04, 2008 at 10:24:36AM +0100, Heiko Carstens wrote: > > > > > | fs/ext4/mballoc.c: In function 'ext4_mb_generate_buddy': > > > > > | fs/ext4/mballoc.c:954: error: implicit declaration of function > > > > > 'generic_find_next_le_bit' > > > > > > > > > > The s390 specific bitops uses pa

Re: Fw: [Bugme-new] [Bug 9849] New: NULL pointer deref in journal_wait_on_commit_record

On Wed, Jan 30, 2008 at 03:17:57PM -0800, Mingming Cao wrote: > > The buufer head pointer passed to journal_wait_on_commit_record() could > be NULL if the previous journal_submit_commit_record() failed or journal > has already aborted. > > Looking at the jbd2 debug messages, before the oops happe

jbd2_handle and i_data_sem circular locking dependency detected

Hi, This is with the new ext3 -> ext4 migrate code added. The recently added lockdep for jbd2 helped to find this out. We want to hold the i_data_sem on the ext3 inode during migration to prevent walking the ext3 inode when it is being converted to ext4 format. Also we want to avoid file truncati

[RESEND] [PATCH] ext3,4:fdatasync should skip metadata writeout when overwriting

Hi. Currently fdatasync is identical to fsync in ext3,4. I think fdatasync should skip journal flush in data=ordered and data=writeback mode when it overwrites to already-instantiated blocks on HDD. When I_DIRTY_DATASYNC flag is not set, fdatasync should skip journal writeout because this indicat

[PATCH] ext4: Use the right macro for testing the incompat feature.

Incompat feature need to be checked using JBD2_HAS_INCOMPAT_FEATURE Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/jbd2/commit.c |2 +- fs/jbd2/recovery.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c index 2b88ab0.

Re: jbd2_handle and i_data_sem circular locking dependency detected

On Mon, Feb 04, 2008 at 05:31:56PM +0100, Jan Kara wrote: > Hi, > > On Mon 04-02-08 15:42:28, Aneesh Kumar K.V wrote: > > This is with the new ext3 -> ext4 migrate code added. The recently added > > lockdep for jbd2 helped to find this out. We want to hold the i_data_sem > > on the ext3 inode du

Re: jbd2_handle and i_data_sem circular locking dependency detected

On Mon 04-02-08 22:42:08, Aneesh Kumar K.V wrote: > On Mon, Feb 04, 2008 at 05:31:56PM +0100, Jan Kara wrote: > > Hi, > > > > On Mon 04-02-08 15:42:28, Aneesh Kumar K.V wrote: > > > This is with the new ext3 -> ext4 migrate code added. The recently added > > > lockdep for jbd2 helped to find thi

Re: jbd2_handle and i_data_sem circular locking dependency detected

On Monday 04 February 2008 5:12:28 am Aneesh Kumar K.V wrote: > Hi, > > This is with the new ext3 -> ext4 migrate code added. The recently added > lockdep for jbd2 helped to find this out. We want to hold the i_data_sem > on the ext3 inode during migration to prevent walking the ext3 inode > when i

[PATCH] ext4: Fix reference counting on buffer head.

With journal checksum patch we added asyn commit of journal commit headers. During the conversion we missed to take a reference on buffer head. Before the change sync_dirty_buffer did the get_bh(). The associative put_bh is done by journal_wait_on_commit_record() Signed-off-by: Aneesh Kumar K.V <[

Re: jbd2_handle and i_data_sem circular locking dependency detected

Hi, On Mon 04-02-08 15:42:28, Aneesh Kumar K.V wrote: > This is with the new ext3 -> ext4 migrate code added. The recently added > lockdep for jbd2 helped to find this out. We want to hold the i_data_sem > on the ext3 inode during migration to prevent walking the ext3 inode > when it is being co

[PATCH] ext4: Don't set EXTENTS_FL flag for fast symlinks

Don't set EXTENTS_FL flag for fast symlinks From: Valerie Clement <[EMAIL PROTECTED]> For fast symbolic links, the file content is stored in the i_block[] array, which is not compatible with the new file extents format. e2fsck reports error on such files because EXTENTS_FL is set. Don't set the E

Re: - disable-ext4.patch removed from -mm tree

On Sun, Feb 03, 2008 at 07:15:40PM -0800, Andrew Morton wrote: > On Sun, 3 Feb 2008 20:36:26 -0500 Theodore Tso <[EMAIL PROTECTED]> wrote: > > > On Sun, Feb 03, 2008 at 12:25:51PM -0800, Andrew Morton wrote: > > > When I merge David's iget coversion patches this will instead wreck the > > > ext4 p

Re: jbd2_handle and i_data_sem circular locking dependency detected

On Mon, Feb 04, 2008 at 10:23:16AM -0500, Josef Bacik wrote: > On Monday 04 February 2008 5:12:28 am Aneesh Kumar K.V wrote: > > Hi, > > > > This is with the new ext3 -> ext4 migrate code added. The recently added > > lockdep for jbd2 helped to find this out. We want to hold the i_data_sem > > on t

Re: - disable-ext4.patch removed from -mm tree

On Mon, 4 Feb 2008 10:00:44 -0500 Theodore Tso <[EMAIL PROTECTED]> wrote: > On Sun, Feb 03, 2008 at 07:15:40PM -0800, Andrew Morton wrote: > > On Sun, 3 Feb 2008 20:36:26 -0500 Theodore Tso <[EMAIL PROTECTED]> wrote: > > > > > On Sun, Feb 03, 2008 at 12:25:51PM -0800, Andrew Morton wrote: > > > >

Re: merge plans, was Re: - disable-ext4.patch removed from -mm tree

On Mon, 4 Feb 2008 15:24:18 -0500 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Sun, Feb 03, 2008 at 07:15:40PM -0800, Andrew Morton wrote: > > On Sun, 3 Feb 2008 20:36:26 -0500 Theodore Tso <[EMAIL PROTECTED]> wrote: > > > > > On Sun, Feb 03, 2008 at 12:25:51PM -0800, Andrew Morton wrote: >

Re: [PATCH] Fix ext4 bitops

On Mon, 4 Feb 2008, Aneesh Kumar K.V wrote: > On Sun, Feb 03, 2008 at 01:39:02PM +0100, Geert Uytterhoeven wrote: > > On Sun, 3 Feb 2008, Heiko Carstens wrote: > > > On Fri, Feb 01, 2008 at 10:04:04PM +0100, Bastian Blank wrote: > > > > On Fri, Feb 01, 2008 at 12:22:57PM -0800, Andrew Morton wrote:

merge plans, was Re: - disable-ext4.patch removed from -mm tree

On Sun, Feb 03, 2008 at 07:15:40PM -0800, Andrew Morton wrote: > On Sun, 3 Feb 2008 20:36:26 -0500 Theodore Tso <[EMAIL PROTECTED]> wrote: > > > On Sun, Feb 03, 2008 at 12:25:51PM -0800, Andrew Morton wrote: > > > When I merge David's iget coversion patches this will instead wreck the > > > ext4 p

Re: - disable-ext4.patch removed from -mm tree

On Mon, Feb 04, 2008 at 12:11:31PM -0800, Andrew Morton wrote: > > That patch series is kind of logjammed anyway because it breaks isofs. > Last time I discussed this with David he seemed to find this amusing rather > than an urgent problem. I'd drop the whole lot if there weren't lots of > othe

Re: [Bug 9855] ext3 ACL corruption

On Jan 31, 2008 22:44 +1030, Kevin Shanahan wrote: > On Thu, 2008-01-31 at 03:05 -0700, Andreas Dilger wrote: > > ... To get the interesting bits you need: > > > > debugfs: stat <95> # prints decoded inode, "File ACL:" is a block > > number > > debugfs: imap <95> # prints inode bloc

[patch 068/265] Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user

From: Christoph Lameter <[EMAIL PROTECTED]> Simplify page cache zeroing of segments of pages through 3 functions zero_user_segments(page, start1, end1, start2, end2) Zeros two segments of the page. It takes the position where to start and end the zeroing which avoids length calcu