[PATCH] extra checking for in-inode EAs

2008-02-05 Thread Andreas Dilger
When investigating the EA problem reported on this list, I noticed that some of the checks for the in-inode EAs were removed (possibly when the unordered EAs-in-inode patch was removed). The following patch returns the checks for the e_value_offs. This passes "make check" with the Lustre EA test

Re: [Bug 9855] ext3 ACL corruption

2008-02-05 Thread Kevin Shanahan
On Mon, 2008-02-04 at 18:06 -0700, Andreas Dilger wrote: > Hmm, I wonder if e2fsck is calculating the wrong file offset or something? > The kernel appears to be taking the EA data offset from the end of > i_extra_isize and the ext3_xattr_ibody_header fields (so 0x88 + e_value_offs > from the start

Re: merge plans, was Re: - disable-ext4.patch removed from -mm tree

2008-02-05 Thread Andrew Morton
On Tue, 5 Feb 2008 10:44:54 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Mon, Feb 04, 2008 at 02:35:29PM -0800, Andrew Morton wrote: > > On Mon, 4 Feb 2008 15:24:18 -0500 > > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > > On Sun, Feb 03, 2008 at 07:15:40PM -0800, Andrew Morton

Re: merge plans, was Re: - disable-ext4.patch removed from -mm tree

2008-02-05 Thread Christoph Hellwig
On Mon, Feb 04, 2008 at 02:35:29PM -0800, Andrew Morton wrote: > On Mon, 4 Feb 2008 15:24:18 -0500 > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > On Sun, Feb 03, 2008 at 07:15:40PM -0800, Andrew Morton wrote: > > > On Sun, 3 Feb 2008 20:36:26 -0500 Theodore Tso <[EMAIL PROTECTED]> wrote: > >

Re: - disable-ext4.patch removed from -mm tree

2008-02-05 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > Last time I discussed this with David he seemed to find this amusing rather > than an urgent problem. Amusing? In what way? I've been at LCA, and I left all but one of my machines powered down because the local substation broke and has been giving wild

[PATCH] Handle unusual results from find_tempdir.

2008-02-05 Thread Jim Meyering
An alternative: make find_tempdir set tempdir to default_tempdir upon malloc failure. * arch/um/os-Linux/mem.c (make_tempfile): Handle NULL tempdir. Don't let a long tempdir (e.g., via TMPDIR) provoke heap corruption. Signed-off-by: Jim Meyering <[EMAIL PROTECTED]> --- arch/um/os-Linux/mem.c |

Re: jbd2_handle and i_data_sem circular locking dependency detected

2008-02-05 Thread Aneesh Kumar K.V
On Mon, Feb 04, 2008 at 05:31:56PM +0100, Jan Kara wrote: > Hi, > > On Mon 04-02-08 15:42:28, Aneesh Kumar K.V wrote: > > This is with the new ext3 -> ext4 migrate code added. The recently added > > lockdep for jbd2 helped to find this out. We want to hold the i_data_sem > > on the ext3 inode du

[PATCH] Handle failed malloc.

2008-02-05 Thread Jim Meyering
* lib/inflate.c (inflate_dynamic): Don't deref NULL upon failed malloc. * arch/um/os-Linux/mem.c (make_tempfile): Likewise. Signed-off-by: Jim Meyering <[EMAIL PROTECTED]> --- arch/um/os-Linux/mem.c |2 ++ lib/inflate.c |3 +++ 2 files changed, 5 insertions(+), 0 deletions(-) d

Re: jbd2_handle and i_data_sem circular locking dependency detected

2008-02-05 Thread Jan Kara
On Tue 05-02-08 17:53:42, Aneesh Kumar K.V wrote: > On Mon, Feb 04, 2008 at 05:31:56PM +0100, Jan Kara wrote: > > Hi, > > > > On Mon 04-02-08 15:42:28, Aneesh Kumar K.V wrote: > > > This is with the new ext3 -> ext4 migrate code added. The recently added > > > lockdep for jbd2 helped to find thi

Re: [PATCH] Handle unusual results from find_tempdir.

2008-02-05 Thread Theodore Tso
On Tue, Feb 05, 2008 at 01:13:04PM +0100, Jim Meyering wrote: > An alternative: make find_tempdir set tempdir to default_tempdir > upon malloc failure. > > * arch/um/os-Linux/mem.c (make_tempfile): Handle NULL tempdir. > Don't let a long tempdir (e.g., via TMPDIR) provoke heap corruption. This wa

Re: jbd2_handle and i_data_sem circular locking dependency detected

2008-02-05 Thread Aneesh Kumar K.V
On Tue, Feb 05, 2008 at 02:42:28PM +0100, Jan Kara wrote: > On Tue 05-02-08 17:53:42, Aneesh Kumar K.V wrote: > > > > How about the patch below. I did the below testing > > a) migrate a file > > b) run fs_inode fsstres fsx_linux. > > > > The intention was to find out whether the new locking is br

Re: jbd2_handle and i_data_sem circular locking dependency detected

2008-02-05 Thread Jan Kara
On Tue 05-02-08 21:57:03, Aneesh Kumar K.V wrote: > On Tue, Feb 05, 2008 at 02:42:28PM +0100, Jan Kara wrote: > > On Tue 05-02-08 17:53:42, Aneesh Kumar K.V wrote: > > > > > > How about the patch below. I did the below testing > > > a) migrate a file > > > b) run fs_inode fsstres fsx_linux. > > >

Re: [PATCH] jbd: fix assertion failure in journal_next_log_block

2008-02-05 Thread Jan Kara
Hello, Sorry for replying a bit late but I'm currently falling behind in maling-list reading... > The way jbd tries to determine if there is enough space left on the journal in > order to start a new transaction is looking at the space left in the journal > and > the space needed for the com

Re: [PATCH] jbd: fix assertion failure in journal_next_log_block

2008-02-05 Thread Josef Bacik
On Tuesday 05 February 2008 12:27:31 pm Jan Kara wrote: > Hello, > > Sorry for replying a bit late but I'm currently falling behind in > maling-list reading... > > > The way jbd tries to determine if there is enough space left on the > > journal in order to start a new transaction is looking at

Re: jbd2_handle and i_data_sem circular locking dependency detected

2008-02-05 Thread Aneesh Kumar K.V
On Tue, Feb 05, 2008 at 05:34:04PM +0100, Jan Kara wrote: > On Tue 05-02-08 21:57:03, Aneesh Kumar K.V wrote: > > > > I have a FIXME at migrate.c:524 documenting exactly that. The > > difficult question was by how much we should extent the journal. ? But > > in reality we might have accumulated en

Re: - disable-ext4.patch removed from -mm tree

2008-02-05 Thread Mingming Cao
On Mon, 2008-02-04 at 10:00 -0500, Theodore Tso wrote: > On Sun, Feb 03, 2008 at 07:15:40PM -0800, Andrew Morton wrote: > > On Sun, 3 Feb 2008 20:36:26 -0500 Theodore Tso <[EMAIL PROTECTED]> wrote: > > > > > On Sun, Feb 03, 2008 at 12:25:51PM -0800, Andrew Morton wrote: > > > > When I merge David'

- pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user.patch removed from -mm tree

2008-02-05 Thread akpm
The patch titled Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user has been removed from the -mm tree. Its filename was pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user.patch This patch was dropped because it was merged into mainline or a subsys

Re: Replace iget with iget_locked in defrag-free-space-fragementation

2008-02-05 Thread Mingming Cao
On Sat, 2008-02-02 at 11:40 -0500, Theodore Ts'o wrote: > FYI, since iget() is going to be disappearing in 2.6.25, and akpm has > disabled ext4 in the -mm tree as a result, I'm folding the following > patch into the defrag-free-space-fragmentation.patch in the ext4 tree. > > I noticed that you ha

Re: Replace iget with iget_locked in defrag-free-space-fragementation

2008-02-05 Thread Mingming Cao
On Sat, 2008-02-02 at 11:40 -0500, Theodore Ts'o wrote: > We also have an issue where the read-only bind patches from Dave Hansen > are making changes which conflict with the ext4 patch tree, which is > making akpm very grumpy. I'll try to take a look at this later in the > weekend... > >

Re: - disable-ext4.patch removed from -mm tree

2008-02-05 Thread Mingming Cao
On Tue, 2008-02-05 at 13:26 -0800, Mingming Cao wrote: > On Mon, 2008-02-04 at 10:00 -0500, Theodore Tso wrote: > > On Sun, Feb 03, 2008 at 07:15:40PM -0800, Andrew Morton wrote: > > > On Sun, 3 Feb 2008 20:36:26 -0500 Theodore Tso <[EMAIL PROTECTED]> wrote: > > > > > > > On Sun, Feb 03, 2008 at 1

Re: - disable-ext4.patch removed from -mm tree

2008-02-05 Thread Andrew Morton
On Tue, 05 Feb 2008 17:02:20 -0800 Mingming Cao <[EMAIL PROTECTED]> wrote: > On Tue, 2008-02-05 at 13:26 -0800, Mingming Cao wrote: > > On Mon, 2008-02-04 at 10:00 -0500, Theodore Tso wrote: > > > On Sun, Feb 03, 2008 at 07:15:40PM -0800, Andrew Morton wrote: > > > > On Sun, 3 Feb 2008 20:36:26 -0

Re: - disable-ext4.patch removed from -mm tree

2008-02-05 Thread Mingming Cao
On Tue, 2008-02-05 at 17:57 -0800, Andrew Morton wrote: > On Tue, 05 Feb 2008 17:02:20 -0800 Mingming Cao <[EMAIL PROTECTED]> wrote: > > > On Tue, 2008-02-05 at 13:26 -0800, Mingming Cao wrote: > > > On Mon, 2008-02-04 at 10:00 -0500, Theodore Tso wrote: > > > > On Sun, Feb 03, 2008 at 07:15:40PM

Re: Replace iget with iget_locked in defrag-free-space-fragementation

2008-02-05 Thread Theodore Tso
On Tue, Feb 05, 2008 at 04:55:52PM -0800, Mingming Cao wrote: > On Sat, 2008-02-02 at 11:40 -0500, Theodore Ts'o wrote: > > We also have an issue where the read-only bind patches from Dave Hansen > > are making changes which conflict with the ext4 patch tree, which is > > making akpm very grumpy.

- ext3-fix-lock-inversion-in-direct-io-fix.patch removed from -mm tree

2008-02-05 Thread akpm
The patch titled ext3-fix-lock-inversion-in-direct-io-fix has been removed from the -mm tree. Its filename was ext3-fix-lock-inversion-in-direct-io-fix.patch This patch was dropped because it was folded into ext3-fix-lock-inversion-in-direct-io.patch The current -mm tree may be found