From: Aneesh Kumar K.V [EMAIL PROTECTED]
ext3 file system was by default ignoring errors and continuing. This is
not a good default as continuing on error could lead to file system
corruption. Change the default to mark the file system readonly. Debian
and ubuntu already does this as the
From: Jan Kara [EMAIL PROTECTED]
We cannot start transaction in ext3_direct_IO() and just let it last during
the whole write because dio_get_page() acquires mmap_sem which ranks above
transaction start (e.g. because we have dependency chain
mmap_sem-PageLock-journal_start, or because we update
From: Aneesh Kumar K.V [EMAIL PROTECTED]
When a new block bitmap is read from disk in read_block_bitmap() there are a
few bits that should ALWAYS be set. In particular, the blocks given
corresponding to block bitmap, inode bitmap and inode tables. Validate the
block bitmap against these blocks.
From: Aneesh Kumar K.V [EMAIL PROTECTED]
When a new block bitmap is read from disk in read_block_bitmap() there are a
few bits that should ALWAYS be set. In particular, the blocks given
corresponding to block bitmap, inode bitmap and inode tables. Validate the
block bitmap against these blocks.
From: Akinobu Mita [EMAIL PROTECTED]
The argument chain for ext[234]_find_goal() is not used. This patch removes
it and fixes comment as well.
Cc: linux-ext4@vger.kernel.org
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
fs/ext2/inode.c |7
From: Aneesh Kumar K.V [EMAIL PROTECTED]
ext2 file system was by default ignoring errors and continuing. This is
not a good default as continuing on error could lead to file system
corruption. Change the default to mark the file system readonly. Debian
and ubuntu already does this as the
From: Akinobu Mita [EMAIL PROTECTED]
The comment in ext[234]_new_blocks() describes about i. But there is no
local variable called i in that scope. I guess it has been renamed to
group_no.
Cc: linux-ext4@vger.kernel.org
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
Signed-off-by: Andrew Morton
From: Akinobu Mita [EMAIL PROTECTED]
Use ext[234]_bg_has_super() to remove duplicate code.
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
Cc: linux-ext4@vger.kernel.org
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
fs/ext2/balloc.c |5 +
fs/ext3/balloc.c |6 +-
From: Akinobu Mita [EMAIL PROTECTED]
Use ext[234]_get_group_desc() to get group descriptor from group number.
Cc: linux-ext4@vger.kernel.org
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
fs/ext2/super.c | 12
fs/ext3/super.c |
From: Andi Kleen [EMAIL PROTECTED]
None of the callers of this function does actually take the BKL as far as I
can see. So remove the comment refering to the BKL.
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
Cc: linux-ext4@vger.kernel.org
Cc: Theodore Ts'o [EMAIL PROTECTED]
Signed-off-by: Andrew
From: Aneesh Kumar K.V [EMAIL PROTECTED]
This fixes some instances where we were continuing after calling
ext3_error. ext3_error calls panic only if errors=panic mount option is
set. So we need to make sure we return correctly after ext3_error call
Signed-off-by: Aneesh Kumar K.V [EMAIL
On Tue 05-02-08 13:59:05, Josef Bacik wrote:
On Tuesday 05 February 2008 12:27:31 pm Jan Kara wrote:
Hello,
Sorry for replying a bit late but I'm currently falling behind in
maling-list reading...
The way jbd tries to determine if there is enough space left on the
journal in
We now take inode-i_mutex lock to prevent any update of the inode i_data
field. Before we switch the inode format we take i_data_sem to prevent
parallel read.
===
[ INFO: possible circular locking dependency detected ]
2.6.24-rc8 #6
Add option -m to ignore and return an exit code of 0
for mounted filesystems.
Signed-off-by: Matthias Koenig [EMAIL PROTECTED]
---
fsck/fsck.8.in |4 +++
fsck/fsck.c| 77 +++-
2 files changed, 80 insertions(+), 1 deletions(-)
diff
Allows fsck to work with blkid or volume_id as defined
by the configure invocation.
Signed-off-by: Matthias Koenig [EMAIL PROTECTED]
---
fsck/Makefile.am | 17 +++--
fsck/fsck.c | 13 ++---
2 files changed, 21 insertions(+), 9 deletions(-)
diff --git
Signed-off-by: Matthias Koenig [EMAIL PROTECTED]
---
Makefile.am|1
configure.ac |2
fsck/Makefile.am |7
fsck/base_device.c | 169 +++
fsck/fsck.8.in | 410
fsck/fsck.c| 1309
Here is another attempt to move fsck over to the util-linux-ng
tree. A similar attempt has been done previously by Christoph
Hellwig some time ago.
Patch 1 is the initial move with minor adjustments for the
build system.
Patch 2 adds support for the fsprobe library wrapper.
Patch 3 adds a new
On Wed, Feb 06, 2008 at 12:38:59PM +0100, Matthias Koenig wrote:
Here is another attempt to move fsck over to the util-linux-ng
tree. A similar attempt has been done previously by Christoph
Hellwig some time ago.
Thanks (also thanks to Christoph)!
I didn't forget about this task. It's still
On Wed 06-02-08 16:30:04, Aneesh Kumar K.V wrote:
We now take inode-i_mutex lock to prevent any update of the inode i_data
field. Before we switch the inode format we take i_data_sem to prevent
parallel read.
===
[ INFO: possible circular
On Wed, Feb 06, 2008 at 01:56:51PM +0100, Karel Zak wrote:
It would be nice to add a note
fsck is deprecated in favor of fsck from util-linux-ng
to RELEASE-NOTES in e2fsprogs.
I don't want to deprecate fsck quite yet from e2fsprogs, because there
are some ext4 issues with fsck (or more
On Wed, Feb 06, 2008 at 09:05:59AM -0500, Theodore Tso wrote:
On Wed, Feb 06, 2008 at 01:56:51PM +0100, Karel Zak wrote:
It would be nice to add a note
fsck is deprecated in favor of fsck from util-linux-ng
to RELEASE-NOTES in e2fsprogs.
I don't want to deprecate fsck quite yet
Hi,
Currently fdatasync is identical to fsync in ext3,4.
I think fdatasync should skip journal flush in data=ordered and
data=writeback mode
when it overwrites to already-instantiated blocks on HDD.
When I_DIRTY_DATASYNC flag is not set, fdatasync should skip journal writeout
because
Hi,
this patch fixes lock inversion in ext4 direct IO path. The similar patch
has already been accepted for ext3. Mingming, will you put it into ext4
patch queue? Thanks.
Honza
--
Jan Kara [EMAIL PROTECTED]
SUSE Labs, CR
---
On Wed, Feb 06, 2008 at 04:23:10PM +0100, Karel Zak wrote:
I'm already working on vol_id + blkid merge
http://git.kernel.org/?p=utils/util-linux-ng/util-linux-ng.git;a=shortlog;h=topic/fsprobe
My plan is follow ideas and code from blkid and add a new low-level API
for udev. That's
struct ext4_allocation_context is rather large, and this bloats
the stack of many functions which use it. Allocating it from
a named slab cache will alleviate this.
For example, with this change (on top of the noinline patch sent earlier):
-ext4_mb_new_blocks 200
+ext4_mb_new_blocks
On Tue, 2008-02-05 at 13:59 -0500, Josef Bacik wrote:
On Tuesday 05 February 2008 12:27:31 pm Jan Kara wrote:
Hello,
Sorry for replying a bit late but I'm currently falling behind in
maling-list reading...
The way jbd tries to determine if there is enough space left on the
On Wed, 2008-02-06 at 17:06 +0100, Jan Kara wrote:
Hi,
this patch fixes lock inversion in ext4 direct IO path. The similar patch
has already been accepted for ext3. Mingming, will you put it into ext4
patch queue? Thanks.
Thanks! Added to the ext4 patch queue.
Mingming
On Mon, 2008-02-04 at 11:30 +0530, Aneesh Kumar K.V wrote:
On Thu, Jan 31, 2008 at 04:42:07PM +0100, Eric Sesterhenn wrote:
* Eric Sesterhenn ([EMAIL PROTECTED]) wrote:
hi,
while running a modified version of fsfuzzer i triggered the BUG() in
ext4_mb_release_inode_pa(). Sadly I am
The patch titled
ext2: change the default behaviour on error
has been removed from the -mm tree. Its filename was
ext2-change-the-default-behaviour-on-error.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at
On Feb 6, 2008 3:05 PM, Theodore Tso [EMAIL PROTECTED] wrote:
On Wed, Feb 06, 2008 at 01:56:51PM +0100, Karel Zak wrote:
It would be nice to add a note
fsck is deprecated in favor of fsck from util-linux-ng
to RELEASE-NOTES in e2fsprogs.
I don't want to deprecate fsck quite yet
The patch titled
ext[234]: use ext[234]_get_group_desc()
has been removed from the -mm tree. Its filename was
ext-use-ext_get_group_desc.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at
The patch titled
ext3: add block bitmap validation
has been removed from the -mm tree. Its filename was
ext3-add-block-bitmap-validation.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at
The patch titled
ext3: return after ext3_error in case of failures
has been removed from the -mm tree. Its filename was
ext3-return-after-ext3_error-in-case-of-failures.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be
The patch titled
ext[234]: remove unused argument for ext[234]_find_goal()
has been removed from the -mm tree. Its filename was
ext-remove-unused-argument-for-ext_find_goal.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may
The patch titled
ext3: change the default behaviour on error
has been removed from the -mm tree. Its filename was
ext3-change-the-default-behaviour-on-error.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at
The patch titled
ext3: fix lock inversion in direct IO
has been removed from the -mm tree. Its filename was
ext3-fix-lock-inversion-in-direct-io.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at
The patch titled
BKL-removal: remove incorrect comment refering to lock_kernel() from
jbd/jbd2
has been removed from the -mm tree. Its filename was
bkl-removal-remove-incorrect-comment-refering-to-lock_kernel-from-jbd-jbd2.patch
This patch was dropped because it was merged into
The patch titled
ext2: add block bitmap validation
has been removed from the -mm tree. Its filename was
ext2-add-block-bitmap-validation.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at
The patch titled
ext[234]: cleanup ext[234]_bg_num_gdb()
has been removed from the -mm tree. Its filename was
ext-cleanup-ext_bg_num_gdb.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at
The patch titled
ext[234]: fix comment for nonexistent variable
has been removed from the -mm tree. Its filename was
ext-fix-comment-for-nonexistent-variable.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at
Some devices - notably dm and md - can change their behaviour in
response to BIO_RW_BARRIER requests. They might start out accepting
such requests but on reconfiguration, they find out that they cannot
any more.
ext3 (and other filesystems) deal with this by always testing if
BIO_RW_BARRIER
The patch titled
ext3 can fail badly when device stops accepting BIO_RW_BARRIER requests
has been added to the -mm tree. Its filename is
ext3-can-fail-badly-when-device-stops-accepting-bio_rw_barrier-requests.patch
Before you just go and hit reply, please:
a) Consider who else
The patch titled
iget-stop-ext2-from-using-iget-and-read_inode-try-checkpatch-fixes
has been removed from the -mm tree. Its filename was
iget-stop-ext2-from-using-iget-and-read_inode-try-checkpatch-fixes.patch
This patch was dropped because it was folded into
The patch titled
iget-stop-ext3-from-using-iget-and-read_inode-try-checkpatch-fixes
has been removed from the -mm tree. Its filename was
iget-stop-ext3-from-using-iget-and-read_inode-try-checkpatch-fixes.patch
This patch was dropped because it was folded into
Duplicating Neil Brown's jbd patch for jbd2. I guess this can go
through the ext4 queue rather than straight into -mm.
Neil's text:
Some devices - notably dm and md - can change their behaviour in
response to BIO_RW_BARRIER requests. They might start out accepting
such requests but on
Signed-off-by :Hisashi Hifumi [EMAIL PROTECTED]
Yes, the patch looks fine. You can add
Acked-by: Jan Kara [EMAIL PROTECTED]
if you wish.
Honza
Thank you for your comment.
Please merge my patch.
Thanks.
[PATCH] ext3,4:fdatasync
46 matches
Mail list logo
