[patch 135/208] iget: stop EXT2 from using iget() and read_inode()

2008-02-07 Thread akpm
From: David Howells [EMAIL PROTECTED] Stop the EXT2 filesystem from using iget() and read_inode(). Replace ext2_read_inode() with ext2_iget(), and call that instead of iget(). ext2_iget() then uses iget_locked() directly and returns a proper error code instead of an inode in the event of an

[patch 137/208] iget: stop EXT4 from using iget() and read_inode()

2008-02-07 Thread akpm
From: David Howells [EMAIL PROTECTED] Stop the EXT4 filesystem from using iget() and read_inode(). Replace ext4_read_inode() with ext4_iget(), and call that instead of iget(). ext4_iget() then uses iget_locked() directly and returns a proper error code instead of an inode in the event of an

Re: BUG_ON at mballoc.c:3752

2008-02-07 Thread Aneesh Kumar K.V
On Wed, Feb 06, 2008 at 03:59:48PM -0600, Dave Kleikamp wrote: File systems should not call BUG() due to a corrupt file system. Instead the code should fail the operation, possibly marking the file system read-only (or panicking) depending on the errors= mount option. Eric Sandeen

Re: [PATCH 0/3] Move fsck from e2fsprogs to util-linux-ng

2008-02-07 Thread Theodore Tso
On Thu, Feb 07, 2008 at 01:37:43AM +0100, Kay Sievers wrote: Care to explain what ext4 development has to do with the generic fsck program? I don''t see any convincing reason not to move that now. Fsck and mount (and especially mount) needs to be linked against the very latest blkid library

[PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG

2008-02-07 Thread Jose R. Santos
New bitmap and inode table allocation for FLEX_BG From: Jose R. Santos [EMAIL PROTECTED] Change the way we allocate bitmaps and inode tables if the FLEX_BG feature is used at mke2fs time. It places calculates a new offset for bitmaps and inode table base on the number of groups that the user

Re: [PATCH] allocate struct ext4_allocation_context from a kmem cache to save stack space

2008-02-07 Thread Mingming Cao
On Wed, 2008-02-06 at 11:05 -0600, Eric Sandeen wrote: struct ext4_allocation_context is rather large, and this bloats the stack of many functions which use it. Allocating it from a named slab cache will alleviate this. For example, with this change (on top of the noinline patch sent

Re: [PATCH] allocate struct ext4_allocation_context from a kmem cache to save stack space

2008-02-07 Thread Eric Sandeen
Mingming Cao wrote: Do you intend to remove the #ifdef CONFIG_PROC_FS, or it's a accident? I think we need keep that to allow ext4 build without procfs configured. Other than this, the patch looks fine to me.:) oh, it kind of snuck in. It actually should still build, as remove_proc_entry

Re: BUG_ON at mballoc.c:3752

2008-02-07 Thread Mingming Cao
On Thu, 2008-02-07 at 18:25 +0530, Aneesh Kumar K.V wrote: ext4: Don't panic in case of corrupt bitmap From: Aneesh Kumar K.V [EMAIL PROTECTED] Multiblock allocator was calling BUG_ON in many case if the free and used blocks count obtained looking at the bitmap is different from what the

Re: [PATCH] allocate struct ext4_allocation_context from a kmem cache to save stack space

2008-02-07 Thread Mingming Cao
On Thu, 2008-02-07 at 19:06 -0600, Eric Sandeen wrote: Mingming Cao wrote: Do you intend to remove the #ifdef CONFIG_PROC_FS, or it's a accident? I think we need keep that to allow ext4 build without procfs configured. Other than this, the patch looks fine to me.:) oh, it kind of

Re: [PATCH] allocate struct ext4_allocation_context from a kmem cache to save stack space

2008-02-07 Thread Eric Sandeen
Mingming Cao wrote: On Thu, 2008-02-07 at 19:06 -0600, Eric Sandeen wrote: Mingming Cao wrote: Do you intend to remove the #ifdef CONFIG_PROC_FS, or it's a accident? I think we need keep that to allow ext4 build without procfs configured. Other than this, the patch looks fine to me.:) oh,

Re: [Bugme-new] [Bug 9911] New: fsync blocks concurrent writes to file

2008-02-07 Thread Andrew Morton
On Thu, 7 Feb 2008 17:40:57 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9911 Summary: fsync blocks concurrent writes to file Product: File System Version: 2.5 KernelVersion: 2.6.23.8 Platform: All

Re: BUG_ON at mballoc.c:3752

2008-02-07 Thread Eric Sandeen
Aneesh Kumar K.V wrote: On Thu, Feb 07, 2008 at 05:30:48PM -0800, Mingming Cao wrote: On Thu, 2008-02-07 at 18:25 +0530, Aneesh Kumar K.V wrote: ext4: Don't panic in case of corrupt bitmap From: Aneesh Kumar K.V [EMAIL PROTECTED] Multiblock allocator was calling BUG_ON in many case if the