Re: [PATCH] UPDATED: building e2fsprogs-interim

2008-02-15 Thread Theodore Tso
On Fri, Feb 15, 2008 at 01:01:28PM -0600, Eric Sandeen wrote: > An update; running through the whole fedora build turned up another > one (csum.o). Out of curiosity do things like ext2_fs.h (which are not > generated) really need to be listed as dependencies? Well, in an RPM build you probably do

[BUG] Linux 2.6.25-rc2 - Kernel Ooops while running dbench

2008-02-15 Thread Kamalesh Babulal
Hi, The 2.6.25-rc2 kernel oopses while running dbench on ext3 filesystem mounted with mount -o data=writeback,nobh option on the x86_64 box BUG: unable to handle kernel NULL pointer dereference at IP: [] kmem_cache_alloc+0x3a/0x6c PGD 1f6860067 PUD 1f5d64067 PMD 0 Oops: [1]

Re: [PATCH] ext4: When reading from fallocated blocks make sure we return zero.

2008-02-15 Thread Aneesh Kumar K.V
On Fri, Feb 15, 2008 at 11:43:04AM -0800, Mingming Cao wrote: > On Fri, 2008-02-15 at 23:46 +0530, Aneesh Kumar K.V wrote: > > fallocate blocks are considered as sparse area and read from them should > > return zero. ext4_ext_get_blocks should return zero for read request. > > > > The patch itsel

Re: [PATCH] ext4: Set directory link count to zero if we fail to create the directory.

2008-02-15 Thread Theodore Tso
I've replaced this patch with the following (see attached). The changes to the patch from Aneesh's original one are: 1) Replace the patch description with one that describes what is going on at a higher level. (Always write with a deep sympathy for the reader, who will be reading the descr

Re: [PATCH] ext4: Fix circular locking dependency with fallocate and touch.

2008-02-15 Thread Theodore Tso
On Tue, Feb 12, 2008 at 02:45:35PM +0530, Aneesh Kumar K.V wrote: > In order to prevent a circular locking dependency when an ext4_create > operation is racing with an ext4_fallocate, we acquire and release > i_data_sem for each multiblock request and use i_mutex to > prevent writes and truncates d

Re: [RFC/PATCH] ext4: Request for journal write access early.

2008-02-15 Thread Theodore Tso
On Thu, Feb 14, 2008 at 04:00:52PM +0530, Aneesh Kumar K.V wrote: > In ext4_ext_convert_to_initialized before we need to request for journal > write access before we even modify the extent length. This isn't a grammatically correct sentence, and it doesn't explain what is going on. I rewrote the

Re: [PATCH] ext4: When reading from fallocated blocks make sure we return zero.

2008-02-15 Thread Mingming Cao
On Fri, 2008-02-15 at 23:46 +0530, Aneesh Kumar K.V wrote: > fallocate blocks are considered as sparse area and read from them should > return zero. ext4_ext_get_blocks should return zero for read request. > The patch itself looks harmless, but I still don't see how this could fix the problem you

Re: [PATCH] UPDATED: building e2fsprogs-interim

2008-02-15 Thread Eric Sandeen
Eric Sandeen wrote: > I needed this patch to build e2fsprogs-interim, to fix a parallel make problem > > Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]> > --- > > > An update; running through the whole fedora build turned up another one (csum.o). Out of curiosity do things like ext2_fs.h (whic

[PATCH] ext4: When reading from fallocated blocks make sure we return zero.

2008-02-15 Thread Aneesh Kumar K.V
fallocate blocks are considered as sparse area and read from them should return zero. ext4_ext_get_blocks should return zero for read request. Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/ext4/extents.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/

Re: [PATCH RESEND] ext4: Fix kernel BUG at fs/ext4/mballoc.c:910!

2008-02-15 Thread Eric Sandeen
Valerie Clement wrote: > Eric Sandeen wrote: >> Valerie Clement wrote: >>> Fix kernel BUG at fs/ext4/mballoc.c:910! >>> >>> From: Valerie Clement <[EMAIL PROTECTED]> >>> >>> With the flex_bg feature enabled, a large file creation oopses the >>> kernel. >> Valerie, what's the specific testcase for t

Re: [PATCH RESEND] ext4: Fix kernel BUG at fs/ext4/mballoc.c:910!

2008-02-15 Thread Valerie Clement
Eric Sandeen wrote: Valerie Clement wrote: Fix kernel BUG at fs/ext4/mballoc.c:910! From: Valerie Clement <[EMAIL PROTECTED]> With the flex_bg feature enabled, a large file creation oopses the kernel. Valerie, what's the specific testcase for this? Thanks, -Eric I just did a simple dd, dd

Re: [RFC] ext3 freeze feature

2008-02-15 Thread Eric Sandeen
Takashi Sato wrote: > Hi, > > Christoph Hellwig wrote: >> On Fri, Feb 08, 2008 at 08:26:57AM -0500, Andreas Dilger wrote: >>> You may as well make the common ioctl the same as the XFS version, >>> both by number and parameters, so that applications which already >>> understand the XFS ioctl will w

Re: [RFC] ext3 freeze feature

2008-02-15 Thread Takashi Sato
Hi, Christoph Hellwig wrote: On Fri, Feb 08, 2008 at 08:26:57AM -0500, Andreas Dilger wrote: You may as well make the common ioctl the same as the XFS version, both by number and parameters, so that applications which already understand the XFS ioctl will work on other filesystems. Yes. In f