Re: [PATCH] ext4: When reading from fallocated blocks make sure we return zero.

2008-02-17 Thread Aneesh Kumar K.V
On Sat, Feb 16, 2008 at 08:53:34AM +0530, Aneesh Kumar K.V wrote: > On Fri, Feb 15, 2008 at 11:43:04AM -0800, Mingming Cao wrote: > > On Fri, 2008-02-15 at 23:46 +0530, Aneesh Kumar K.V wrote: > > > fallocate blocks are considered as sparse area and read from them should > > > return zero. ext4_ext

Re: [2.6 patch] fs/jbd/journal.c: cleanups

2008-02-17 Thread Ingo Molnar
* Andreas Dilger <[EMAIL PROTECTED]> wrote: > > This patch contains the following cleanups: > > - make the following needlessly global function static: > > - journal_check_used_features() > > - remove the following unused EXPORT_SYMBOL's: > > - journal_set_features > > - journal_update_supe

Re: [2.6 patch] fs/jbd/journal.c: cleanups

2008-02-17 Thread Andreas Dilger
On Feb 17, 2008 10:19 +0200, Adrian Bunk wrote: > This patch contains the following cleanups: > - make the following needlessly global function static: > - journal_check_used_features() > - remove the following unused EXPORT_SYMBOL's: > - journal_set_features > - journal_update_superblock N

Re: [PATCH 2/7] fs/ext{2,3,4}: Use BUG_ON

2008-02-17 Thread Theodore Tso
On Sun, Feb 17, 2008 at 06:55:06PM +0100, Julia Lawall wrote: > From: Julia Lawall <[EMAIL PROTECTED]> > > if (...) BUG(); should be replaced with BUG_ON(...) when the test has no > side-effects to allow a definition of BUG_ON that drops the code completely. Hi, in the future, please separate ext

[PATCH 2/7] fs/ext{2,3,4}: Use BUG_ON

2008-02-17 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> if (...) BUG(); should be replaced with BUG_ON(...) when the test has no side-effects to allow a definition of BUG_ON that drops the code completely. fs/ext2/balloc.c |3 +-- fs/ext2/dir.c|3 +-- fs/ext3/balloc.c |3 +-- fs/ext4/balloc.c |

Re: [PATCH 1/3] ext2: improve ext2_readdir() return value

2008-02-17 Thread Akinobu Mita
2008/2/17, Theodore Tso <[EMAIL PROTECTED]>: > On Sun, Feb 17, 2008 at 02:56:13PM +0900, Akinobu Mita wrote: > > This patch improves ext2_readdir() return value for ext2_get_page() failure > > by using the actual result of ext2_get_page(). > > > - return -EIO; > > +

Re: [PATCH 1/3] ext2: improve ext2_readdir() return value

2008-02-17 Thread Theodore Tso
On Sun, Feb 17, 2008 at 02:56:13PM +0900, Akinobu Mita wrote: > This patch improves ext2_readdir() return value for ext2_get_page() failure > by using the actual result of ext2_get_page(). > - return -EIO; > + return PTR_ERR(page); The patch is harmless, an

[2.6 patch] fs/jbd/journal.c: cleanups

2008-02-17 Thread Adrian Bunk
This patch contains the following cleanups: - make the following needlessly global function static: - journal_check_used_features() - remove the following unused EXPORT_SYMBOL's: - journal_set_features - journal_update_superblock Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patc

[2.6 patch] make ext{3,4}_xattr_list() static

2008-02-17 Thread Adrian Bunk
This patch makes the needlessly global ext{3,4}_xattr_list() static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- fs/ext3/xattr.c |4 +++- fs/ext3/xattr.h |7 --- fs/ext4/xattr.c |4 +++- fs/ext4/xattr.h |7 --- 4 files changed, 6 insertions(+), 16 deletions(-) 8f