The patch titled
ext2: improve ext2_readdir() return value
has been added to the -mm tree. Its filename is
ext2-improve-ext2_readdir-return-value.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
The patch titled
ext2: use ext2_group_first_block_no()
has been added to the -mm tree. Its filename is
ext2-use-ext2_group_first_block_no.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c)
The patch titled
ext2: use ext2_fsblk_t type
has been added to the -mm tree. Its filename is
ext2-use-ext2_fsblk_t-type.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the
The patch titled
ext3: use ext3_group_first_block_no()
has been added to the -mm tree. Its filename is
ext3-use-ext3_group_first_block_no.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c)
The patch titled
ext3: add missing ext3_journal_stop()
has been added to the -mm tree. Its filename is
ext3-add-missing-ext3_journal_stop.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c)
The patch titled
ext3: use ext3_get_group_desc()
has been added to the -mm tree. Its filename is
ext3-use-ext3_get_group_desc.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find
The patch titled
ext3: check ext3_journal_get_write_access() errors
has been added to the -mm tree. Its filename is
ext3-check-ext3_journal_get_write_access-errors.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable
The patch titled
Use page_cache_xxx in fs/ext3
has been added to the -mm tree. Its filename is
use-page_cache_xxx-in-fs-ext3.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find
The patch titled
ext4: check ext4_journal_get_write_access() errors
has been added to the -mm tree. Its filename is
ext4-check-ext4_journal_get_write_access-errors.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable
The patch titled
ext4: use ext4_group_first_block_no()
has been added to the -mm tree. Its filename is
ext4-use-ext4_group_first_block_no.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c)
The patch titled
ext4: add missing ext4_journal_stop()
has been added to the -mm tree. Its filename is
ext4-add-missing-ext4_journal_stop.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c)
The patch titled
ext4: use ext4_get_group_desc()
has been added to the -mm tree. Its filename is
ext4-use-ext4_get_group_desc.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find
We would like to get notified when we are doing a write on mmap section.
This is needed with respect to preallocated area. We split the preallocated
area into initialzed extent and uninitialzed extent in the call back. This
let us handle ENOSPC better. Otherwise we get ENOSPC in the writepage and
IF we fail fallocate don't call ext4_error. Also don't hide errors
from ext4_get_blocks_wrap
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/extents.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index
On Mon, Feb 18, 2008 at 08:12:29AM +0100, Ingo Molnar wrote:
Nack. I don't object to un-exporting journal_update_superblock(),
because that is pretty internal, but the other functions are intended
specifically for use by code outside of JBD. For example, the journal
checksum patch for
On Mon, Feb 18, 2008 at 06:49:36AM -0500, Theodore Tso wrote:
On Mon, Feb 18, 2008 at 08:12:29AM +0100, Ingo Molnar wrote:
Nack. I don't object to un-exporting journal_update_superblock(),
because that is pretty internal, but the other functions are intended
specifically for use by
* Theodore Tso [EMAIL PROTECTED] wrote:
I'm going to NACK it as well. This kind of code churn where we make
symbols static only to make them non-static again in an existing ext4
tree is exactly the sort of needless code churn that makes patches
start to conflict and where we need
On Sat, 16 Feb 2008 11:14:46 +0530 Kamalesh Babulal [EMAIL PROTECTED] wrote:
The 2.6.25-rc2 kernel oopses while running dbench on ext3 filesystem
mounted with mount -o data=writeback,nobh option on the x86_64 box
BUG: unable to handle kernel NULL pointer dereference at
IP:
On Mon, Feb 18, 2008 at 03:12:09PM +0200, Adrian Bunk wrote:
If me resending this old patch collides with something finally getting a
user this part of my patch shouldn't be applied now (but you might get
it again in 6 months if it's still unused...).
But generally such conflicts would
So please deal with it like most other subsystem maintainers do and stop
complaining about code churn - nobody but you changes the ext3
codebase, it's one of the codebases least affected by general kernel
flux, it's an ultimate leaf subsystem.
Right, sorry. I misread the filename; I
* Adrian Bunk [EMAIL PROTECTED] wrote:
The following was meant 100% seriously:
This patch has been sent on:
- 16 May 2006
- 1 May 2006
- 23 Apr 2006
ouch ...
i guess this explains what static code metrics already suggest:
$ code-quality fs/ext3/ fs/ext4/
Two x86-64 boxes here lock up here on 2.6.25-rc2, shortly after boot.
One running Fedora 8 + X (GNOME) and one a headless file server.
configs and lspci attached. Unable to capture any splatter so far.
Bisecting...
00:00.0 Host bridge: Intel Corporation 82955X Memory Controller Hub
00:01.0
Eric Sandeen wrote:
Taking a cue from getfattr... if a string is mostly
printable characters, go ahead print as a string,
and escape what's left over.
Ted, ping on this? Since we use selinux a lot, it'd be nice to have
something readable in debugfs output.
If there's anything you don't like
* Theodore Tso [EMAIL PROTECTED] wrote:
On Mon, Feb 18, 2008 at 02:31:40PM +0100, Ingo Molnar wrote:
i guess this explains what static code metrics already suggest:
Am I right in assuming that code-quality is just a program which runs
checkpatch.pl and measures the number of warnings and
Eric Sandeen wrote:
So this trips up on things like sockets, fifos, and block char nodes.
Just to demonstrate; doing this on ext4:
mknod mnt/block b 1 1
mknod mnt/char c 1 1
mknod mnt/fifo p
mksock mnt/sock
mkdir -p
Andreas Dilger wrote:
Support for checking 32-bit extents format inodes and the INCOMPAT_EXTENTS
feature.
Clear the high 16 bits of extents and index entries, since the
extents patches did not do this explicitly. Some parts of this
code need fixing for checking 32-bit block filesystems
On Mon, Feb 18, 2008 at 11:56:53AM -0600, Eric Sandeen wrote:
So this trips up on things like sockets, fifos, and block char nodes.
Also this is unhappy:
@@ -137,7 +141,7 @@ int e2fsck_pass1_check_device_inode(ext2
* If the index flag is set, then this is a bogus
*
Theodore Tso wrote:
On Mon, Feb 18, 2008 at 11:56:53AM -0600, Eric Sandeen wrote:
So this trips up on things like sockets, fifos, and block char nodes.
Also this is unhappy:
@@ -137,7 +141,7 @@ int e2fsck_pass1_check_device_inode(ext2
* If the index flag is set, then this is a bogus
e2fsck doesn't expect to find char, block, fifo, or socket
files with the extent flag set, so clear that in ext4_mknod.
Signed-off-by: Eric Sandeen [EMAIL PROTECTED]
---
Index: linux-2.6.24/fs/ext4/namei.c
===
---
On Mon, Feb 18, 2008 at 02:48:18PM -0600, Eric Sandeen wrote:
I think we need to get kernel patches into mainline ASAP not to set
the EXTENTS_FL
You mean on devices/fifos/sockets ? Ok.
Yes, sorry for not being explicit.
But today, with 2.6.25-rc1 and e2fsprogs-interim, long
As symlinks are limited to a single block anyway, and e2fsck
doesn't expect to find it set, don't set the extents flag on
any type of symlinks at all: fast/in-inode, or the
external-block flavor.
There are a lot of filesystems out there by now w/ exent-style
symlink blocks though, so e2fsck
I've started testing my in-development extents against the test cases
found in clusterfs's e2fsprogs patches, and I noticed that with
f_extents (the first one I tried), some of the inodes had non-zero
ee_start_hi fields. (That is to say, they had block numbers in the
extents fields that were
On Mon, Feb 18, 2008 at 07:06:58PM -0500, Theodore Ts'o wrote:
The clusterfs e2fsprogs code doesn't notice this, because it apparently
ignores ee_start_hi field entirely.
One minor correction --- the clusterfs e2fsprogs extents code checks
to see if the ee_leaf_hi field is non-zero, and
Please verify, this patch was not yet tested
---
Convert list_for_each_rcu() to list_for_each_entry_rcu()
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index dd0fcfc..0c4dd13 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3127,6
On Mon, Feb 18, 2008 at 10:35:37AM -0600, Eric Sandeen wrote:
Eric Sandeen wrote:
Taking a cue from getfattr... if a string is mostly
printable characters, go ahead print as a string,
and escape what's left over.
Ted, ping on this? Since we use selinux a lot, it'd be nice to have
On Mon, Feb 18, 2008 at 04:14:34PM -0800, Mingming Cao wrote:
On Sat, 2008-02-16 at 08:53 +0530, Aneesh Kumar K.V wrote:
How about the following patch?
Regards,
Mingming
ext4: ext4_get_blocks_wrap fix for writing to preallocated
From: Mingming Cao [EMAIL PROTECTED]
This patch fixed
We would like to get notified when we are doing a write on mmap section.
This is needed with respect to preallocated area. We split the preallocated
area into initialzed extent and uninitialzed extent in the call back. This
let us handle ENOSPC better. Otherwise we get ENOSPC in the writepage and
On Feb 18, 2008 11:56 -0600, Eric Sandeen wrote:
@@ -904,21 +910,75 @@ void e2fsck_pass1(e2fsck_t ctx)
+ eh = (struct ext3_extent_header *)inode-i_block;
+ if ((inode-i_flags EXT4_EXTENTS_FL)) {
+ if ((LINUX_S_ISREG(inode-i_mode) ||
+
On Tue, 2008-02-19 at 08:49 +0530, Aneesh Kumar K.V wrote:
On Mon, Feb 18, 2008 at 04:14:34PM -0800, Mingming Cao wrote:
On Sat, 2008-02-16 at 08:53 +0530, Aneesh Kumar K.V wrote:
How about the following patch?
Regards,
Mingming
ext4: ext4_get_blocks_wrap fix for writing to
On Tue, 2008-02-19 at 09:13 +0530, Aneesh Kumar K.V wrote:
We would like to get notified when we are doing a write on mmap section.
This is needed with respect to preallocated area. We split the preallocated
area into initialzed extent and uninitialzed extent in the call back. This
let us
On Tue, 2008-02-19 at 09:14 +0530, Aneesh Kumar K.V wrote:
IF we fail allocate blocks don't call ext4_error. Also don't hide errors
from ext4_get_blocks_wrap
Aced. And added to patch queue.
Thanks,
Mingming
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/extents.c | 11
Thanks, Added to patch queue
On Mon, 2008-02-18 at 16:27 -0600, Eric Sandeen wrote:
As symlinks are limited to a single block anyway, and e2fsck
doesn't expect to find it set, don't set the extents flag on
any type of symlinks at all: fast/in-inode, or the
external-block flavor.
There are
Acked and added to the patch queue.
On Mon, 2008-02-18 at 15:00 -0600, Eric Sandeen wrote:
e2fsck doesn't expect to find char, block, fifo, or socket
files with the extent flag set, so clear that in ext4_mknod.
Signed-off-by: Eric Sandeen [EMAIL PROTECTED]
---
Index:
On Sun, 2008-02-17 at 15:11 +0900, Akinobu Mita wrote:
Add missing ext4_journal_stop() in error handling.
Reviewed and Acked ext2/3/4 changes.
ext4 patch is also queued in ext4 patch queue
http://repo.or.cz/w/ext4-patch-queue.git
Mingming
Signed-off-by: Akinobu Mita [EMAIL PROTECTED]
Cc:
44 matches
Mail list logo
