We are currently taking the truncate_mutex for every read. This would have
performance impact on large CPU configuration. Convert the lock to read write
semaphore and take read lock when we are trying to read the file.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/ba
The series include the truncate_mutex to read write semaphore conversion. I am
marking below some of the test results.
For O_DIRECT workloads we won't see the contention on truncate mutex because we
are
doing a get_block under inode->i_mutex.
For FIBMAP we won't see contention because the get_
Alex,
This is my attempt at understanding multi block allocator. I have
few questions marked as FIXME below. Can you help answering them.
Most of this data is already in the patch queue as commit message.
I have updated some details regarding preallocation. Once we
understand the details i will up
ext4_ext_get_blocks returns negative values on error. We should
check for <= 0
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/extents.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index a2475d4
We are currently taking the truncate_mutex for every read. This would have
performance impact on large CPU configuration. Convert the lock to read write
semaphore and take read lock when we are trying to read the file.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/ba
When we are overwriting a file and not actually allocating new file system
blocks we need to take only the read lock on i_data_sem.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 32
1 files changed, 24 insertions(+), 8 del
Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/extents.c |7 +++--
fs/ext4/inode.c | 69 +-
include/linux/ext4_fs.h | 12 ++--
3 files changed, 21 insertions(+), 67 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
The below patchset is NOT for patch queue. I am posting it here to get
feedback regarding the approach and what test I need to run to make sure we
are not breaking any locking rules.
I have run dbench, ffsb, fsstress, fs_di, fs_inode, fsx_linux . Bonnie
didn't run completely. In the automated setu
===
[ INFO: possible circular locking dependency detected ]
2.6.24-rc3 #6
---
bash/2294 is trying to acquire lock:
(&journal->j_list_lock){--..}, at: []
journal_try_to_free_buffers+0x76/0x10c
I actually sent in a patch which changes asking for review to
linux-arch. I haven't got the response yet. Attaching the patch
below
Introduce ext4_find_next_bit
From: Aneesh Kumar K.V <[EMAIL PROTECTED]>
This gets used by the ext4 multi block allocator patches.
Andreas suggested me to get the iozone results after multiple runs.
I don't see any performance issue with the blk bitmap validation changes
now.
v2.6.24-rc3-35-g2e12044
File & VM system latencies in microseconds - smaller is better
---
Aneesh Kumar K.V wrote:
This is the updated ext2/3/4 block bitmap validation patches
Changes from the last post
a) moved the bh_uptodate_or_lock and bh_submit_read to
fs/buffer.c and added EXPORT_SYMBOL
b) Updated bh_submit_read not to release buffer on
failure. This handles one
Add buffer head related helper function
bh_uptodate_or_lock and bh_submit_read
which can be used by file system
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/buffer.c | 41 +
include/linux/buffer_head.h |2 ++
2
When a new block bitmap is read from disk in read_block_bitmap()
there are a few bits that should ALWAYS be set. In particular,
the blocks given corresponding to block bitmap, inode bitmap and inode tables.
Validate the block bitmap against these blocks.
Signed-off-by: Aneesh Kumar K.V <[EM
When a new block bitmap is read from disk in read_block_bitmap()
there are a few bits that should ALWAYS be set. In particular,
the blocks given corresponding to block bitmap, inode bitmap and inode tables.
Validate the block bitmap against these blocks.
Signed-off-by: Aneesh Kumar K.V <[EM
When a new block bitmap is read from disk in read_block_bitmap()
there are a few bits that should ALWAYS be set. In particular,
the blocks given corresponding to block bitmap, inode bitmap and inode tables.
Validate the block bitmap against these blocks.
Signed-off-by: Aneesh Kumar K.V <[EM
This is the updated ext2/3/4 block bitmap validation patches
Changes from the last post
a) moved the bh_uptodate_or_lock and bh_submit_read to
fs/buffer.c and added EXPORT_SYMBOL
b) Updated bh_submit_read not to release buffer on
failure. This handles one reference handling bug in the
e
When a new block bitmap is read from disk in read_block_bitmap()
there are a few bits that should ALWAYS be set. In particular,
the blocks given corresponding to block bitmap, inode bitmap and inode tables.
Validate the block bitmap against these blocks.
Signed-off-by: Aneesh Kumar K.V <[EM
When a new block bitmap is read from disk in read_block_bitmap()
there are a few bits that should ALWAYS be set. In particular,
the blocks given corresponding to block bitmap, inode bitmap and inode tables.
Validate the block bitmap against these blocks.
Signed-off-by: Aneesh Kumar K.V <[EM
Add buffer head related helper function
bh_uptodate_or_lock and bh_submit_read
which can be used by file system
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
include/linux/buffer_head.h | 29 +
1 files changed, 29 insertions(+), 0 deletions(-)
diff
When a new block bitmap is read from disk in read_block_bitmap()
there are a few bits that should ALWAYS be set. In particular,
the blocks given corresponding to block bitmap, inode bitmap and inode tables.
Validate the block bitmap against these blocks.
Signed-off-by: Aneesh Kumar K.V <[EM
This series contain the block bitmap validation
patch reworked as per Linus suggestion. I am
attaching below the iozone and lmbench results.
The lmbench summary is inlined below
File & VM system latencies in microseconds - smaller is better
--
Andrew Morton wrote:
On Fri, 21 Sep 2007 10:55:05 +0530 "Aneesh Kumar K.V" <[EMAIL PROTECTED]> wrote:
Also add generic_find_next_le_bit
This gets used by the ext4 multi block allocator patches.
arm allmodconfig:
fs/ext4/mballoc.c: In function `ext4_mb_generate_buddy
Aneesh Kumar K.V wrote:
Aneesh Kumar K.V wrote:
Hi All,
I looked at the delalloc and reservation differences that Valerie was
observing.
Below is my understanding. I am not sure whether the below will result
in higher fragmentation that Eric Sandeen is observing. I guess it
should not
Aneesh Kumar K.V wrote:
Hi All,
I looked at the delalloc and reservation differences that Valerie was
observing.
Below is my understanding. I am not sure whether the below will result
in higher fragmentation that Eric Sandeen is observing. I guess it
should not. Even
though the reservation
Alex Tomas wrote:
sorry, I don't quite understand how do you observe this with nomballoc
thanks, Alex
Aneesh Kumar K.V wrote:
mballoc by default doesn't give the particular layout only if i force
small
size to use inode preallocation i am hitting the problem. ie to change
the
Alex Tomas wrote:
Hi,
could you try the patch attached. it should fix the issue. the idea
was to align requests in order to help raid5-like setups. but somewhere
I lost one bit in mballoc: it should pre-allocate all crossed stripes,
but it didn't.
as for discard, lustre doesn't use open/close
I guess the list dropped this mail. Sending again.
-aneesh
--- Begin Message ---
Aneesh Kumar K.V wrote:
Hi All,
I looked at the delalloc and reservation differences that Valerie was
observing.
Below is my understanding. I am not sure whether the below will result
in higher fragmentation
Hi All,
I looked at the delalloc and reservation differences that Valerie was observing.
Below is my understanding. I am not sure whether the below will result in
higher fragmentation that Eric Sandeen is observing. I guess it should not. Even
though the reservation gets discarded during the cl
Valerie Clement wrote:
Hi all,
I ran a small test which creates one directory and 2O 8-KB size files in
it.
When the filesystem is mounted without the delalloc option, here is the
output of the command dumpe2fs for the group in which the directory and
the files are created:
Group 532 : (
This fix some instances where we were continuing
after calling ext2_error. ext2_error call panic
only if errors=panic mount option is set. So
we need to make sure we return correctly after
ext2_error call
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext2/balloc.c
Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext2/super.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 3d2019e..eb1a392 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -234,16 +234,16 @@ static int ext2_show_o
Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext3/super.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 0bfd3dc..6cfdd06 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -575,16 +575,16 @@ static int ext3_show_o
This fix some instances where we were continuing
after calling ext3_error. ext3_error calls panic
only if errors=panic mount option is set. So
we need to make sure we return correctly after
ext3_error call
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext3/balloc.c
Eric Sandeen wrote:
Aneesh Kumar K.V wrote:
We need to look at the default value and make sure
the mount options are not set via default value
before showing them via ext4_show_options
Hm, does this jive with the comment about what's intended?
/*
* Show an option if
* - it'
Send some patches which are in my local repo for review.
The compile bench fix patch is already in patch queue.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Eric Sandeen wrote:
Aneesh Kumar K.V wrote:
@@ -1279,6 +1280,9 @@ clear_qf_name:
case Opt_delalloc:
set_opt (sbi->s_mount_opt, DELALLOC);
break;
If delalloc, mballoc, extents are the new defaults, is there a reason to
k
This ensure we test the latest features more easily.
We need an option to clear delayed alloc feature.
Add nodealloc option.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/super.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/sup
This fix the mballoc bug when running compile bench.
Instead of using direct division even though the arguments
are 32 bits we retain do_div. This would be needed if we
move to 64 bit logical block number.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/mballoc.c
Send some patches which are in my local repo for review.
The compile bench fix patch is already in patch queue.
GIT: Please enter your email below.
GIT: Lines beginning in "GIT: " will be removed.
GIT: Consider including an overall diffstat or table of contents
GIT: for the patch you are writing.
We need to look at the default value and make sure
the mount options are not set via default value
before showing them via ext4_show_options
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/super.c | 28
1 files changed, 16 insertions(
Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/super.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 10feae6..62d7ec8 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -691,16 +691,16 @@ static int ext4_show_o
Both these options are enabled by default.
So if they are are not set in mount options
that means the user explicity disabled them
using nomablloc and nodelalloc option. Show
the same in ext4_show_options
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/super.c |6 +++
Send some patches which are in my local repo for review.
The compile bench fix patch is already in patch queue.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
__acquires(kernel_sem)
+
{
struct buffer_head * bh;
struct ext4_super_block *es = NULL;
ext4: Fix sparse warnings.
From: Aneesh Kumar K.V <[EMAIL PROTECTED]>
Fix sparse warnings related to static functions
and local variables.
Signed-off-by: Aneesh Kumar K.V <[EMAIL
Chris Mason wrote:
On Tue, 23 Oct 2007 18:13:53 +0530
"Aneesh Kumar K.V" <[EMAIL PROTECTED]> wrote:
I get this error while running compilebench
http://oss.oracle.com/~mason/compilebench/compilebench-0.4.tar.bz2
I've uploaded compilebench-0.6.tar.bz2 and up
I get this error while running compilebench
http://oss.oracle.com/~mason/compilebench/compilebench-0.4.tar.bz2
elm3b138:~/compilebench-0.4# ./compilebench -d /ext4/
using working directory /ext4/, 30 intial dirs 100 runs
native unpatched native-0 222MB in 9.17 seconds (24.25 MB/s)
native p
I gues Ted is following the same terminology.
http://marc.info/?l=git&m=117965490313979&w=2
There are four branches in git.git repository that track the
source tree of git: "master", "maint", "next", and "pu". I may
add more maintenance branches (e.g. "maint-1.5.1") if we have
huge backward in
This fix some instances where we were continuing
after calling ext4_error. ext4_error call panic
only if errors=panic mount option is set. So
we need to make sure we return correctly after
ext4_error call
Reported by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Aneesh Kumar K.V &
The max file size for ext2 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext2/super.c | 32
1 files changed, 28 inse
The max file size for ext3 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext3/super.c | 32
1 files changed, 28 inse
y the Coverity checker.
From 5c04ec0d8e43ef582cec2856f262b575376233ba Mon Sep 17 00:00:00 2001
From: Aneesh Kumar K.V <[EMAIL PROTECTED]>
Date: Fri, 19 Oct 2007 20:10:17 +0530
Subject: [PATCH] ext4: Return after ext4_error in case of failures
This fix some instances where we were continuing
after ma
. Super block with this feature set cannot
be mounted read write on a kernel with CONFIG_LSF disabled.
Super block flag EXT4_FEATURE_RO_COMPAT_HUGE_FILE
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 58 ++-
fs/ext4/s
whose i_blocks cannot be represnted as 512 byte units in a
48 bit variable.
inode flag EXT4_HUGE_FILE_FL
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 34 ++
fs/ext4/super.c |9 ++---
include/linux/ext4_fs.h
rename ext4_inode.i_dir_acl to i_size_high
drop ext4_inode_info.i_dir_acl as it is not used
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/ialloc.c |1 -
fs/ext4/inode.c | 55 ++---
include/linux/ext4_fs.h
Fix sparse warnings.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/extents.c |6 +++---
fs/ext4/inode.c | 14 --
include/linux/ext4_fs.h |2 ++
3 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/fs/ext4/extents.c b/f
rename i_file_acl to i_file_acl_lo
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c |4 ++--
include/linux/ext4_fs.h |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 8908ab3..ef073df 100644
Introduce ext4_update_*_feature and use them instead
of opencoding.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/ialloc.c| 11 +++-
fs/ext4/super.c | 60 +++
include/linux/ext4_fs.h |6
3
Hi Mingming,
The patch queue updated on top of d85714d81cc0408daddb68c10f7fd69eafe7c213
The commit d85714d81cc0408daddb68c10f7fd69eafe7c213 contain changes that
Andrew pushed to linus which had conflicts with patches in the patch queue.
The update fixes them.
Changes
a) ext4_grpnum_t.patch g
I am wondering whether we can use i_size_high without looking at
file mode (why restrict only to regular files ? )
-aneesh
From a5796eb4af173d2a0a9b8f0f80a8af12bf3e2695 Mon Sep 17 00:00:00 2001
From: Aneesh Kumar K.V <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 12:25:18 +0530
Subject:
Theodore Ts'o wrote:
* ak/undo-mgr (Mon Aug 13 15:56:26 2007 +0530) 9 commits
- e2fsprogs: Add test case for undoe2fs
- e2fsprogs: Fix the resize inode test case
- e2fsprogs: Support for large inode migration.
- e2fsprogs: Make mke2fs use undo I/O manager.
- e2fsprogs: Add undoe2fs
- e2f
The max file size for ext2 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext2/super.c | 32
1 files changed, 28 inse
The max file size for ext3 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext3/super.c | 32
1 files changed, 28 inse
a) Introduce ext4_update_*_feature(sb,
b) rename i_file_acl to i_file_acl_lo
c) convert some function to static
d) Fix sparse warnings
---
fs/ext4/extents.c |6 ++--
fs/ext4/ialloc.c| 13 +--
fs/ext4/inode.c | 18 +---
fs/ext4/super.c | 5
. Super block with this feature set cannot
be mounted read write on a kernel with CONFIG_LSF disabled.
Super block flag EXT4_FEATURE_RO_COMPAT_HUGE_FILE
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 58 ++-
fs/ext4/s
whose i_blocks cannot be represnted as 512 byte units in a
48 bit variable.
inode flag EXT4_HUGE_FILE_FL
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 34 ++
fs/ext4/super.c |9 ++---
include/linux/ext4_fs.h
Hi,
Can we get this patches added to patch queue.
The set 5 patches replace the large-file.patch
in the patch queue.
The last two patches in the series can be dropped
when akpm merges them directly. Till then i think
patch queue can act as a placeholder.
-aneesh
-
To unsubscribe from this list
Andreas Dilger wrote:
On Oct 12, 2007 10:06 +0530, Aneesh Kumar K.V wrote:
We add a RO_COMPAT feature to the super
block to indicate that some of the inode have i_blocks
represented as file system block size units. Super block
with this feature set cannot be mounted read write on a kernel
Andreas Dilger wrote:
On Oct 12, 2007 10:06 +0530, Aneesh Kumar K.V wrote:
use the __le16 l_i_reserved1 field of the linux2
struct of ext4_inode to represet the higher 16
bits for i_blocks. With this change max_file size becomes
(2**48 -1 )* 512 bytes.
+static int ext4_inode_blocks_set
use the __le16 l_i_reserved1 field of the linux2
struct of ext4_inode to represet the higher 16
bits for i_blocks. With this change max_file size becomes
(2**48 -1 )* 512 bytes.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c
CONFIG_LSF disabled.
Super block flag EXT4_FEATURE_RO_COMPAT_HUGE_FILE
inode flag EXT4_HUGE_FILE_FL
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 41 +++--
fs/ext4/super.c |9 ++---
include/linux/ext4_fs.h
Andreas Dilger wrote:
On Oct 11, 2007 20:20 +0530, Aneesh Kumar K.V wrote:
+ /* indirect blocks */
+ meta_blocks = 1;
+ /* double indirect blocks */
+ meta_blocks += 1 + (1LL << (bits-2));
+ /* tripple indirect blocks */
+ meta_blocks += 1 + (1LL &l
Right now we do this in ext4_do_update_inode
if (ei->i_disksize > 0x7fffULL) {
.
.
EXT4_SET_RO_COMPAT_FEATURE(sb, EXT4_FEATURE_RO_COMPAT_LARGE_FILE);
That is if i_disksize is greater that 2**31 -1 we set the flag
But in ext4_inode the size of i_size is 32 bits
__le32 i_size;
The max file size for ext2 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext2/super.c | 32
1 files changed, 28 inse
The max file size for ext3 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext3/super.c | 32
1 files changed, 28 inse
in e2fsprogs we have
union {
struct {
__u16 l_i_blocks_hi;
__u16 i_pad1;
__u16 l_i_uid_high; /* these 2 fields*/
__u16 l_i_gid_high; /* were reserved2[0] */
Andreas Dilger wrote:
On Oct 10, 2007 22:07 +0530, Aneesh Kumar K.V wrote:
I am hitting this with the below config
mke2fs -j -I 256 -O lazy_bg $dev
Note that "-O lazy_bg" has nothing really to do with the uninit_groups
feature. Also, if you don't have the CFS e2fspr
Andreas Dilger wrote:
On Oct 11, 2007 10:41 +0530, Aneesh Kumar K.V wrote:
This patch converts ext4_inode i_blocks to represent total
blocks occupied by the inode in file system block size.
Earlier the variable used to represent this in 512 byte
block size. This actually limited the total
nly if the incompat feature flag
EXT4_FEATURE_INCOMPAT_LARGE_BLOCK is set in super block
and the kernel is built with CONFIG_LSF.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 21 -
fs/ext4/super.c
I am hitting this with the below config
mke2fs -j -I 256 -O lazy_bg $dev
mount -t ext4dev $dev /mnt/tmp -o "extents,mballoc"
and running fsstress on /mnt/tmp/
jbd2_journal_bmap: journal block not found at offset 31780 on sda7
Aborting journal on device sda7.
ext4_abort called.
EXT4-fs e
Mingming Cao wrote:
On Wed, 2007-10-10 at 17:35 +0530, Aneesh Kumar K.V wrote:
I have updated the patch queue at
http://www.radian.org/~kvaneesh/ext4/patch-series/
http://www.radian.org/~kvaneesh/ext4/patch-series/ext4-patch-queue.tar
Changes:
a) Add large-file-blocktype.patch large
I have updated the patch queue at
http://www.radian.org/~kvaneesh/ext4/patch-series/
http://www.radian.org/~kvaneesh/ext4/patch-series/ext4-patch-queue.tar
Changes:
a) Add large-file-blocktype.patch large-file.patch patch.
b) Add the stable-boundary-patch with dummy change
c) Add stable-bound
This is what i have now . But still i am not able to map the magic number
#include
main()
{
unsigned long long upper_limit;
int meta_blocks;
int bits = 12;
/* total blocks in 512 bytes */
upper_limit = (1LL << 32) -1;
/* total blocks in file syste
Hi,
I am looking at ext4_max_size and was confused how the
number upper_limit = 0x1ff7fffd000LL is arrived.
The comment says the value is arrived looking at 4K.
So i tried the below program.
main()
{
unsigned long long upper_limit, meta_blocks;
int bits = 12;
/* total
have a block number 2**32 -1 which
will result in overflow if the block number is represented by
signed long. This patch convert all the block number to type
ext4_inoblk_t which is typedef to __u32
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/extents.c
Valerie Clement wrote:
Aneesh Kumar K.V wrote:
+if (block_group == sbi->s_gdb_count - 1) {
+/*
+ * Even though mke2fs always initialize first and last group
+ * if some other tool enabled the EXT4_BG_BLOCK_UNINIT we need
+ * to make sure we calculate
Aneesh Kumar K.V wrote:
115908 | fsstress--2.6.23-rc9--ppc64 | f | gekko-lp4 |
http://abat.linux.ibm.com/abat-repo/logs/[EMAIL PROTECTED]
Same here
EXT4-fs: mballoc enabled
[ cut here ]
kernel BUG at fs/ext4/mballoc.c:1607!
cpu 0x0: Vector: 700 (Program
Aneesh Kumar K.V wrote:
Andreas Dilger wrote:
On Oct 03, 2007 15:30 +0530, Aneesh Kumar K.V wrote:
+if (block_group == sbi->s_gdb_count - 1) {
+/*
+ * Even though mke2fs always initialize first and last group
+ * if some other tool enabled
Andreas Dilger wrote:
On Oct 03, 2007 15:30 +0530, Aneesh Kumar K.V wrote:
+ if (block_group == sbi->s_gdb_count - 1) {
+ /*
+* Even though mke2fs always initialize first and last group
+ * if some other tool enabled the EXT4_BG_BLOCK_UNINIT we
n
Hi,
This contain fixes for making mballoc work with uninitialized block group.
The patches can be downloaded from
http://www.radian.org/~kvaneesh/ext4/oct-3-2007/
The diff is attached below to find out what changed.
Mingming,
Can you replace the patch in the patch queue with the above two
We should actually get this error
dd: writing to `myfile5': No space left on device
[EMAIL PROTECTED]:~# mount /dev/hdc -t ext4dev -o delalloc,data=writeback /ext4
[EMAIL PROTECTED]:/ext4# df -h .
FilesystemSize Used Avail Use% Mounted on
/dev/hdc 49M 46M 94K
Andreas Dilger wrote:
On Oct 02, 2007 11:24 +0200, Valerie Clement wrote:
Currently, the mballoc feature is not compatible with the uninit_groups
feature. I have just tried a simple test which failed. Isn't this a problem?
I thought Avantika posted the incremental patch to ext4 mballoc to w
Valerie Clement wrote:
Avantika Mathur wrote:
Multiple Block Allocation:
- Main outstanding issue is still need for better documentation of the
code.
- Aneesh has marked the places that need explanation with fixme, and
Alex will be adding the needed comments. If this gets done quickly,
we
Mingming Cao wrote:
BUG: unable to handle kernel paging request at virtual address 104b
printing eip:
c0195bd3
*pde =
Oops: [#1]
PREEMPT SMP
Modules linked in: vboxdrv binfmt_misc fuse coretemp hwmon gspca videodev v4l2_common v4l1_compat iwl3945 mac80211 tifm_7xx1 tifm
Theodore Ts'o wrote:
Here's an initial code review of the mballoc-core.patch. As far as I
can tell, the patch sent by Aneesh doesn't address any of these.
Aneesh, assuming that you'll be fixing these, could you please combine
your last set of fixes with fixes to address these, and send out an
Hi
This is the changes with which i am going to update the mballoc core patch.
There is a new FIXME in here which i would like others to look at.
Also the commit message is updated to explain the mballoc
approach.
Mingming,
I have placed the new patch at
http://www.radian.org/~kvaneesh/ext4
Andrew Morton wrote:
On Tue, 11 Sep 2007 13:59:26 +0530 "Aneesh Kumar K.V" <[EMAIL PROTECTED]> wrote:
I have updated the mballoc patches.
Has anyone reviewed this stuff? I don't see much evidence of it here?
Just a quick scan shows up heavy over-inlining, many
m
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/fsync.c |2 +-
fs/ext4/inode.c |2 +-
fs/ext4/xattr.c |4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index 2a167d7..8d50879 100644
--- a/fs/ext4/fsync.c
++
Convert ext4_extent_idx.ei_leaf ext4_extent_idx.ei_leaf_lo
This helps in finding BUGs due to direct partial access of
these split 48 bit values.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/extents.c |4 ++--
fs/ext4/migrate.c
Convert s_r_blocks_count and s_free_blocks_count to
s_r_blocks_count_lo and s_free_blocks_count_lo
This helps in finding BUGs due to direct partial access of
these split 64 bit values
Also fix direct partial access in ext4 code
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
f
101 - 200 of 349 matches
Mail list logo
