Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block size

2007-10-18 Thread Christoph Lameter
On Wed, 17 Oct 2007, Andrew Morton wrote: > b) what happens when an old ext2 driver tries to read and/or write this >directory entry? Do we need a compat flag for it? Old ext2 only supports up to 4k include/linux/ext2_fs.h: #define EXT2_MIN_BLOCK_SIZE 1024 #define EXT2_MAX_BLOC

Re: [PATCH] jbd2: JBD replace jbd2_kmalloc with kmalloc

2007-10-08 Thread Christoph Lameter
Acked-by: Christoph Lameter <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] jbd: JBD replace jbd_kmalloc with kmalloc

2007-10-08 Thread Christoph Lameter
On Mon, 8 Oct 2007, Mingming Cao wrote: > So we replace jbd_kmalloc() to kmalloc() with __GFP_NOFAIL flag on in > start_this_handle(). Other two places replacing to kmalloc() is part of > the init process, so no need for __GFP_NOFAIL flag there. Acked-by: Christoph Lameter <[EMA

Re: [PATCH] jbd: JBD replace jbd_kmalloc with kmalloc

2007-10-08 Thread Christoph Lameter
On Fri, 5 Oct 2007, Mingming Cao wrote: > Index: linux-2.6.23-rc9/fs/jbd/transaction.c > === > --- linux-2.6.23-rc9.orig/fs/jbd/transaction.c2007-10-05 > 12:08:08.0 -0700 > +++ linux-2.6.23-rc9/fs/jbd/transaction.c

Re: [PATCH 2/2] ext3: Avoid rec_len overflow with 64KB block size

2007-10-01 Thread Christoph Lameter
[Note that these will also be useful for 64K IA64 configurations] Acked-by: Christoph Lameter <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

Re: [PATCH 1/2] ext3: Support large blocksize up to PAGESIZE

2007-10-01 Thread Christoph Lameter
Acked-by: Christoph Lameter <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block size

2007-10-01 Thread Christoph Lameter
Acked-by: Christoph Lameter <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ext2: Support large blocksize up to PAGESIZE

2007-10-01 Thread Christoph Lameter
Acked-by: Christoph Lameter <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ext4: Avoid rec_len overflow with 64KB block size

2007-10-01 Thread Christoph Lameter
Acked-by: Christoph Lameter <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ext4: Support large blocksize up to PAGESIZE

2007-10-01 Thread Christoph Lameter
Acked-by: Christoph Lameter <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] JBD slab cleanups

2007-09-14 Thread Christoph Lameter
Thanks Mingming. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC 1/2] JBD: slab management support for large block(>8k)

2007-09-03 Thread Christoph Lameter
On Mon, 3 Sep 2007, Christoph Hellwig wrote: > > How about getting rid of the slabs there and use kmalloc? Kmalloc in mm > > (and therfore hopefully 2.6.24) will convert kmallocs > PAGE_SIZE to page > > allocator calls. Not sure what to do about the 1k and 2k requests though. > > The problem is

Re: [RFC 1/2] JBD: slab management support for large block(>8k)

2007-09-03 Thread Christoph Lameter
On Sun, 2 Sep 2007, Christoph Hellwig wrote: > > We are doing what you describe right now. So the current code is broken? > Yes. How about getting rid of the slabs there and use kmalloc? Kmalloc in mm (and therfore hopefully 2.6.24) will convert kmallocs > PAGE_SIZE to page allocator calls. Not

Re: [RFC 1/2] JBD: slab management support for large block(>8k)

2007-09-02 Thread Christoph Lameter
On Sat, 1 Sep 2007, Christoph Hellwig wrote: > On Fri, Aug 31, 2007 at 05:12:18PM -0700, Mingming Cao wrote: > > >From clameter: > > Teach jbd/jbd2 slab management to support >8k block size. Without this, it > > refused to mount on >8k ext3. > > > But the real fix is to kill this code. We can'

Re: [RFC 1/4] Large Blocksize support for Ext2/3/4

2007-08-29 Thread Christoph Lameter
On Wed, 29 Aug 2007, Mingming Cao wrote: > It's quite simple to support large block size in ext2/3/4, mostly just > enlarge the block size limit. But it is NOT possible to have 64kB > blocksize on ext2/3/4 without some changes to the directory handling > code. The reason is that an empty 64kB di

Re: [36/37] Large blocksize support for ext2

2007-06-20 Thread Christoph Lameter
On Wed, 20 Jun 2007, Andreas Dilger wrote: > On Jun 20, 2007 11:29 -0700, [EMAIL PROTECTED] wrote: > > This adds support for a block size of up to 64k on any platform. > > It enables the mounting filesystems that have a larger blocksize > > than the page size. > > Might have been good to CC the

Re: [PATCH 1/9] readahead: introduce PG_readahead

2007-05-20 Thread Christoph Lameter
On Sun, 20 May 2007, Fengguang Wu wrote: > The reuse code would look like the attached one. > It still needs more testing, and would fail if Christoph reuses > PG_reclaim in higher order pagecache in the future. Do not worry about that. All higher order pagecache patchsets remove that sharing bec

Re: [RFC/PATCH] ext3: remove inode constructor

2007-05-04 Thread Christoph Lameter
On Fri, 4 May 2007, Pekka J Enberg wrote: > Index: 2.6/fs/ext3/super.c > === > --- 2.6.orig/fs/ext3/super.c 2007-05-04 12:57:09.0 +0300 > +++ 2.6/fs/ext3/super.c 2007-05-04 13:01:27.0 +0300 > @@ -444,17 +444,26