debug fs routine.
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
---
debugfs/util.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/debugfs/util.c b/debugfs/util.c
index c6096ab..53a0813 100644
--- a/debugfs/util.c
+++ b/debugfs/util.c
@@ -187,7 +
On 23:05 Сбт 16 Июн , Andrew Morton wrote:
>
> someone ort to fix this
duplicate: http://bugzilla.kernel.org/show_bug.cgi?id=5079
Already fixed by:
commit 4d7bf11d649c72621ca31b8ea12b9c94af380e63
Author: Markus Rechberger <[EMAIL PROTECTED]>
Date: Tue May 8 00:23:39 2007 -0700
I don't have s
On 18:31 Чтв 14 Июн , Christoph Hellwig wrote:
> On Wed, Jun 13, 2007 at 05:57:59PM +0400, Dmitriy Monakhov wrote:
> > Function prerform check for signgle region, with out respect to
> > segment nature of iovec, For example writev no longer works :)
>
> Btw, could
al
write before Nick's "write_begin/write_end" patch set, and let's it
behave the same way after.
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
---
drivers/block/loop.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/block/loop.c b/dr
] sys_sync+0xb/0xf
> [] ia32_sysret+0x0/0xa
>
>
> Code: 0f 0b eb fe f0 41 0f ba 75 00 14 48 8b 4c 24 40 01 51 10 48
> RIP [] ext4_wb_submit_extent+0x1ef/0x3d9
> RSP
>
> I will try the patch below...Alex, any hint about the second oops?
>
> Mingming
>
Variable "free" was declarated as __u64 so conidition (free < 0) always
false, even if free was overflowed during substraction.
---
fs/ext4/balloc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 43ae8f8..a9655f1 100644
--- a/fs/
7;s just typo because:
a) In fact this is 100% ENOSPC situation
b) simular function ext4_reserve_local() returns -ENOSPC
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
---
fs/ext4/balloc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/balloc.c b/fs/ext4
Simple test failed on ext4 when delayed allocation was used.
#mkfs.ext3 -b4096 /dev/vzvg/test2
#mount -text4dev /dev/vzvg/test2 /mnt/test -odelalloc
#fsstress -d /mnt/test/ -l100 -n10 -p20 -f dwrite=0
EXT4-fs: writeback error = -28
..
EXT4-fs: writeback error = -28
Unable to handle ker
On 13:43 Срд 13 Июн , Nick Piggin wrote:
> On Wed, Jun 13, 2007 at 05:40:05PM +0400, Dmitriy Monakhov wrote:
> > On 14:19 ?? 29 ?? , [EMAIL PROTECTED] wrote:
> > >
> > > The patch titled
> > > fs: introduce write_begin, write_end, and per
On 14:36 Срд 13 Июн , Hugh Dickins wrote:
> On Wed, 13 Jun 2007, Dmitriy Monakhov wrote:
>
> > loop.c code itself is not perfect. In fact before Nick's patch
> > partial write was't possible. Assumption what write chunks are
> > always page a
"..., 8192}], 2) = -1 EFAULT (Bad
address)
this is hidden bug, and it was invisiable because _fault_in_readable
return value was ignored before. Lets iov_iter_fault_in_readable
perform checks for all segments.
Signed-off-by: Dmitriy Monakhov <[EMAIL PR
loop.c code itself is not perfect. In fact before Nick's patch
partial write was't possible. Assumption what write chunks are
always page aligned is realy weird ( see "index++" line).
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
diff --gi
On 14:19 Втр 29 Май , [EMAIL PROTECTED] wrote:
>
> The patch titled
> fs: introduce write_begin, write_end, and perform_write aops
> has been added to the -mm tree. Its filename is
> fs-introduce-write_begin-write_end-and-perform_write-aops.patch
>
> *** Remember to use Documentati
Dmitriy Monakhov <[EMAIL PROTECTED]> writes:
> - ext3_dx_find_entry() exit with out setting proper error pointer
> - do_split() exit with out setting proper error pointer
>it is realy painful because many callers contain folowing code:
>de = do_split(hand
Andreas Dilger <[EMAIL PROTECTED]> writes:
> On Mar 04, 2007 17:18 +0300, Dmitriy Monakhov wrote:
>> - ext3_dx_find_entry() exit with out setting proper error pointer
>> - do_split() exit with out setting proper error pointer
>>it is realy painful because many ca
- ext3_dx_find_entry() exit with out setting proper error pointer
- do_split() exit with out setting proper error pointer
it is realy painful because many callers contain folowing code:
de = do_split(handle,dir, &bh, frame, &hinfo, &retval);
if (!(de))
Where are many places where _journal_stop() return code wasn't
checked. Off cause _journal_stop() failed very rarely (and usually
with fatal consequences), but this does'n meen it should not be checked.
For example most retry loops looks like follows:
ext3_journal_stop(handle);
introduced by
retries-in-ext3_prepare_write-violate-ordering-requirements:
i_size may increase after error happend.
possible data corruption caused commiting non uptodate bh.
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
-
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index dba6dd
ixes not dirrectly connected with proposed prepare_write semantic changes:
__page_symlink : If find_or_create_page has failed on second retry attempt
function will exit with wrong error code.
__generic_cont_expand: Add correct AOP_TRUNCATED_PAGE handling.
Signed-off-by: Dmitri
jbd function called instead of fs specific one.
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
--
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index beaf25f..8a824f4 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -947,7 +947,7 @@ out:
static int ext3_get_block(struct
Eric Sandeen <[EMAIL PROTECTED]> writes:
> I've been looking at a case where many threads are opening, unlinking, and
> hardlinking files on ext3 .
How many concurent threads do you use and how long does it takes to trigger
this race? I've tried to reproduce this with two threads, but not succeed
21 matches
Mail list logo
