Re: [PATCH] fix panic in jbd by adding locks

2007-08-23 Thread Josef Bacik
On Tue, Aug 21, 2007 at 01:45:02PM -0400, Josef Bacik wrote: > > > handle_t's are removed and such before processing the revoke lists, but > > > right > > > before we process the revoke lists we set the journals running > > > transaction to > > > NULL, which means we can continue on our merry way

Re: [PATCH] fix panic in jbd by adding locks

2007-08-21 Thread Josef Bacik
On Tue, Aug 21, 2007 at 06:48:15PM +0200, Jan Kara wrote: > On Tue 21-08-07 11:43:12, Josef Bacik wrote: > > On Mon, Aug 20, 2007 at 05:20:21PM +0200, Jan Kara wrote: > > > OK, thanks. So record probably points to an already freed memory which > > > has > > > been overwritten by garbage... > > >

Re: [PATCH] fix panic in jbd by adding locks

2007-08-21 Thread Jan Kara
On Tue 21-08-07 11:43:12, Josef Bacik wrote: > On Mon, Aug 20, 2007 at 05:20:21PM +0200, Jan Kara wrote: > > OK, thanks. So record probably points to an already freed memory which has > > been overwritten by garbage... > > > > > > Thanks for details. I'm still not convinced. What they essentia

Re: [PATCH] fix panic in jbd by adding locks

2007-08-21 Thread Josef Bacik
On Mon, Aug 20, 2007 at 05:20:21PM +0200, Jan Kara wrote: > OK, thanks. So record probably points to an already freed memory which has > been overwritten by garbage... > > > > Thanks for details. I'm still not convinced. What they essentially > > > write is that slab cache revoke_record_cache

Re: [PATCH] fix panic in jbd by adding locks

2007-08-20 Thread Jan Kara
On Thu 16-08-07 12:37:45, Josef Bacik wrote: > On Thu, Aug 16, 2007 at 06:08:35PM +0200, Jan Kara wrote: > > > > > It is possible to panic the box by a race condition that exists in the > > > > > journalling code where we do not take the j_revoke_lock when > > > > > traversing the > > > > > journa

Re: [PATCH] fix panic in jbd by adding locks

2007-08-16 Thread Josef Bacik
On Thu, Aug 16, 2007 at 06:08:35PM +0200, Jan Kara wrote: > Hello, > > > > > It is possible to panic the box by a race condition that exists in the > > > > journalling code where we do not take the j_revoke_lock when traversing > > > > the > > > > journal's revoked record list. This patch has

Re: [PATCH] fix panic in jbd by adding locks

2007-08-16 Thread Jan Kara
Hello, > > > It is possible to panic the box by a race condition that exists in the > > > journalling code where we do not take the j_revoke_lock when traversing > > > the > > > journal's revoked record list. This patch has been tested and we haven't > > > seen > > > the issue yet, its a rath

Re: [PATCH] fix panic in jbd by adding locks

2007-08-15 Thread Josef Bacik
On Wed, Aug 15, 2007 at 01:37:37PM +0200, Jan Kara wrote: > Hello, > > > It is possible to panic the box by a race condition that exists in the > > journalling code where we do not take the j_revoke_lock when traversing the > > journal's revoked record list. This patch has been tested and we ha

Re: [PATCH] fix panic in jbd by adding locks

2007-08-15 Thread Jan Kara
Hello, > It is possible to panic the box by a race condition that exists in the > journalling code where we do not take the j_revoke_lock when traversing the > journal's revoked record list. This patch has been tested and we haven't seen > the issue yet, its a rather straightforward and correct

[PATCH] fix panic in jbd by adding locks

2007-08-14 Thread Josef Bacik
Hello, It is possible to panic the box by a race condition that exists in the journalling code where we do not take the j_revoke_lock when traversing the journal's revoked record list. This patch has been tested and we haven't seen the issue yet, its a rather straightforward and correct (at least