Re: [PATCH 1/7] ext4: Introduce le32_t and le16_t

2007-09-25 Thread Dave Kleikamp
On Tue, 2007-09-25 at 21:15 +0530, Aneesh Kumar K.V wrote: > > Dave Kleikamp wrote: > > On Tue, 2007-09-25 at 14:33 +0530, Aneesh Kumar K.V wrote: > >> ext4 file system layout contain different split members > >> like bg_block_bitmap and bg_block_bitmap_hi. Introduce > >> data type le32_t and le1

Re: [PATCH 1/7] ext4: Introduce le32_t and le16_t

2007-09-25 Thread Aneesh Kumar K.V
Dave Kleikamp wrote: On Tue, 2007-09-25 at 14:33 +0530, Aneesh Kumar K.V wrote: ext4 file system layout contain different split members like bg_block_bitmap and bg_block_bitmap_hi. Introduce data type le32_t and le16_t to be used as the type of these split members. This prevents these members

Re: [PATCH 1/7] ext4: Introduce le32_t and le16_t

2007-09-25 Thread Dave Kleikamp
On Tue, 2007-09-25 at 14:33 +0530, Aneesh Kumar K.V wrote: > ext4 file system layout contain different split members > like bg_block_bitmap and bg_block_bitmap_hi. Introduce > data type le32_t and le16_t to be used as the type of > these split members. This prevents these members frome > being acc

Re: [PATCH 1/7] ext4: Introduce le32_t and le16_t

2007-09-25 Thread Aneesh Kumar K.V
Andreas Dilger wrote: On Sep 25, 2007 14:41 +0530, Aneesh Kumar K.V wrote: The patches are on top of patch queue. I haven't touched the uid and gid of ext4_inode. Do you think i should change that too ? You can add a Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]> to those patches. As I

Re: [PATCH 1/7] ext4: Introduce le32_t and le16_t

2007-09-25 Thread Andreas Dilger
On Sep 25, 2007 14:41 +0530, Aneesh Kumar K.V wrote: > The patches are on top of patch queue. I haven't touched > the uid and gid of ext4_inode. Do you think i should > change that too ? You can add a Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]> to those patches. As I suspected there were a

Re: [PATCH 1/7] ext4: Introduce le32_t and le16_t

2007-09-25 Thread Aneesh Kumar K.V
Andreas, The patches are on top of patch queue. I haven't touched the uid and gid of ext4_inode. Do you think i should change that too ? 7/7 is not the part of the series. But it is important. Should i send it as a separate patch for the 2.6.24 ? -aneesh - To unsubscribe from this list: send th

[PATCH 1/7] ext4: Introduce le32_t and le16_t

2007-09-25 Thread Aneesh Kumar K.V
ext4 file system layout contain different split members like bg_block_bitmap and bg_block_bitmap_hi. Introduce data type le32_t and le16_t to be used as the type of these split members. This prevents these members frome being accessed directly. Accesing them directly gives a compiler warning. This