Re: Ext2/3 block remapping tool

2007-05-01 Thread Theodore Tso
On Tue, May 01, 2007 at 12:52:49PM -0600, Andreas Dilger wrote: > I think "rm -r" does a LOT of this kind of operation, like: > > stat(.); stat(foo); chdir(foo); stat(.); unlink(*); chdir(..); stat(.) > > I think "find" does the same to avoid security problems with malicious > path manipulation.

Re: Ext2/3 block remapping tool

2007-05-01 Thread Andreas Dilger
On May 01, 2007 11:28 -0400, Theodore Tso wrote: > On Tue, May 01, 2007 at 12:01:42AM -0600, Andreas Dilger wrote: > > Except one other issue with online shrinking is that we need to move > > inodes on occasion and this poses a bunch of other problems over just > > remapping the data blocks. > >

Re: Ext2/3 block remapping tool

2007-05-01 Thread Theodore Tso
On Tue, May 01, 2007 at 12:01:42AM -0600, Andreas Dilger wrote: > Except one other issue with online shrinking is that we need to move > inodes on occasion and this poses a bunch of other problems over just > remapping the data blocks. Well, I did say "necessary", and not "sufficient". But yes, m

Re: Ext2/3 block remapping tool

2007-04-30 Thread Andreas Dilger
On Apr 30, 2007 08:09 -0400, Theodore Tso wrote: > On Fri, Apr 27, 2007 at 12:09:42PM -0600, Andreas Dilger wrote: > > I'd prefer that such functionality be integrated with Takashi's online > > defrag tool, since it needs virtually the same functionality. For that > > matter, this is also very si

Re: Ext2/3 block remapping tool

2007-04-30 Thread Jan Kara
On Mon 30-04-07 08:09:30, Theodore Tso wrote: > On Fri, Apr 27, 2007 at 12:09:42PM -0600, Andreas Dilger wrote: > > I'd prefer that such functionality be integrated with Takashi's online > > defrag tool, since it needs virtually the same functionality. For that > > matter, this is also very simila

Re: Ext2/3 block remapping tool

2007-04-30 Thread Theodore Tso
On Fri, Apr 27, 2007 at 12:09:42PM -0600, Andreas Dilger wrote: > I'd prefer that such functionality be integrated with Takashi's online > defrag tool, since it needs virtually the same functionality. For that > matter, this is also very similar to the block-mapped -> extents tool > from Aneesh.