Re: delalloc and reservation.

2007-10-29 Thread Aneesh Kumar K.V
Aneesh Kumar K.V wrote: Hi All, I looked at the delalloc and reservation differences that Valerie was observing. Below is my understanding. I am not sure whether the below will result in higher fragmentation that Eric Sandeen is observing. I guess it should not. Even though the reservation

Re: delalloc and reservation.

2007-10-29 Thread Aneesh Kumar K.V
Alex Tomas wrote: sorry, I don't quite understand how do you observe this with nomballoc thanks, Alex Aneesh Kumar K.V wrote: mballoc by default doesn't give the particular layout only if i force small size to use inode preallocation i am hitting the problem. ie to change the below line in

Re: delalloc and reservation.

2007-10-29 Thread Alex Tomas
ah, got it now. I think the solution would be to discard preallocated blocks once blocks for all dirty data are allocated and file is closed. In the previous version of delalloc I did this passing NOPREALLOC hint. something similar should be done in the newer one, I guess. thanks, Alex Aneesh Ku

Re: delalloc and reservation.

2007-10-29 Thread Aneesh Kumar K.V
Alex Tomas wrote: Hi, could you try the patch attached. it should fix the issue. the idea was to align requests in order to help raid5-like setups. but somewhere I lost one bit in mballoc: it should pre-allocate all crossed stripes, but it didn't. as for discard, lustre doesn't use open/close

Re: delalloc and reservation.

2007-10-29 Thread Alex Tomas
sorry, I don't quite understand how do you observe this with nomballoc thanks, Alex Aneesh Kumar K.V wrote: mballoc by default doesn't give the particular layout only if i force small size to use inode preallocation i am hitting the problem. ie to change the below line in ext4_mb_group_or_file

Re: delalloc and reservation.

2007-10-29 Thread Alex Tomas
r data, so discard-on-close makes zero sense in our case. I'm not very positive whether we need to drop preallocation on file close in case of delayed allocation as writeback can be started while file is open and finish after close(2). thanks, Alex Aneesh Kumar K.V wrote: Hi All, I looked at t

Re: delalloc and reservation

2007-10-29 Thread Aneesh Kumar K.V
I guess the list dropped this mail. Sending again. -aneesh --- Begin Message --- Aneesh Kumar K.V wrote: Hi All, I looked at the delalloc and reservation differences that Valerie was observing. Below is my understanding. I am not sure whether the below will result in higher fragmentation

delalloc and reservation.

2007-10-29 Thread Aneesh Kumar K.V
Hi All, I looked at the delalloc and reservation differences that Valerie was observing. Below is my understanding. I am not sure whether the below will result in higher fragmentation that Eric Sandeen is observing. I guess it should not. Even though the reservation gets discarded during the