Andreas Dilger wrote:
On Aug 03, 2007 00:02 +0530, Aneesh Kumar K.V wrote:
Andreas Dilger wrote:
Is this the mtime and UUID of the new filesystem or the old one? It
should be the UUID and mtime of the new filesystem, so that the
undo file can be verified against the current superblock
Jose R. Santos wrote:
From: Jose R. Santos <[EMAIL PROTECTED]>
e2fsck/super.c | 10 --
lib/ext2fs/check_desc.c | 10 --
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/e2fsck/super.c b/e2fsck/super.c
index 00a131c..8e58e5c 100644
--- a/e2fsck/supe
Jose R. Santos wrote:
From: Jose R. Santos <[EMAIL PROTECTED]>
Ne
+ case ALLOC_INODE_TABLES:
+ for (i=0, blk=new_blk; i < count; i++, blk++) {
I guess you can drop the blk update in the for() loop above.
+ retval = ext2fs_get_free_blocks(fs, start
When a new block bitmap is read from disk in read_block_bitmap()
there are a few bits that should ALWAYS be set. In particular, the
blocks given by ext4_blk_bitmap, ext4_inode_bitmap and ext4_inode_table.
Validate the block bitmap against these blocks.
Signed-off-by: Aneesh Kumar K.V <[EM
Dmitry Monakhov wrote:
->s_group_desc have to be zero filled because if sb_read() failed
we jump to following error path.
failed_mount2:
for (i = 0; i < db_count; i++)
brelse(sbi->s_group_desc[i]);<< Bad things may happen here
But the db_count is updated in the failu
Alex actually pointed me the new mballoc patches at
ftp://ftp.clusterfs.com/pub/people/alex/mballoc3
The series is the forward port of the same on top of
d4ac2477fad0f2680e84ec12e387ce67682c5c13 (v2.6.23-rc2)
I guess the mballoc3 patch at clusterfs.com is based on
a patched ext3(I guess it is e
---
fs/ext4/Makefile |2 +-
fs/ext4/balloc.c | 58 ++---
fs/ext4/extents.c | 44 +++---
fs/ext4/inode.c | 14 +-
fs/ext4/super.c | 18 ++
fs/ext4/xattr.
---
fs/ext4/balloc.c| 37 +++---
fs/ext4/extents.c |7 +--
fs/ext4/mballoc.c | 96 ++
include/linux/ext4_fs.h | 19 +
4 files changed, 74 insertions(+), 85 deletions(-)
diff --git a/fs/ext4/balloc.c b/fs
From: Alex Tomas <[EMAIL PROTECTED]>
ext4_ext_search_left
ext4_ext_search_right
---
fs/ext4/extents.c | 142 +++
include/linux/ext4_fs_extents.h |2 +
2 files changed, 144 insertions(+), 0 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext
ev_name, 0, flags,
superblock, block_size, undo_io_manager,
¤t_fs);
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
lib/ext2fs/Makefile.in |7 +-
lib/ext2fs/ext2_io.h |5 +
lib/ext2fs/undo_io.c | 574 +++
ll be named tune2fs-
If TUNE2FS_SCRATCH_DIR is not set /var/lib/e2fsprogs is used
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
misc/tune2fs.c | 535 +++-
1 files changed, 532 insertions(+), 3 deletions(-)
diff --git a/misc/tune2
This adds two test case for undoe2fs.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
tests/test_config |1 +
tests/u_undoe2fs_mke2fs/script | 31 +++
tests/u_undoe2fs_tune2fs/script | 31 +++
3 files c
The series is on top of f1f115a78f5ea599fc5f8815a741d43fedd5840d
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
undoe2fs can be used to replay the transaction saved
in the transaction file using undo I/O Manager
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
misc/Makefile.in | 10 ++-
misc/undoe2fs.c | 220 ++
2 files changed, 228 inse
With the new mke2fs changes the output of the
command differs if we run mke2fs on a device that
already have the file system. So erase the file system
before running mke2fs so that output remain as expected.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
tests/r_resize_inode/
which the tdb
file need to be created. The file will be named mke2fs-
If MKE2FS_SCRATCH_DIR is not set /var/lib/e2fsprogs is used
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
misc/mke2fs.c | 109 -
1 files changed, 108 inse
Aneesh Kumar K.V wrote:
Alex actually pointed me the new mballoc patches at
ftp://ftp.clusterfs.com/pub/people/alex/mballoc3
The series is the forward port of the same on top of
d4ac2477fad0f2680e84ec12e387ce67682c5c13 (v2.6.23-rc2)
I guess the mballoc3 patch at clusterfs.com is based on
a
Hi,
Can we get the below patches in patch queue.
http://www.radian.org/~kvaneesh/ext4/patch-series/ext-truncate-mutex.patch
http://www.radian.org/~kvaneesh/ext4/patch-series/ext3-4-migrate.patch
http://www.radian.org/~kvaneesh/ext4/patch-series/new-extent-function.patch
http://www.radian.org/~k
Hi Alex,
Attaching below is some of the questions and comments i had while looking at
mballoc code. Can you take a look at this. I will try to push a new patch which
contain
a) comments from the below review
b) uninitialzed group changes assuming the uninitialized group patches will go
before
Andreas Dilger wrote:
On Sep 07, 2007 14:24 +0200, Valerie Clement wrote:
running ffsb tests (large files creation) on my system with the latest
ext4 git patches against a 2.6.23-rc4 kernel, I've got very bad
performance results: the I/O throughput measured on an ext4 filesystem
is ten time
I have updated the mballoc patches. The same can be found at
http://www.radian.org/~kvaneesh/ext4/patch-series/
The series file is
# This series applies on GIT commit b07d68b5ca4d55a16fab223d63d5fb36f89ff42f
ext4-journal_chksum-2.6.20.patch
ext4-journal-chksum-review-fix.patch
ext4_uninit_b
Aneesh Kumar K.V wrote:
I have updated the mballoc patches. The same can be found at
http://www.radian.org/~kvaneesh/ext4/patch-series/
Test status:
Minor testing with KVM. I also didn't do a PPC build.
running fsstress on ppc64 give me
EXT4-fs: group 9: 16384 blocks in b
Attaching below patch that fix the sparse warning for ext4.
NOTE: yet to test the changes.
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 390b36d..a3ffa15 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2567,7 +2567,7 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode
Valerie,
Valerie Clement wrote:
Aneesh Kumar K.V wrote:
running fsstress on ppc64 give me
EXT4-fs: group 9: 16384 blocks in bitmap, 32254 in gd
EXT4-fs error (device sda7): ext4_mb_mark_diskspace_used: Allocating
block in system zone - block = 294915
EXT4-fs error (device sda7
I checked the logs today for the fsstress run i found this in my dmesg log. The
same stack trace is repeated for many times
uh! busy PA
Call Trace:
[c000efa72fc0] [c000fe30] .show_stack+0x6c/0x1a0 (unreliable)
[c000efa73060] [c01954a0]
.ext4_mb_discard_group_preallocati
Hi Alex,
Aneesh Kumar K.V wrote:
I checked the logs today for the fsstress run i found this in my dmesg
log. The
same stack trace is repeated for many times
uh! busy PA
Call Trace:
[c000efa72fc0] [c000fe30] .show_stack+0x6c/0x1a0 (unreliable)
[c000efa73060
Valerie Clement wrote:
Hi Avantika,
I ran some tests with the uninit_groups feature enabled and got error messages
when running e2fsck on my ext4 partition. e2fsck complains of an "invalid
unused inodes count" in some group descriptors.
These errors occur when checking groups which have only o
Also add generic_find_next_le_bit
This gets used by the ext4 multi block allocator patches.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
include/asm-generic/bitops/ext2-non-atomic.h |2 +
include/asm-generic/bitops/le.h |4 ++
include/asm-powerpc/bi
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c |6 --
include/linux/ext4_fs.h | 16
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index a4848e0..307e240 100644
--- a/fs/ext4/i
Cc: Avantika Mathur <[EMAIL PROTECTED]>
Cc: Mingming Cao <[EMAIL PROTECTED]>
Cc: Aneesh Kumar K.V <[EMAIL PROTECTED]>
Cc:
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/Kconfig
Balbir Singh wrote:
Aneesh,
The subject is a bit confusing, I presume you mean sparse warnings
yes. I will send an updated patch. The group descriptor bg_flags -> le16
conversion
should actually go with the uninitialized block group patch.
-aneesh.
-
To unsubscribe from this list: send
Balbir Singh wrote:
Aneesh Kumar K.V wrote:
Also add generic_find_next_le_bit
This gets used by the ext4 multi block allocator patches.
Looks like it's a straight forward on Little Endian Architectures.
I see something for powerpc, what about other architectures?
All includ
Hi all,
I was looking at the patch queue and see patches with different formats.
If we can standardize on what rest of the linux kernel follows it would
be nice.
First line should be
: A single line description of the patch.
This appear in the subject line of the mail that results from differe
Aneesh Kumar K.V wrote:
Hi all,
I was looking at the patch queue and see patches with different formats.
If we can standardize on what rest of the linux kernel follows it would
be nice.
I found this
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
-aneesh
-
To unsubscribe from
Convert bg_inode_bitmap and bg_inode_table to le32_t
This helps in finding BUGs due to direct partial access of
these split 64 bit values
Also fix one direct partial access
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/balloc.c|2 +-
fs/ext4/super.c
. This helps in catching some BUGS
due to direct partial access of these split fields.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/super.c |8
include/linux/ext4_fs.h |4 ++--
include/linux/ext4_fs_i.h |4
3 files changed, 10 insertions
Convert s_blocks_count_hi and s_blocks_count to le32_t
This helps in finding BUGs due to direct partial access of
these split 64 bit values
Also fix direct partial access in ext4 code
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/mballoc.c |4 ++--
fs/ext4/s
Convert s_r_blocks_count[_hi] s_free_blocks_count[_hi] to le32_t
This helps in finding BUGs due to direct partial access of
these split 64 bit values
Also fix direct partial access in ext4 code
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/super.c |2 +-
i
Convert ext4_extent.ee_start and ee_start_hi to le32_t and le16_t
This helps in finding BUGs due to direct partial access of
these split 48 bit values
Also fix direct partial access in ext4 code
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/extents.c
Convert ext4_extent_idx.ei_leaf and ei_leaf_hi to le32_t and le16_t
This helps in finding BUGs due to direct partial access of
these split 48 bit values
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/extents.c |8
fs/ext4/migrate.c
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/fsync.c |2 +-
fs/ext4/xattr.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index 2a167d7..8d50879 100644
--- a/fs/ext4/fsync.c
+++ b/fs/ext4/fsync.c
@@ -47,7
Andreas,
The patches are on top of patch queue. I haven't touched
the uid and gid of ext4_inode. Do you think i should
change that too ?
7/7 is not the part of the series. But it is important.
Should i send it as a separate patch for the 2.6.24 ?
-aneesh
-
To unsubscribe from this list: send th
Andreas Dilger wrote:
On Sep 25, 2007 14:41 +0530, Aneesh Kumar K.V wrote:
The patches are on top of patch queue. I haven't touched
the uid and gid of ext4_inode. Do you think i should
change that too ?
You can add a Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]>
to those pat
Jan Kara wrote:
-#define create_jbd_proc_entry() do {} while (0)
-#define remove_jbd_proc_entry() do {} while (0)
+static ctl_table fs_table[] = {
+ {
+.ctl_name = -1, /* Don't want it */
shouldn't this be CTL_UNNUMBERED ?
+.procname =
Dave Kleikamp wrote:
On Tue, 2007-09-25 at 14:33 +0530, Aneesh Kumar K.V wrote:
ext4 file system layout contain different split members
like bg_block_bitmap and bg_block_bitmap_hi. Introduce
data type le32_t and le16_t to be used as the type of
these split members. This prevents these
Convert s_blocks_count to s_blocks_count_lo
This helps in finding BUGs due to direct partial access of
these split 64 bit values
Also fix direct partial access in ext4 code
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/mballoc.c |4 ++--
fs/ext4/s
Convert bg_block_bitmap to bg_block_bitmap_lo
This helps in catching some BUGS due to direct
partial access of these split fields.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/super.c |6 +++---
include/linux/ext4_fs.h |2 +-
2 files changed, 4 insertions
Convert bg_inode_bitmap and bg_inode_table to bg_inode_bitmap_lo
and bg_inode_table_lo. This helps in finding BUGs due to
direct partial access of these split 64 bit values
Also fix one direct partial access
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/balloc.c
Convert s_r_blocks_count and s_free_blocks_count to
s_r_blocks_count_lo and s_free_blocks_count_lo
This helps in finding BUGs due to direct partial access of
these split 64 bit values
Also fix direct partial access in ext4 code
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
f
Convert ext4_extent.ee_start to ext4_extent.ee_start_lo
This helps in finding BUGs due to direct partial access of
these split 48 bit values
Also fix direct partial access in ext4 code
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/extents.c |8 +++---
Convert ext4_extent_idx.ei_leaf ext4_extent_idx.ei_leaf_lo
This helps in finding BUGs due to direct partial access of
these split 48 bit values.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/extents.c |4 ++--
fs/ext4/migrate.c
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/fsync.c |2 +-
fs/ext4/inode.c |2 +-
fs/ext4/xattr.c |4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index 2a167d7..8d50879 100644
--- a/fs/ext4/fsync.c
++
Andrew Morton wrote:
On Tue, 11 Sep 2007 13:59:26 +0530 "Aneesh Kumar K.V" <[EMAIL PROTECTED]> wrote:
I have updated the mballoc patches.
Has anyone reviewed this stuff? I don't see much evidence of it here?
Just a quick scan shows up heavy over-inlining, many
m
Hi
This is the changes with which i am going to update the mballoc core patch.
There is a new FIXME in here which i would like others to look at.
Also the commit message is updated to explain the mballoc
approach.
Mingming,
I have placed the new patch at
http://www.radian.org/~kvaneesh/ext4
Theodore Ts'o wrote:
Here's an initial code review of the mballoc-core.patch. As far as I
can tell, the patch sent by Aneesh doesn't address any of these.
Aneesh, assuming that you'll be fixing these, could you please combine
your last set of fixes with fixes to address these, and send out an
Mingming Cao wrote:
BUG: unable to handle kernel paging request at virtual address 104b
printing eip:
c0195bd3
*pde =
Oops: [#1]
PREEMPT SMP
Modules linked in: vboxdrv binfmt_misc fuse coretemp hwmon gspca videodev v4l2_common v4l1_compat iwl3945 mac80211 tifm_7xx1 tifm
Valerie Clement wrote:
Avantika Mathur wrote:
Multiple Block Allocation:
- Main outstanding issue is still need for better documentation of the
code.
- Aneesh has marked the places that need explanation with fixme, and
Alex will be adding the needed comments. If this gets done quickly,
we
Andreas Dilger wrote:
On Oct 02, 2007 11:24 +0200, Valerie Clement wrote:
Currently, the mballoc feature is not compatible with the uninit_groups
feature. I have just tried a simple test which failed. Isn't this a problem?
I thought Avantika posted the incremental patch to ext4 mballoc to w
We should actually get this error
dd: writing to `myfile5': No space left on device
[EMAIL PROTECTED]:~# mount /dev/hdc -t ext4dev -o delalloc,data=writeback /ext4
[EMAIL PROTECTED]:/ext4# df -h .
FilesystemSize Used Avail Use% Mounted on
/dev/hdc 49M 46M 94K
Hi,
This contain fixes for making mballoc work with uninitialized block group.
The patches can be downloaded from
http://www.radian.org/~kvaneesh/ext4/oct-3-2007/
The diff is attached below to find out what changed.
Mingming,
Can you replace the patch in the patch queue with the above two
Andreas Dilger wrote:
On Oct 03, 2007 15:30 +0530, Aneesh Kumar K.V wrote:
+ if (block_group == sbi->s_gdb_count - 1) {
+ /*
+* Even though mke2fs always initialize first and last group
+ * if some other tool enabled the EXT4_BG_BLOCK_UNINIT we
n
Aneesh Kumar K.V wrote:
Andreas Dilger wrote:
On Oct 03, 2007 15:30 +0530, Aneesh Kumar K.V wrote:
+if (block_group == sbi->s_gdb_count - 1) {
+/*
+ * Even though mke2fs always initialize first and last group
+ * if some other tool enabled
Aneesh Kumar K.V wrote:
115908 | fsstress--2.6.23-rc9--ppc64 | f | gekko-lp4 |
http://abat.linux.ibm.com/abat-repo/logs/[EMAIL PROTECTED]
Same here
EXT4-fs: mballoc enabled
[ cut here ]
kernel BUG at fs/ext4/mballoc.c:1607!
cpu 0x0: Vector: 700 (Program
Valerie Clement wrote:
Aneesh Kumar K.V wrote:
+if (block_group == sbi->s_gdb_count - 1) {
+/*
+ * Even though mke2fs always initialize first and last group
+ * if some other tool enabled the EXT4_BG_BLOCK_UNINIT we need
+ * to make sure we calculate
have a block number 2**32 -1 which
will result in overflow if the block number is represented by
signed long. This patch convert all the block number to type
ext4_inoblk_t which is typedef to __u32
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/extents.c
Hi,
I am looking at ext4_max_size and was confused how the
number upper_limit = 0x1ff7fffd000LL is arrived.
The comment says the value is arrived looking at 4K.
So i tried the below program.
main()
{
unsigned long long upper_limit, meta_blocks;
int bits = 12;
/* total
This is what i have now . But still i am not able to map the magic number
#include
main()
{
unsigned long long upper_limit;
int meta_blocks;
int bits = 12;
/* total blocks in 512 bytes */
upper_limit = (1LL << 32) -1;
/* total blocks in file syste
I have updated the patch queue at
http://www.radian.org/~kvaneesh/ext4/patch-series/
http://www.radian.org/~kvaneesh/ext4/patch-series/ext4-patch-queue.tar
Changes:
a) Add large-file-blocktype.patch large-file.patch patch.
b) Add the stable-boundary-patch with dummy change
c) Add stable-bound
Mingming Cao wrote:
On Wed, 2007-10-10 at 17:35 +0530, Aneesh Kumar K.V wrote:
I have updated the patch queue at
http://www.radian.org/~kvaneesh/ext4/patch-series/
http://www.radian.org/~kvaneesh/ext4/patch-series/ext4-patch-queue.tar
Changes:
a) Add large-file-blocktype.patch large
I am hitting this with the below config
mke2fs -j -I 256 -O lazy_bg $dev
mount -t ext4dev $dev /mnt/tmp -o "extents,mballoc"
and running fsstress on /mnt/tmp/
jbd2_journal_bmap: journal block not found at offset 31780 on sda7
Aborting journal on device sda7.
ext4_abort called.
EXT4-fs e
nly if the incompat feature flag
EXT4_FEATURE_INCOMPAT_LARGE_BLOCK is set in super block
and the kernel is built with CONFIG_LSF.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 21 -
fs/ext4/super.c
Andreas Dilger wrote:
On Oct 11, 2007 10:41 +0530, Aneesh Kumar K.V wrote:
This patch converts ext4_inode i_blocks to represent total
blocks occupied by the inode in file system block size.
Earlier the variable used to represent this in 512 byte
block size. This actually limited the total
Andreas Dilger wrote:
On Oct 10, 2007 22:07 +0530, Aneesh Kumar K.V wrote:
I am hitting this with the below config
mke2fs -j -I 256 -O lazy_bg $dev
Note that "-O lazy_bg" has nothing really to do with the uninit_groups
feature. Also, if you don't have the CFS e2fspr
in e2fsprogs we have
union {
struct {
__u16 l_i_blocks_hi;
__u16 i_pad1;
__u16 l_i_uid_high; /* these 2 fields*/
__u16 l_i_gid_high; /* were reserved2[0] */
The max file size for ext2 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext2/super.c | 32
1 files changed, 28 inse
The max file size for ext3 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext3/super.c | 32
1 files changed, 28 inse
Right now we do this in ext4_do_update_inode
if (ei->i_disksize > 0x7fffULL) {
.
.
EXT4_SET_RO_COMPAT_FEATURE(sb, EXT4_FEATURE_RO_COMPAT_LARGE_FILE);
That is if i_disksize is greater that 2**31 -1 we set the flag
But in ext4_inode the size of i_size is 32 bits
__le32 i_size;
Andreas Dilger wrote:
On Oct 11, 2007 20:20 +0530, Aneesh Kumar K.V wrote:
+ /* indirect blocks */
+ meta_blocks = 1;
+ /* double indirect blocks */
+ meta_blocks += 1 + (1LL << (bits-2));
+ /* tripple indirect blocks */
+ meta_blocks += 1 + (1LL &l
use the __le16 l_i_reserved1 field of the linux2
struct of ext4_inode to represet the higher 16
bits for i_blocks. With this change max_file size becomes
(2**48 -1 )* 512 bytes.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c
CONFIG_LSF disabled.
Super block flag EXT4_FEATURE_RO_COMPAT_HUGE_FILE
inode flag EXT4_HUGE_FILE_FL
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 41 +++--
fs/ext4/super.c |9 ++---
include/linux/ext4_fs.h
Andreas Dilger wrote:
On Oct 12, 2007 10:06 +0530, Aneesh Kumar K.V wrote:
use the __le16 l_i_reserved1 field of the linux2
struct of ext4_inode to represet the higher 16
bits for i_blocks. With this change max_file size becomes
(2**48 -1 )* 512 bytes.
+static int ext4_inode_blocks_set
Andreas Dilger wrote:
On Oct 12, 2007 10:06 +0530, Aneesh Kumar K.V wrote:
We add a RO_COMPAT feature to the super
block to indicate that some of the inode have i_blocks
represented as file system block size units. Super block
with this feature set cannot be mounted read write on a kernel
Hi,
Can we get this patches added to patch queue.
The set 5 patches replace the large-file.patch
in the patch queue.
The last two patches in the series can be dropped
when akpm merges them directly. Till then i think
patch queue can act as a placeholder.
-aneesh
-
To unsubscribe from this list
a) Introduce ext4_update_*_feature(sb,
b) rename i_file_acl to i_file_acl_lo
c) convert some function to static
d) Fix sparse warnings
---
fs/ext4/extents.c |6 ++--
fs/ext4/ialloc.c| 13 +--
fs/ext4/inode.c | 18 +---
fs/ext4/super.c | 5
. Super block with this feature set cannot
be mounted read write on a kernel with CONFIG_LSF disabled.
Super block flag EXT4_FEATURE_RO_COMPAT_HUGE_FILE
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 58 ++-
fs/ext4/s
whose i_blocks cannot be represnted as 512 byte units in a
48 bit variable.
inode flag EXT4_HUGE_FILE_FL
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 34 ++
fs/ext4/super.c |9 ++---
include/linux/ext4_fs.h
The max file size for ext2 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext2/super.c | 32
1 files changed, 28 inse
The max file size for ext3 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext3/super.c | 32
1 files changed, 28 inse
Theodore Ts'o wrote:
* ak/undo-mgr (Mon Aug 13 15:56:26 2007 +0530) 9 commits
- e2fsprogs: Add test case for undoe2fs
- e2fsprogs: Fix the resize inode test case
- e2fsprogs: Support for large inode migration.
- e2fsprogs: Make mke2fs use undo I/O manager.
- e2fsprogs: Add undoe2fs
- e2f
I am wondering whether we can use i_size_high without looking at
file mode (why restrict only to regular files ? )
-aneesh
From a5796eb4af173d2a0a9b8f0f80a8af12bf3e2695 Mon Sep 17 00:00:00 2001
From: Aneesh Kumar K.V <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 12:25:18 +0530
Subject:
Introduce ext4_update_*_feature and use them instead
of opencoding.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/ialloc.c| 11 +++-
fs/ext4/super.c | 60 +++
include/linux/ext4_fs.h |6
3
Fix sparse warnings.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/extents.c |6 +++---
fs/ext4/inode.c | 14 --
include/linux/ext4_fs.h |2 ++
3 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/fs/ext4/extents.c b/f
rename i_file_acl to i_file_acl_lo
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c |4 ++--
include/linux/ext4_fs.h |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 8908ab3..ef073df 100644
rename ext4_inode.i_dir_acl to i_size_high
drop ext4_inode_info.i_dir_acl as it is not used
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/ialloc.c |1 -
fs/ext4/inode.c | 55 ++---
include/linux/ext4_fs.h
whose i_blocks cannot be represnted as 512 byte units in a
48 bit variable.
inode flag EXT4_HUGE_FILE_FL
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 34 ++
fs/ext4/super.c |9 ++---
include/linux/ext4_fs.h
. Super block with this feature set cannot
be mounted read write on a kernel with CONFIG_LSF disabled.
Super block flag EXT4_FEATURE_RO_COMPAT_HUGE_FILE
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext4/inode.c | 58 ++-
fs/ext4/s
Hi Mingming,
The patch queue updated on top of d85714d81cc0408daddb68c10f7fd69eafe7c213
The commit d85714d81cc0408daddb68c10f7fd69eafe7c213 contain changes that
Andrew pushed to linus which had conflicts with patches in the patch queue.
The update fixes them.
Changes
a) ext4_grpnum_t.patch g
y the Coverity checker.
From 5c04ec0d8e43ef582cec2856f262b575376233ba Mon Sep 17 00:00:00 2001
From: Aneesh Kumar K.V <[EMAIL PROTECTED]>
Date: Fri, 19 Oct 2007 20:10:17 +0530
Subject: [PATCH] ext4: Return after ext4_error in case of failures
This fix some instances where we were continuing
after ma
The max file size for ext2 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext2/super.c | 32
1 files changed, 28 inse
The max file size for ext3 file system is now calculated
with hardcoded 4K block size. The patch fixes it to be
calculated with the right block size.
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]>
---
fs/ext3/super.c | 32
1 files changed, 28 inse
101 - 200 of 349 matches
Mail list logo