On May 22, 2007 15:45 -0400, Theodore Tso wrote:
> On Mon, May 14, 2007 at 05:03:11PM -0600, Andreas Dilger wrote:
> > A quick patch to sanity check the inode ratio vs the inode size. In some
> > cases Lustre users have tried specifying an inode size of 4096 bytes, while
>
sks to avoid always having a single
disk busy with bitmap updates.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo inf
what the mapping turns out to be - the goal is to place
inodes with a similar hash into nearby inodes, and this heuristic works
relatively well for that. Once the given leaf block's inode range is full
then new inodes can be allocated from a new window as it was done for the
newly-created d
xtended attribute like user.crtime that returns a
struct timespec or similar.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTE
uncate the ns part away.
Now, this might not be critical for some users, but for others it can be.
Since this functionality is all here there isn't any reason to move it to
a separate patch. The same fields will be important for the inode version
also.
Cheers, Andreas
--
Andreas Dilger
Princ
"\tresize=\n\n"));
+ free(buf);
exit(1);
}
+
+ free(buf);
}
static __u32 ok_features[3] = {
=
Cheers, Andreas
--
Andreas Dilger
Principal Software Eng
n then knfsd can just access it directly.
I don't think there is any API to access it from userspace. One option
is to add a virtual EA like user.inode_version and have the kernel fill
this in from i_version.
Lustre will manipulate the ei->i_fs_version directly.
Cheers, Andreas
--
And
e) {
> ret_sb = superblock;
> if (ctx) {
> ctx->superblock = superblock;
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "
ile && iter->file->upd_serial !=
iter->file_serial)) {
iter->flags &= ~PROFILE_ITER_FINAL_SEEN;
skip_num = iter->num;
iter->node = 0;
===
Cheers, Andr
orary
> inode.
>
> "ext4_free_blocks Freeing blocks not in datazone "
This shouldn't happen regardless of whether you are doing defrag or not,
since it will cause the filesystem to go read-only.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
T
sing it yet. Can you please post
what the end of ext2_super_block looks like (whether you decide to reorder
the fields or not).
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
specify lots
> of annoying options) would be most welcome
For now we will specify this via mke2fs or tune2fs for existing filesystems.
The XFS folks mentioned they have a library to extract this info for linux
devices (e.g. DM, MD, etc), but of course that still won't work for e.g.
ext
ill
be an optional feature, mostly for use on SANs, iSCSI, etc where a disk
might be accessed by multiple nodes at the same time. That means there
will not be any impact for desktop users waiting 10s for each of their
filesystems to mount.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
e local system (e.g. plug the elevator output, I don't think that
there is anything that could be done about IO already submitted to the
device), but the function I thought did this (set_device_rdonly()) is
only checked at mount time and is useless.
Cheers, Andreas
--
Andreas Dilger
Principal S
JBD2_FEATURE_INCOMPAT_64BIT)) {
printk(KERN_ERR "ext4: Failed to set 64-bit journal feature\n");
goto failed_mount4;
}
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from thi
s fine, but Linux CodingStyle would have "if (" and have ")) {".
Don't bother reposting, but whoever adds this to the ext4 git tree and/or
sending it to Andrew should make the fix.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, I
]>
> Signed-off-by: Jose R. Santos <[EMAIL PROTECTED]>
You can add Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]> also.
> Index: linux-2.6.22-rc3/fs/ext4/super.c
> ===
> --- linux-2.6.22-rc3.orig/fs/e
eas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
t;OCFSV2", probe_ocfs2 },
>{ "ocfs2", 4, 0, 6, "OCFSV2", probe_ocfs2 },
>{ "ocfs2", 8, 0, 6, "OCFSV2", probe_ocfs2 },
> + { "crypt_LUKS", 0, 0, 6, "LUKS\xba\xbe
quot; it, repeatedly running fsck always asks that
> question.
This is definitely a bug...
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
his feature.
The one noticable difference is that this patch is missing the check/fix
for fixing an group with BLOCK_UNINIT as the last group in the fs.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "u
;debugfs" filesystem (not to be confused with
the e2fsprogs 'debugfs' command)?
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL P
ead of the ext4_get_actual_len() helper to mask off the unwritten
extent flag (e.g. delalloc_extents*.patch). I wonder if we should change
the ee_len type so that it isn't easy to access it directly (e.g. put it
inside a named union) so this mistake is visible more easily in the future.
Cheers, And
option.
Did you run the "make check" tests? We've found these invaluable for
catching regressions. Ideally there would also be some test cases
for this support using "lazy_bg", a script to generate the filesystem,
and conditional upon being able to create sparse file
> gdp->bg_block_bitmap = ext2fs_swab32(gdp->bg_block_bitmap);
> gdp->bg_inode_bitmap = ext2fs_swab32(gdp->bg_inode_bitmap);
This does not swap the new fields in the group descriptor. Swabbing the
ext4_group_desc fields should also be conditional upon INCOMPAT_64BI
should actually use s_desc_size and not "sizeof(struct ext4_group_desc)",
as we may want to increase the size of s_desc_size for some other reason in
the future.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list:
uldn't really care
whether it is migrating from/to a block-mapped or extent-mapped file.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [
((s)->s_r_blocks_count)
> +#define EXT2_FREE_BLOCKS_COUNT(s)((s)->s_free_blocks_count)
I don't think any of this (above or in most/all of the rest of this patch)
should be conditional upon #ifdef _EXT4FS_. Instead, it should depend on
INCOMPAT_64BIT being set in the superblock. I d
wab32(gdp->bg_block_bitmap_hi);
> + gdp->bg_inode_bitmap_hi = ext2fs_swab32(gdp->bg_inode_bitmap_hi);
> + gdp->bg_inode_table_hi = ext2fs_swab32(gdp->bg_inode_table_hi);
> +#endif
Same comment.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster F
has fixed this problem, but not all of
our customers/partners are using the latest lustre or e2fsprogs, or
have necessarily run e2fsck on their filesystems..
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
s. If we are in
there, it probably makes sense to rename this "i_file_ea" and "i_file_ea_hi"?
And also replace i_dir_acl with i_size_hi?
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line &q
not. In
some (primitive) implementations it might no longer be possible to
distinguish between unwritten extents and zero-filled blocks, though
at this point DEALLOC of zero-filled blocks might not be harmful either.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems,
node_dirty(handle, inode);
>mutex_unlock(&inode->i_mutex);
>return len - towrite;
The change from "i_version++" to "i_version = 1" in ext4_update_quota()
is confusing. Why was this change made? If there is a good reason why
the inode version stays
On Jun 14, 2007 22:04 +1000, David Chinner wrote:
> On Thu, Jun 14, 2007 at 03:14:58AM -0600, Andreas Dilger wrote:
> > > B FA_DEALLOCATE
> > > removes the underlying disk space with the given range. The disk space
> > > shall be removed regardless of it'
unsigned long i_version;
> > + uint64_ti_version;
> > loff_t i_size;
> > #ifdef __NEED_I_SIZE_ORDERED
> > seqcount_t i_size_seqcount;
> >
> >
>
>
> I think u64 is better here.
ecause
> of performance concern?
This is the "disable i_version updates for Lustre" option we previously
agreed on in the concall.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscri
k problems (e.g. process 1 holds lock, waits for handle;
process 2 holds transaction open waiting for lock). pdflush might be one
of the "process 1" kind of tasks, and some other process is holding the
transaction open preventing it from completing.
Cheers, Andreas
--
Andreas Dilger
P
ournal to be aborted once the previous
transaction is committed. Doing kernel recovery of this filesystem should
hit the bug if your theory is right.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe lin
inode, xtime))
> \
> - (einode)->xtime.tv_sec = le32_to_cpu((raw_inode)->xtime);
> \
> + (einode)->xtime.tv_sec =
> \
> + (signed)le32_to_cpu((raw_inode)->xtime)
On Jun 18, 2007 22:53 -0500, John Marconi wrote:
> Andreas Dilger wrote:
> >Two tips for debugging this kind of issue:
> >- you need to have detailed stack traces (e.g. sysrq-t) of all the
> > interesting processes
> >
> >- if a process is stuck inside a lar
x0040
This is the wrong feature number. It should be 0x0010 as in the original
patch, and as reserved in the upstream e2fsprogs. The confusion is because
you added this to the "FEATURE_COMPAT" section instead of the
FEATURE_RO_COMPAT section of the headers.
I've asked Girish to send
reading from an uninitialized extent or hole. When allocating to this
extent we treat the ee_start == 0 extent similar to an uninitialized
extent, in that it needs to be split and can't merge with neighbour extents.
On May 14, 2007 17:08 -0600, Andreas Dilger wrote:
> For snapshot fil
n an error up to
the filesystem, so it can call ext4_error() at startup. For e2fsck
(which normally does journal replay & recovery) it can do a full
filesystem check at this point.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from
On Jun 19, 2007 13:10 +0400, Alex Tomas wrote:
> Andreas Dilger wrote:
> >I _think_ Alex is asking "what happens if during a transaction undergoing
> >checkpoint of blocks to filesystem (not the last one in the journal) is
> >interrupted by a crash and upon restart
PC batching information and data checksums.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
it make sense
to assign 0 reservation to offline CPUs until they come back? In the first
loop, if it is "for_each_possible_cpu()" it would drop reservations from
offline CPUs, and then the bottom one is "for_each_online_cpu()".
Cheers, Andreas
--
Andreas Dilger
Principal Softw
would break.
There shouldn't be a problem with increasing EXT{2,3,4}_MAX_BLOCK_SIZE to
32kB (AFAIK), but I haven't looked into this in a while.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "u
past 64kB blocksize in any case.
> > There shouldn't be a problem with increasing EXT{2,3,4}_MAX_BLOCK_SIZE to
> > 32kB (AFAIK), but I haven't looked into this in a while.
>
> I'd love to see such a patch. That is also useful for arches that have
> PAGE_SIZE &
check "i_size < sizeof(i_block)" or similar, which
has always been true for fast symlinks, for every kernel that I have ever
seen.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscr
On Jun 21, 2007 11:54 +0200, Jan Kara wrote:
> On Thu 21-06-07 03:33:43, Andreas Dilger wrote:
> > > + if (LINUX_S_ISCHR(inode.i_mode) || LINUX_S_ISBLK(inode.i_mode) ||
> > > + (LINUX_S_ISLNK(inode.i_mode) &&
> > > + ext2fs_inode_data_blocks(fs,
;s_es->s_desc_size)
> + - offset);
Minor nit - please put '-' at the end of the previous line, and align
"offset" with '(sbi-> ...'.
Also, we're missing the signoff:
Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]>
Signed-off-by: Girish Shilamk
size > EXT2_MIN_DESC_SIZE)" I think, even though
the two are (currently) equivalent.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
(s) - EXT2_DESC_SIZE_BITS(s))).
Having the s_desc_size stored as an integer shift (128 << s_desc_bits) instead
of a number of bytes makes a lot of sense (forces power-of-two size, makes
math easy), but it might be too much of a format change at this point?
Cheers, Andreas
--
Andreas Dilger
Princip
s_*bitmap_64() internally (though there are a large
number of callsites).
The other issue is that applications which are using the old API but are
actually using these functions against a 64-bit filesystem should fail
gracefully. For many apps this might never be a problem, since they only
deal with high-level library/filesystem operations.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
e2fs.h"
> +#include "e2p/e2p.h"
> #include
>
> #ifdef __linux__ /* Kludge for debugging */
This should go in "resize2fs.h", like all of the other e2fsprogs-specific
headers, and probably should be in a separate patch so Ted can incorp
sc *) (fs->group_desc)
> + j;
> + t = (struct ext4_group_desc *) (group_shadow) +
> j;
> + *t = *s;
> + } else {
> + *(group_shadow +j) = *(fs->group_desc + j);
> + t = (struct ext4_group_desc *) (group_shadow
> +j);
> + }
> + ext2fs_swap_group_desc(fs->super, t);
Same as above.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
gt; + } while(0)
Same as above.
> @@ -1604,6 +1604,10 @@ static int e2fsck_ext_block_verify(struc
> e2fsck_t ctx = p->ctx;
> struct problem_context *pctx = p->pctx;
> int i, problem = 0;
> + int flag_64bit;
> +
> + flag_64bit = p->ctx->fs-&
INLINE_ blk_t ext2fs_group_first_block(ext2_filsys fs, dgrp_t group)
> {
> return fs->super->s_first_data_block +
> + (group * (blk_t) EXT2_BLOCKS_PER_GROUP(fs->super));
The (blk_t) cast should be handled inside the macro to avoid subtle errors.
I suspect it already
goto failed_sbi;
> }
We need a check in ext2 (like ext3/ext4) to ensure that blocksize <
EXT2_MAX_BLOCK_SIZE. It could be increased to 32768 without danger
I think, only the directory problem prevents it from working with 65536.
Cheers, Andreas
--
Andreas
d2 osd2.masix2.m_i_reserved2
On an unrelated note - does MASIX even exist anymore? I think it was only
a very experimental OS that Rémy Card worked on, and the home page doesn't
even exist anymore.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, I
hen it should be 0?
I suppose it is possible for the patch to just ignore the on-disk data if
checksums are not enabled, but we didn't have any such problems in the past...
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this l
interested to work on this please let us know.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ot
sure if this makes sense at all.
> On Mon, Jun 25, 2007 at 07:15:00PM +0530, Amit K. Arora wrote:
> > Implement new flags and values for mode argument.
> >
> > This patch implements the new flags and values for the "mode" argument
> > of the fallocate syste
* default is keep existing data */
so that it doesn't imply this is only for DEALLOC.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAI
anging ctime, if
that is required even though the file is not visibly changing. Maybe the
ctime update should be implicit if the size or mtime are changing?
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line &qu
descriptors soon.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Jun 26, 2007 16:02 +0530, Amit K. Arora wrote:
> On Mon, Jun 25, 2007 at 03:46:26PM -0600, Andreas Dilger wrote:
> > Can you clarify - what is the current behaviour when ENOSPC (or some other
> > error) is hit? Does it keep the current fallocate() or does it free it?
>
>
On Jun 26, 2007 16:15 +0530, Amit K. Arora wrote:
> On Mon, Jun 25, 2007 at 03:52:39PM -0600, Andreas Dilger wrote:
> > In XFS one of the (many) ALLOC modes is to zero existing data on allocate.
> > For ext4 all this would mean is calling ext4_ext_mark_uninitialized() on
> &
hanism we now have - we can encode the
various different behaviours in any way we want and leave it to the
caller.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
should succeed in most near-OOM conditions).
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
roup=list_bg_no[i];
Space around '='.
> @@ -813,8 +1012,13 @@ int ext4_group_add(struct super_block *s
> if (reserved_gdb && ext4_bg_num_gdb(sb, input->group) &&
> (err = reserve_backup_gdb(handle, inode, input)))
> goto exit_j
incremental over the previous set).
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ext4 to not use any
journaling (i.e. make all of the ext4_journal*() wrappers be
no-ops). That way they would get extents, mballoc and other speedups.
That said, what is the reason for not using ext3? Presumably performance
(which is greatly improved in ext4) or is there something else?
Cheer
On Jun 29, 2007 18:26 -0400, Mike Waychison wrote:
> Andreas Dilger wrote:
> >I don't think ext2 is safe for > 8TB filesystems anyways, so this
> >isn't a huge loss.
>
> This is reference to the idea of overloading the high-bit and not
> related to the >P
count_hi; /* Directories count MSB */
__u16 bg_pad;
__u32 bg_reserved2[3];
};
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
more robust), but will be
considerably harder to do later, and something I wish someone could work
on is to add "whiteout" support for extents to allow extents in a file
to explicitly encode a hole in the file to "hide" the contents in a
backing/snapshot inode that was truncate
(default keep prealloc) */
The other possible flags that were proposed, to avoid confusing backup and
HSM applications when preallocated space is added or removed from a file
(you don't want a backup app to re-backup a file that was migrated via HSM):
FA_FL_NO_MTIME 0x10 /* keep same mt
onder if there are benefits in terms of
> locality to having the bitmaps closer to its blocks vs having them far
> away like in xMETA_BG.
Having the bitmaps together will fix this independent of "BIG_BG".
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Syste
On Jul 02, 2007 09:39 -0500, Jose R. Santos wrote:
> On Sun, 1 Jul 2007 12:31:53 -0400
> Andreas Dilger <[EMAIL PROTECTED]> wrote:
> > This turns out not to be true, and in fact we need to change the
> > unwritten extents patch a tiny bit. The reason is that we have
do we set the qutoa file inodes version to 1
> during write ?
Hmm, I thought we had previously fixed this?
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
t systems
we only ever had a 32-bit in-memory version anyway so using only the
low 32 bits of i_version in f_version is no more racy than in the past.
For 64-bit systems using the full on-disk i_version is possible.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Syste
be ordered between all inodes, is set by Lustre to be a
transaction number). Instead of trying to incorporate this unused code
into ext4 we just turn off the ext4 version code and let Lustre control
this directly. It may even be that NFSv4 will need to control the version
numbers itself...
Ch
t;Missed this one.
> >Thanks. Will update ext4 patch queue tonight with this fix.
>
> IIRC in the conference call it was decided to not to apply this patch.
> Andreas may be able to update better.
I wasn't on the most recent concall, and I've forgotten the details
;f_namelen = EXT3_NAME_LEN;
fsid = le64_to_cpup((void *)es->s_uuid) ^
le64_to_cpup((void *)es->s_uuid + sizeof(u64));
===
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ard
way to do this. If you have any questions about who wrote a particular
CFS patch I can tell you.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to
least we are removing 1/2 of the overhead for ext2.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Jul 05, 2007 19:08 -0700, Badari Pulavarty wrote:
> On Thu, 2007-07-05 at 15:06 -0600, Andreas Dilger wrote:
> > On Jul 05, 2007 11:11 -0700, Badari Pulavarty wrote:
> > > @@ -1131,17 +1134,22 @@ static int ext2_statfs (struct dentry *
> > > buf->f_bfr
t; instead of the dangerous "continue".
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
having it stored into the superblock in s_flags is probably a good
idea. Kalpak, do you think you could get a patch that adds e.g.
EXT4_FLAGS_NO_INODE_VERSION (like EXT4_FLAGS_SIGNED_HASH in e2fsprogs).
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To
s are set */
+ bitmap_blk = ext4_inode_table(sb, desc);
+ for (i = 0; i < EXT4_SB(sb)->s_itb_per_group; i++, bitmap_blk++)
+ if (!ext4_test_bit(bitmap_blk - grp_first_blk, bh->b_data)){
+ msg = "Inode table block not marked in use";
+
block bitmap against these blocks.
Ah, our emails passed each other... Mine has the added change that it
checks all of the itable bits, but otherwise it seems we made the same
cleanups.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from thi
>rec_len += dirent->rec_len;
> ^^^
I think Kalpak was agreeing with you...
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to
eople have to think about this when using the #define.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Jul 10, 2007 23:25 +0530, Amit K. Arora wrote:
> On Tue, Jul 10, 2007 at 11:09:39AM -0600, Andreas Dilger wrote:
> > It might even make sense to change the other #define to be called
> > EXT_INIT_MAX_LEN so people have to think about this when using the #define.
>
> Done
e U. Wisconsin folks tested this in one of their
papers and showed some noticable improvements. That isn't exactly
related, but it is a relatively simple tweak to mke2fs/tune2fs to give
it an allocation goal of group_desc[s_groups_count / 2].bg_inode_table
(to put it past inode table in middle gro
exposes us to potential malicious corruption in some cases if
users create "inode looking" data files (e.g. suid root inodes) on a full
filesystem and e2fsck is convinced to treat them as inodes.
We might instead limit this space to directories and indirect/index
blocks, which wouldn&#
each name, since
an inode can have many names and would appear in multiple hash buckets.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
.info/?l=linux-ext4&m=115091699809181&w=2
>
> Andreas or Kalpak, is changelog from the original patch is accurate to
> apply here?
Mostly, yes, but the name of the feature flag has changed.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
topic, but they aren't attached to
the patch. s_want_extra_isize is just an override for sizeof(ext4_inode)
in case the sysadmin wants to reserve more fields in new inodes. There is
also s_min_extra_isize which is what the kernel and e2fsck guarantee that
will be available in all in-use inod
internal-only changes which need ext4_mark_inode_dirty().
We had a patch to disable ext4 inode versioning by a flag the superblock,
but we dropped it at the last minute because it needed some updates and
we didn't want to wait on that for submitting these changes upstream.
Cheers, Andreas
--
And
201 - 300 of 534 matches
Mail list logo
