Re: [f2fs-dev] [PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-05-26 Thread Namjae Jeon
2013/5/27, Jaegeuk Kim : > Hi Namjae, Hi Jaegeuk. First, Thanks for your interest. > > This is an interesting functionality. > Could you describe why and when we need to do this? > What are pros and cons? > How can we use this? As the default size of the F2FS parameter can vary as per the storage

Re: [f2fs-dev] [GIT PULL v2] f2fs updates for v3.10

2013-05-26 Thread Jaegeuk Kim
Hi, Thank you for the report. I'm not able to reproduce this at all. In my runs, there was no regression. Can you do that? Thanks, 2013-05-15 (수), 12:09 +0300, Anca Emanuel: > Regresions: > http://www.phoronix.com/scan.php?page=article&item=linux_310_f2fs&num=3 > > The most notable one is Postg

Re: [f2fs-dev] [PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-05-26 Thread Jaegeuk Kim
Hi Namjae, This is an interesting functionality. Could you describe why and when we need to do this? What are pros and cons? How can we use this? IMO, when users try to control IO latencies, it seems that they can trigger such the explicit GCs, but in order to do that, they also need to know the

Re: [f2fs-dev] [patch] f2fs: dereferencing an ERR_PTR

2013-05-26 Thread Dan Carpenter
On Sun, May 26, 2013 at 05:05:15PM +0200, walter harms wrote: > > > Am 23.05.2013 12:02, schrieb Dan Carpenter: > > There is an error path where "dir" is an ERR_PTR. > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > > index 5148d90..921aede 100

Re: [f2fs-dev] [patch] f2fs: dereferencing an ERR_PTR

2013-05-26 Thread walter harms
Am 23.05.2013 12:02, schrieb Dan Carpenter: > There is an error path where "dir" is an ERR_PTR. > > Signed-off-by: Dan Carpenter > > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index 5148d90..921aede 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -71,7 +71,8 @@ st