[f2fs-dev] [patch v2] f2fs: alloc_page() doesn't return an ERR_PTR

2013-08-14 Thread Dan Carpenter
alloc_page() returns a NULL on failure, it never returns an ERR_PTR. Signed-off-by: Dan Carpenter --- v2: fix the calls in recovery.c as well. diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index f5172e2..3e87fe0 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1515,8 +1515,8 @@ int restore_no

Re: [f2fs-dev] [patch] f2fs: alloc_page() doesn't return an ERR_PTR

2013-08-14 Thread Dan Carpenter
On Wed, Aug 14, 2013 at 10:24:36PM +0900, Jaegeuk Kim wrote: > Hi Dan, > > Agreed. > Could you make a patch that covers other alloc_page cases too? Sure. Thanks for catching that. I will resend a v2 of this one which fixes those as well. regards, dan carpenter ---

Re: [f2fs-dev] [patch] f2fs: alloc_page() doesn't return an ERR_PTR

2013-08-14 Thread Jaegeuk Kim
Hi Dan, Agreed. Could you make a patch that covers other alloc_page cases too? # grep alloc_page fs/f2fs/* fs/f2fs/node.c: page = alloc_page(GFP_NOFS | __GFP_ZERO); fs/f2fs/recovery.c: page = alloc_page(GFP_F2FS_ZERO); fs/f2fs/recovery.c: page = alloc_page(GFP_NOFS | __GFP_ZERO); Thank you, 201

[f2fs-dev] [patch] f2fs: alloc_page() doesn't return an ERR_PTR

2013-08-14 Thread Dan Carpenter
alloc_page() returns a NULL on failure, it never returns an ERR_PTR. Signed-off-by: Dan Carpenter diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index f5172e2..3e87fe0 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1515,8 +1515,8 @@ int restore_node_summary(struct f2fs_sb_info *sbi,