Re: [f2fs-dev] [PATCH] f2fs: introduce f2fs_kmem_cache_alloc to hide the unfailed kmem cache allocation

2013-10-22 Thread Haicheng Li
On Tue, Oct 22, 2013 at 01:34:26PM +0800, Gu Zheng wrote: On 10/22/2013 01:16 PM, Haicheng Li wrote: On Tue, Oct 22, 2013 at 11:49:58AM +0800, Gao feng wrote: On 10/21/2013 03:24 PM, Gu Zheng wrote: +static inline void *f2fs_kmem_cache_alloc(struct kmem_cache *cachep, +

Re: [f2fs-dev] [PATCH] f2fs: introduce f2fs_kmem_cache_alloc to hide the unfailed kmem cache allocation

2013-10-22 Thread Gu Zheng
On 10/22/2013 02:15 PM, Haicheng Li wrote: On Tue, Oct 22, 2013 at 01:34:26PM +0800, Gu Zheng wrote: On 10/22/2013 01:16 PM, Haicheng Li wrote: On Tue, Oct 22, 2013 at 11:49:58AM +0800, Gao feng wrote: On 10/21/2013 03:24 PM, Gu Zheng wrote: +static inline void *f2fs_kmem_cache_alloc(struct

[f2fs-dev] [PATCH V2] f2fs: introduce f2fs_kmem_cache_alloc to hide the unfailed, kmem cache allocation

2013-10-22 Thread Gu Zheng
Introduce the unfailed version of kmem_cache_alloc named f2fs_kmem_cache_alloc to hide the retry routine and make the code a bit cleaner. v2: Fix the wrong use of 'retry' tag pointed out by Gao feng. Use more neat code to remove redundant tag suggested by Haicheng Li. Signed-off-by: Gu

[f2fs-dev] [PATCH] f2fs: check all ones or zeros bitmap with integer data type for better mount performance

2013-10-22 Thread Chao Yu
Previously, check_block_count check valid_map with bit data type in common scenario that sit has all ones or zeros bitmap, it makes low mount performance. So let's check the special bitmap with integer data type instead of the bit one. Signed-off-by: Tan Shu shu@samsung.com Signed-off-by: Yu

Re: [f2fs-dev] [Bug] Inaccessible, unerasable file

2013-10-22 Thread Jaegeuk Kim
Hi, Thank you for the report. 2013-10-19 (토), 19:36 +0200, Max Muster: There's a broken, ie. inaccessible and unerasable file on my f2fs partition (2nd partition with 21GB on a Corsair Flash Voyager GT USB 3.0 32GB). ls reports: cannot access shared.h: Input/output error total 0

Re: [f2fs-dev] [PATCH] f2fs: delete and free dirty dir freeing inode entry when sync dirty dir inodes

2013-10-22 Thread Jaegeuk Kim
2013-10-21 (월), 15:19 +0800, Gu Zheng: In sync_dirty_dir_inodes(), remove_dirty_dir_inode() will be called in the callback of filemap_flush to delete and free dirty dir inode entry. But for the freeing inode entry, missed this step after sbumit data bio, and this may lead to a dead loop if

Re: [f2fs-dev] [PATCH] f2fs: check all ones or zeros bitmap with integer data type for better mount performance

2013-10-22 Thread Jaegeuk Kim
Hi, 2013-10-22 (화), 17:28 +0800, Chao Yu: Previously, check_block_count check valid_map with bit data type in common scenario that sit has all ones or zeros bitmap, it makes low mount performance. So let's check the special bitmap with integer data type instead of the bit one.

Re: [f2fs-dev] [PATCH V2] f2fs: introduce f2fs_kmem_cache_alloc to hide the unfailed, kmem cache allocation

2013-10-22 Thread Jaegeuk Kim
Hi, Looks good to me. Thanks, 2013-10-22 (화), 14:52 +0800, Gu Zheng: Introduce the unfailed version of kmem_cache_alloc named f2fs_kmem_cache_alloc to hide the retry routine and make the code a bit cleaner. v2: Fix the wrong use of 'retry' tag pointed out by Gao feng. Use more neat

Re: [f2fs-dev] [Bug] Inaccessible, unerasable file

2013-10-22 Thread Max Muster
Hi, I don't recall anything like a blackout, but since I like to run new software that's still in development, I have had a fair share of system crashes. As far as I'm aware this is the only file on the partition to ever become corrupted at the file system level, though. The repository was a

Re: [f2fs-dev] [PATCH] f2fs: check all ones or zeros bitmap with integer data type for better mount performance

2013-10-22 Thread Chao Yu
Hi, Kim: -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Tuesday, October 22, 2013 8:24 PM To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; 谭姝 Subject: Re: [f2fs-dev] [PATCH] f2fs: check

[f2fs-dev] [PATCH] f2fs: use bool for booleans

2013-10-22 Thread Haicheng Li
Signed-off-by: Haicheng Li haicheng...@linux.intel.com --- fs/f2fs/checkpoint.c |4 ++-- fs/f2fs/f2fs.h |4 ++-- fs/f2fs/node.c |4 ++-- fs/f2fs/recovery.c |8 fs/f2fs/super.c |2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git