[f2fs-dev] [PATCH 2/2] f2fs: fix a deadlock during init_acl procedure

2013-10-27 Thread Jaegeuk Kim
The deadlock is found through the following scenario. sys_mkdir() -> f2fs_add_link() -> __f2fs_add_link() -> init_inode_metadata() : lock_page(inode); -> f2fs_init_acl() -> f2fs_set_acl() -> f2fs_setxattr(..., NULL) : This NULL page incurs a deadlock at update_inod

[f2fs-dev] [PATCH 1/2] f2fs: clean up acl flow for better readability

2013-10-27 Thread Jaegeuk Kim
This patch cleans up a couple of acl codes. Signed-off-by: Jaegeuk Kim --- fs/f2fs/acl.c | 25 + fs/f2fs/acl.h | 6 +++--- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c index b7826ec..f1a6975 100644 --- a/fs/f2fs/acl.c +++

[f2fs-dev] [PATCH] f2fs: remove unnecessary segment bitmap updates

2013-10-27 Thread Jaegeuk Kim
From: Changman Lee From: Changman Lee Only one dirty type is set in __locate_dirty_segment and we can know dirty type of segment. So we don't need to check other dirty types. Signed-off-by: Changman Lee Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.c | 31 --- 1

Re: [f2fs-dev] [PATCH V2] f2fs: check all ones or zeros bitmap with bitops for better mount performance

2013-10-27 Thread Gu Zheng
On 10/28/2013 10:19 AM, 이창만 wrote: > To check whether bitmap are all zeros or all ones, I think memcmp is more > neat. > But I don't know exactly performance gap between memcmp and find_next_bit. According to my understanding, memcmp: one by one search, find_next_bit: binary search. Regards, Gu

Re: [f2fs-dev] [PATCH V2] f2fs: check all ones or zeros bitmap with bitops for better mount performance

2013-10-27 Thread 이창만
To check whether bitmap are all zeros or all ones, I think memcmp is more neat. But I don't know exactly performance gap between memcmp and find_next_bit. -Original Message- From: Chao Yu [mailto:chao2...@samsung.com] Sent: Thursday, October 24, 2013 5:21 PM To: jaegeuk@samsung.com C