[f2fs-dev] [PATCH V2 2/2 RESEND] f2fs: read contiguous sit entry pages by merging for mount performance

2013-11-19 Thread Chao Yu
Previously we read sit entries page one by one, this method lost the chance of reading contiguous page together. So we read pages as contiguous as possible for better mount performance. v1-->v2: o merge judgements/use 'Continue' or 'Break' instead of 'Goto' as Gu Zheng suggested. o add ma

[f2fs-dev] [PATCH V2 1/2 RESEND] f2fs: add a new function to support for merging contiguous read

2013-11-19 Thread Chao Yu
For better read performance, we add a new function to support for merging contiguous read as the one for write. v1-->v2: o add declarations here as Gu Zheng suggested. o use new structure f2fs_bio_info introduced by Jaegeuk Kim. Signed-off-by: Chao Yu Acked-by: Gu Zheng --- fs/f2fs/data.c

Re: [f2fs-dev] [PATCH V2 1/2 RESEND] f2fs: add a new function to support for merging contiguous read

2013-11-19 Thread Chao Yu
Hi Kim, No considering 80 columns for the description, :( I will resend the patches. > -Original Message- > From: Chao Yu [mailto:chao2...@samsung.com] > Sent: Wednesday, November 20, 2013 1:55 PM > To: ??? (jaegeuk@samsung.com) > Cc: 'linux-fsde...@vger.kernel.org'; 'linux-ker...@vge

[f2fs-dev] [PATCH V2 1/2 RESEND] f2fs: add a new function to support for merging contiguous read

2013-11-19 Thread Chao Yu
For better read performance, we add a new function to support for merging contiguous read as the one for write. v1-->v2: o add declarations here as Gu Zheng suggested. o use new structure f2fs_bio_info introduced by Jaegeuk Kim. Signed-off-by: Chao Yu Acked-by: Gu Zheng --- fs/f2fs/data.c

[f2fs-dev] [PATCH V2 2/2 RESEND] f2fs: read contiguous sit entry pages by merging for mount performance

2013-11-19 Thread Chao Yu
Previously we read sit entries page one by one, this method lost the chance of reading contiguous page together. So we read pages as contiguous as possible for better mount performance. v1-->v2: o merge judgements/use 'Continue' or 'Break' instead of 'Goto' as Gu Zheng suggested. o add mark_pa

Re: [f2fs-dev] [PATCH V2 2/2] f2fs: read contiguous sit entry pages by merging for mount performance

2013-11-19 Thread Chao Yu
Hi Gu, > -Original Message- > From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com] > Sent: Monday, November 18, 2013 7:16 PM > To: Chao Yu > Cc: '???'; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net; 谭姝 > Subject: Re: [f2fs-dev] [PATCH V2

Re: [f2fs-dev] [PATCH 5/5] f2fs: move the list_head initialization into the lock protection region

2013-11-19 Thread Jaegeuk Kim
Hi Gu, IMO, there is no reason to cover the list header by the lock. In any flows, sbi should have the header all the time. What is your opinion? Thanks, 2013-11-19 (화), 18:03 +0800, Gu Zheng: > Signed-off-by: Gu Zheng > --- > fs/f2fs/checkpoint.c | 15 ++- > 1 files changed, 10

Re: [f2fs-dev] [Bug] Inaccessible, unerasable file

2013-11-19 Thread tast ky
Hello again, after buying a new USB stick and moving everything but the partition's broken file & folder to it, I am now able to send you an image after all. Although the 21 GB partition was supposed to only contain those two tiny entries, df still reported 1.8 GB as in use. I did "dd if=/dev/ze

[f2fs-dev] [PATCH 5/5] f2fs: move the list_head initialization into the lock protection region

2013-11-19 Thread Gu Zheng
Signed-off-by: Gu Zheng --- fs/f2fs/checkpoint.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index f884589..1de70cc 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c @@ -511,8 +511,8 @@ void add_di

[f2fs-dev] [PATCH 4/5] f2fs: simplify write_orphan_inodes for better readable

2013-11-19 Thread Gu Zheng
Simplify write_orphan_inodes for better readable. Because we hold the orphan_inode_mutex, so it's safe to use list_for_each_entry instead of list_for_each_safe. Signed-off-by: Gu Zheng --- fs/f2fs/checkpoint.c | 38 ++ 1 files changed, 18 insertions(+), 20

[f2fs-dev] [PATCH 2/5] f2fs: convert dev_valid_block_count to void

2013-11-19 Thread Gu Zheng
Signed-off-by: Gu Zheng --- fs/f2fs/f2fs.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 94fbec3..d0c6738 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -585,7 +585,7 @@ static inline bool inc_valid_block_count(struct f2fs_

[f2fs-dev] [PATCH 1/5] f2fs: convert remove_inode_page to void

2013-11-19 Thread Gu Zheng
Signed-off-by: Gu Zheng --- fs/f2fs/f2fs.h |2 +- fs/f2fs/node.c | 12 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 89dc750..94fbec3 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -1027,7 +1027,7 @@ int get_dnode_of_d

[f2fs-dev] [PATCH 0/5] f2fs: some minor cleanups and logic fixes

2013-11-19 Thread Gu Zheng
Gu Zheng (5): f2fs: convert remove_inode_page to void f2fs: convert dev_valid_block_count to void f2fs: convert inc/dec_valid_node_count to inc/dec one count f2fs: simplify write_orphan_inodes for better readable f2fs: move the list_head initialization into the lock protection region

[f2fs-dev] [PATCH 3/5] f2fs: convert inc/dec_valid_node_count to inc/dec one count

2013-11-19 Thread Gu Zheng
Signed-off-by: Gu Zheng --- fs/f2fs/f2fs.h | 32 +++- fs/f2fs/node.c |6 +++--- 2 files changed, 18 insertions(+), 20 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index d0c6738..125bef0 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -685,50 +6