Hi Kim,
> -Original Message-
> From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
> Sent: Wednesday, November 27, 2013 1:30 PM
> To: Chao Yu
> Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net; 谭姝
> Subject: Re: [f2fs-dev] [PATCH] f2
Hi Chao,
It seems that we already have a readahed function for node pages,
ra_node_page().
So, we don't make a page list for this, but can use the node_inode's
page cache.
So how about writing ra_node_pages() which use the node_inode's page
cache?
Thanks,
2013-11-22 (금), 15:48 +0800, Chao Yu:
>
Hi,
> -Original Message-
> From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
> Sent: Wednesday, November 27, 2013 1:14 PM
> To: Chao Yu
> Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net; 谭姝; fanofcode...@samsung.com
> Subject: Re:
Let's remove the unnecessary return value.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/f2fs.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 95d2aba..132bb3f 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -773,13 +773,12 @@ static inli
Got it.
But, with this patch, we can also remove the parameter, int mode, in
punch_hole().
If no objection, I'll fix that in your patch.
Thanks,
2013-11-22 (금), 16:52 +0800, Chao Yu:
> Because FALLOC_FL_PUNCH_HOLE flag must be ORed with FALLOC_FL_KEEP_SIZE
> in fallocate, so we could remove the
Hi Dan,
Thank you for the report.
How about this?
Thanks,
>From e053b711dcf9424974d232829b9c589269c98b4d Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim
Date: Tue, 12 Nov 2013 16:55:17 +0900
Subject: [PATCH] f2fs: introduce f2fs_issue_discard() to clean up
Cc: linux-fsde...@vger.kernel.org, linux-ke
Hello Jaegeuk Kim,
The patch 3fa7fb17dc9a: "f2fs: introduce f2fs_issue_discard() to clean
up" from Nov 12, 2013, leads to the following static checker warning:
"fs/f2fs/segment.c:274 f2fs_issue_discard()
warn: should 'blklen << sbi->log_sectors_per_block' be a 64 bit
type
Fix a potential out of range issue introduced by commit:
22fb72225a
f2fs: simplify write_orphan_inodes for better readable
Signed-off-by: Gu Zheng
---
fs/f2fs/checkpoint.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
in
