Re: [f2fs-dev] [PATCH] f2fs: remove the own bi_private allocation

2013-12-01 Thread Chao Yu
Hi Kim, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Saturday, November 30, 2013 9:48 AM > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: [f2fs-dev] [PATCH] f2fs: remove the own bi_p

Re: [f2fs-dev] [PATCH] f2fs: refactor bio-related operations

2013-12-01 Thread Chao Yu
Hi, Some comments as following. > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Saturday, November 30, 2013 2:26 PM > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: [f2fs-dev] [PATCH]

Re: [f2fs-dev] [PATCH 2/5] f2fs: add unlikely macro for compiler optimization

2013-12-01 Thread Chao Yu
Hi Kim, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Friday, November 29, 2013 6:14 PM > To: Chao Yu > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net; 谭姝 > Subject: Re: [f2fs-dev] [PATCH 2/5] f

Re: [f2fs-dev] [PATCH] f2fs: refactor bio-related operations

2013-12-01 Thread Gu Zheng
On 11/30/2013 02:25 PM, Jaegeuk Kim wrote: > This patch integrates redundant bio operations on read and write IOs. > > 1. Move bio-related codes to the top of data.c. > 2. Replace f2fs_submit_bio with f2fs_submit_merged_bio, which handles read >bios additionally. > 3. Introduce __submit_merge

Re: [f2fs-dev] [PATCH] f2fs: remove the own bi_private allocation

2013-12-01 Thread Gu Zheng
On 11/30/2013 09:48 AM, Jaegeuk Kim wrote: > Previously f2fs allocates its own bi_private data structure all the time even > though we don't use it. But, can we remove this bi_private allocation? > > This patch removes such the additional bi_private allocation. > > 1. Retrieve f2fs_sb_info from