Re: [f2fs-dev] [PATCH] f2fs: introduce a new direct_IO write path

2013-12-19 Thread Chao Yu
Hi Kim, One comment as following: > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Wednesday, December 18, 2013 8:12 AM > To: linux-fsde...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev]

[f2fs-dev] [PATCH v2] f2fs: move all the bio initialization into __bio_alloc

2013-12-19 Thread Gu Zheng
Move all the bio initialization into __bio_alloc, and some minor cleanups are also added. v2: Use 'is_read' rather than 'rw' as Yu Chao suggested. Remove the needless initialization of bio->bi_private. Signed-off-by: Gu Zheng --- fs/f2fs/data.c | 92 +--

Re: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into __bio_alloc

2013-12-19 Thread Gu Zheng
Hi Kim, Yu, Thanks for your review! On 12/19/2013 04:59 PM, Jaegeuk Kim wrote: > Hi Gu, > > I agreed with Chao. > It is more readable to use something like "is_read" instead of "rw". Agree. I'll follow it. Regards, Gu > Thanks, > > 2013-12-19 (목), 09:23 +0800, Chao Yu: >> Hi Gu, >> >>> -

Re: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into __bio_alloc

2013-12-19 Thread Jaegeuk Kim
Hi Gu, I agreed with Chao. It is more readable to use something like "is_read" instead of "rw". Thanks, 2013-12-19 (목), 09:23 +0800, Chao Yu: > Hi Gu, > > > -Original Message- > > From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com] > > Sent: Wednesday, December 18, 2013 6:29 PM > > To: Kim >

[f2fs-dev] [PATCH] f2fs: add description about small_discards in document

2013-12-19 Thread Jaegeuk Kim
This patch adds a description about small_disacrds in the f2fs document. Signed-off-by: Jaegeuk Kim --- Documentation/filesystems/f2fs.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/filesystems/f2fs.txt b/Documentation/filesystems/f2fs.txt index 6de2102..1073970 100