Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Jaegeuk Kim
Hi, 2014-02-13 (목), 17:48 +0800, Gu Zheng: > Hi, > On 02/13/2014 05:40 PM, Andrey Tsyvarev wrote: > > > Hi, > > > >> BTW, have you tested the case that added remove_dirty_dir_inode() into the > >> fail path > >> of init_inode_metadata? > >> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c > >> index

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Jaegeuk Kim
Hi, Sorry for the late response. I suffered from flu during last a couple of days. :( 2014-02-11 (화), 12:29 +0400, Andrey Tsyvarev: > Hi, > > > It turns out that make_bad_inode prior to iput sets i_mode to a regular > > file, so that f2fs_evict_inode -> truncate_inode_pages -> > > f2fs_invalidat

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Gu Zheng
Hi, On 02/13/2014 05:40 PM, Andrey Tsyvarev wrote: > Hi, > >> BTW, have you tested the case that added remove_dirty_dir_inode() into the >> fail path >> of init_inode_metadata? >> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c >> index e095a4f..d5a2c9e 100644 >> --- a/fs/f2fs/dir.c >> +++ b/fs/f2fs/

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Andrey Tsyvarev
Hi, > BTW, have you tested the case that added remove_dirty_dir_inode() into the > fail path > of init_inode_metadata? > diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c > index e095a4f..d5a2c9e 100644 > --- a/fs/f2fs/dir.c > +++ b/fs/f2fs/dir.c > @@ -375,6 +375,7 @@ put_error: > /* once the f

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Gu Zheng
Hi Andrey, On 02/11/2014 04:29 PM, Andrey Tsyvarev wrote: > Hi, > >> It turns out that make_bad_inode prior to iput sets i_mode to a regular >> file, so that f2fs_evict_inode -> truncate_inode_pages -> >> f2fs_invalidate_data_page doesn't decrement dirty_dents. >> > It seems that remove_dirty_dir