Re: [f2fs-dev] f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-17 Thread Gu Zheng
Hi Alexey, Kim, On 04/18/2014 02:04 PM, Alexey Khoroshilov wrote: > On 17.04.2014 00:45, Jaegeuk Kim wrote: >> Hi, >> >> 2014-04-16 (수), 18:11 -0700, Alexey Khoroshilov: >>> Hi, >>> >>> But would not ability to trigger BUG_ON by mounting a crafted image >>> considered as an issue having security i

Re: [f2fs-dev] f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-17 Thread Jaegeuk Kim
Thank you for the explanation. The following patch will resolve the issue. Thanks, >From 2048e7458c982f4297da9d3366ab29224ae2e8b0 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Fri, 18 Apr 2014 15:21:04 +0900 Subject: [PATCH] f2fs: avoid BUG_ON when mouting corrupted image having garbage block

Re: [f2fs-dev] f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-17 Thread Alexey Khoroshilov
On 17.04.2014 00:45, Jaegeuk Kim wrote: > Hi, > > 2014-04-16 (수), 18:11 -0700, Alexey Khoroshilov: >> Hi, >> >> But would not ability to trigger BUG_ON by mounting a crafted image >> considered as an issue having security implications? > Sorry, I can't come up with you. > Could you please explain w

Re: [f2fs-dev] [PATCH] f2fs: fix to enable readahead last NAT block

2014-04-17 Thread Jaegeuk Kim
Got it. The patch is like this. Thanks, >From 5f7a3bcf0df10bbb47a6e4409cc92ba8e6090674 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Fri, 18 Apr 2014 11:14:37 +0900 Subject: [PATCH] f2fs: add available_nids to fix handling max_nid correctly This patch introduces available_nids for alloc_nids(

Re: [f2fs-dev] [PATCH] f2fs: fix to enable readahead last NAT block

2014-04-17 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Friday, April 18, 2014 10:16 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to ena

Re: [f2fs-dev] [PATCH] f2fs: fix to enable readahead last NAT block

2014-04-17 Thread Jaegeuk Kim
Hi Chao, How about this? --- fs/f2fs/f2fs.h | 1 + fs/f2fs/node.c | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 55152de..556d06b 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -244,6 +244,7 @@ static inline void set_raw_exte

[f2fs-dev] 4361{RAND_NUMBER_0}Good news from Banana Co.in China

2014-04-17 Thread azv
5152855 Atten: purchase manager Dear purchase manager, Have a nice day! I would like to introduce myself. I am Anne Guo from Shenzhen Banana Electronics Co. in China. I hope we could have a chance to work together in the near future. If you have time, you are welcome to visit our we

[f2fs-dev] [PATCH] f2fs: fix to enable readahead last NAT block

2014-04-17 Thread Chao Yu
We skip reading last one of NAT blocks when readahead them since max value of valid block is calculated incorrectly. We should fix this problem to avoid it. Signed-off-by: Chao Yu --- fs/f2fs/checkpoint.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/checkpoint.c

Re: [f2fs-dev] [PATCH] f2fs: fix wrong number of max_nid when init

2014-04-17 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Thursday, April 17, 2014 3:17 PM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [f2fs-dev] [PATCH] f2fs: fix wrong

Re: [f2fs-dev] f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-17 Thread Jaegeuk Kim
Hi, 2014-04-16 (수), 18:11 -0700, Alexey Khoroshilov: > Hi, > > But would not ability to trigger BUG_ON by mounting a crafted image > considered as an issue having security implications? Sorry, I can't come up with you. Could you please explain why this can be related to the security hole? Did yo

Re: [f2fs-dev] [PATCH] f2fs: fix wrong number of max_nid when init

2014-04-17 Thread Jaegeuk Kim
Hi, 2014-04-17 (목), 14:27 +0800, Chao Yu: > Since max_nid value was minus three in previous commit: > 'b63da15e8b475245026bdf2096853683f189706b', Our last three nids could not be > used ever, but 0/node nid/meta nid is still occupied. > And also our ra_meta_pages() could not readahead the last blo