Re: [f2fs-dev] [PATCH] libf2fs: move the finalize_device() into the io lib.

2014-06-13 Thread Jaegeuk Kim
On Fri, Jun 13, 2014 at 01:25:20PM -0700, JP Abgrall wrote: > This is required so that libf2fs.c can be used against any kind > of device (E.g. an in-memory sparse file) just by linking against > something that provides the libf2fs_io.c functions. > > libf2fs is currently libf2fs.c + libf2fs_io.c

[f2fs-dev] [PATCH] libf2fs: move the finalize_device() into the io lib.

2014-06-13 Thread JP Abgrall
This is required so that libf2fs.c can be used against any kind of device (E.g. an in-memory sparse file) just by linking against something that provides the libf2fs_io.c functions. libf2fs is currently libf2fs.c + libf2fs_io.c Signed-off-by: JP Abgrall --- lib/libf2fs.c| 12 l

Re: [f2fs-dev] [PATCH] libf2fs, fsck, mkfs: call f2fs_finalize_device before exit

2014-06-13 Thread JP Abgrall
On Fri, Jun 13, 2014 at 1:25 AM, Jaegeuk Kim wrote: > diff --git a/lib/libf2fs.c b/lib/libf2fs.c > index 6168c5c..8d6c670 100644 > --- a/lib/libf2fs.c > +++ b/lib/libf2fs.c > @@ -493,3 +493,15 @@ int f2fs_get_device_info(struct f2fs_configuration *c) > return 0; > } > > +void f2fs_finaliz

[f2fs-dev] [PATCH 3/3] f2fs: fix not to allocate unnecessary blocks during fallocate

2014-06-13 Thread Jaegeuk Kim
This patch fixes the fallocate bug like below. (See xfstests/255) In fallocate(fd, 0, 20480), expand_inode_data processes for (index = pg_start; index <= pg_end; index++) { f2fs_reserve_block(); ... } So, even though fallocate requests 20480, 5 bloc

[f2fs-dev] [PATCH 2/3] f2fs: recover fallocated data and its i_size together

2014-06-13 Thread Jaegeuk Kim
This patch arranges the f2fs_locks to cover the fallocated data and its i_size. Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 9c49c59..623df73 100644 --- a/fs/f2fs/file.c +++ b/fs/f2f

[f2fs-dev] [PATCH 1/3] f2fs: fix to report newly allocate region as extent

2014-06-13 Thread Jaegeuk Kim
Previous get_block in f2fs didn't report the newly allocated region which has NEW_ADDR. For reader, it should not report, but fiemap needs this. So, this patch introduces two get_block sharing core function. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 23 ++- 1 file chang

[f2fs-dev] [PATCH] mkfs: set BLKDISCARD by default

2014-06-13 Thread Jaegeuk Kim
And let's show some debug info as well. Signed-off-by: Jaegeuk Kim --- mkfs/Makefile.am | 2 +- mkfs/f2fs_format_utils.c | 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am index 68cab66..ff136a7 100644 --- a/mkfs/Makefile.am +++

[f2fs-dev] [PATCH] libf2fs, fsck, mkfs: call f2fs_finalize_device before exit

2014-06-13 Thread Jaegeuk Kim
The fsck tool should call f2fs_finalize_device before exit to close the device file. Signed-off-by: Jaegeuk Kim --- fsck/main.c | 3 +++ include/f2fs_fs.h| 1 + lib/libf2fs.c| 12 mkfs/f2fs_format.c | 2 -- mkfs/f2fs_format_main.c | 2 ++