[f2fs-dev] cp hangs with large source tree

2014-06-24 Thread Brian Chadwick
Hi, Kernel 3.15.0 ... I tried copying a large tree full of many small files (kernel source) onto a drive formatted with F2FS. The copy seems to proceed normally, but when all files appear to be copied, cp seems to hang and does not seem to terminate properly. Its waiting for something I assume

Re: [f2fs-dev] [PATCH 3/4] f2fs: use find_next_bit_le rather than test_bit_le in, find_in_block

2014-06-24 Thread Gu Zheng
Hi Yu, On 06/25/2014 10:30 AM, Chao Yu wrote: > Hi Gu, > > Just one nitpick. > >> -Original Message- >> From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com] >> Sent: Tuesday, June 24, 2014 6:21 PM >> To: Jaegeuk Kim >> Cc: fsdevel; f2fs >> Subject: [f2fs-dev] [PATCH 3/4] f2fs: use find_next_b

Re: [f2fs-dev] [PATCH 3/4] f2fs: use find_next_bit_le rather than test_bit_le in, find_in_block

2014-06-24 Thread Chao Yu
Hi Gu, Just one nitpick. > -Original Message- > From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com] > Sent: Tuesday, June 24, 2014 6:21 PM > To: Jaegeuk Kim > Cc: fsdevel; f2fs > Subject: [f2fs-dev] [PATCH 3/4] f2fs: use find_next_bit_le rather than > test_bit_le in, > find_in_block > > Use

Re: [f2fs-dev] [PATCH 2/4] f2fs: remove the needless point-cast

2014-06-24 Thread Gu Zheng
Hi Yu, On 06/25/2014 09:55 AM, Chao Yu wrote: > Hi Gu, > > I found kaddr in f2fs_delete_entry is unneeded, maybe this trivial problem > could be fixed in this patch together. :) Yeah, I'll add this fix together.;) Regards, Gu > > Thanks. > >> -Original Message- >> From: Gu Zheng [mai

Re: [f2fs-dev] [PATCH 2/4] f2fs: remove the needless point-cast

2014-06-24 Thread Chao Yu
Hi Gu, I found kaddr in f2fs_delete_entry is unneeded, maybe this trivial problem could be fixed in this patch together. :) Thanks. > -Original Message- > From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com] > Sent: Tuesday, June 24, 2014 6:20 PM > To: Jaegeuk Kim > Cc: fsdevel; f2fs > Subjec

[f2fs-dev] [PATCH 4/4] f2fs: arguments cleanup of finding file flow functions

2014-06-24 Thread Gu Zheng
Signed-off-by: Gu Zheng --- fs/f2fs/dir.c | 28 +--- fs/f2fs/f2fs.h |2 +- fs/f2fs/hash.c |4 +++- 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index ba510fb..06f4833 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.

[f2fs-dev] [PATCH 3/4] f2fs: use find_next_bit_le rather than test_bit_le in, find_in_block

2014-06-24 Thread Gu Zheng
Use find_next_bit_le rather than test_bit_le to improve search speed lightly. Signed-off-by: Gu Zheng --- fs/f2fs/dir.c | 43 +-- 1 files changed, 21 insertions(+), 22 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 3edd561..ba510fb 100644

[f2fs-dev] [PATCH 2/4] f2fs: remove the needless point-cast

2014-06-24 Thread Gu Zheng
Signed-off-by: Gu Zheng --- fs/f2fs/dir.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 087b03d..3edd561 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -298,14 +298,13 @@ static int make_empty_dir(struct inode *inode,

[f2fs-dev] [PATCH 1/4] f2fs: remove the redundant validation check of acl

2014-06-24 Thread Gu Zheng
>From the userspace side, VFS layer does the check; and from the kernel side(xx_init_acl), the acl is get/cloned from the parent dir's, which is credible. So remove the redundant validation check of acl here. Signed-off-by: Gu Zheng --- fs/f2fs/acl.c |6 -- 1 files changed, 0 insertions(