Re: [f2fs-dev] f2fs: Possible use-after-free when umount filesystem

2014-07-22 Thread Gu Zheng
Hi, On 07/23/2014 10:12 AM, Chao Yu wrote: > Hi Andrey Gu, > >> -Original Message- >> From: Andrey Tsyvarev [mailto:tsyva...@ispras.ru] >> Sent: Tuesday, July 22, 2014 6:04 PM >> To: Gu Zheng >> Cc: Jaegeuk Kim; linux-kernel; Alexey Khoroshilov; >> linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] f2fs: Possible use-after-free when umount filesystem

2014-07-22 Thread Chao Yu
Hi Andrey Gu, > -Original Message- > From: Andrey Tsyvarev [mailto:tsyva...@ispras.ru] > Sent: Tuesday, July 22, 2014 6:04 PM > To: Gu Zheng > Cc: Jaegeuk Kim; linux-kernel; Alexey Khoroshilov; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] f2fs: Possible use-after-fre

[f2fs-dev] [PATCH] mkfs.f2fs: Fix name conflict for BLKDISCARD

2014-07-22 Thread Sankalp Bose
The compile time option BLKDISCARD conflicts with ioctl code for discard. This causes discard to fail with "Info: This device doesn't support TRIM". Rename compile time option to WITH_BLKDISCARD. Signed-off-by: Sankalp Bose --- configure.ac | 2 +- mkfs/Makefile.am | 2 +- mk

Re: [f2fs-dev] f2fs: Possible use-after-free when umount filesystem

2014-07-22 Thread Andrey Tsyvarev
Hi Gu, >> Investigation shows, that f2fs_evict_inode, when called for 'meta_inode', >> uses invalidate_mapping_pages() for 'node_inode'. >> But 'node_inode' is deleted before 'meta_inode' in f2fs_put_super via iput(). >> >> It seems that in common usage scenario this use-after-free is benign, >>