Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-19 Thread Jaegeuk Kim
On Thu, Nov 20, 2014 at 03:04:10PM +0900, Changman Lee wrote: > Hi Jaegeuk, > > We should call flush_dcache_page before kunmap because the purpose of the > cache flush is to address aliasing problem related to virtual address. Oh, I just followed zero_user_segments below. static inline void zer

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-19 Thread Changman Lee
Hi Jaegeuk, We should call flush_dcache_page before kunmap because the purpose of the cache flush is to address aliasing problem related to virtual address. On Wed, Nov 19, 2014 at 02:35:08PM -0800, Jaegeuk Kim wrote: > Whenever f2fs updates mapped pages, it needs to call flush_dcache_page. > >

Re: [f2fs-dev] [PATCH] f2fs: add cleancache support

2014-11-19 Thread Changman Lee
On Fri, Nov 14, 2014 at 02:53:02PM +0900, Changman Lee wrote: > On Thu, Nov 13, 2014 at 05:27:51PM -0800, Jaegeuk Kim wrote: > > Hi Changman, > > > > On Thu, Nov 13, 2014 at 02:34:50PM +0900, Changman Lee wrote: > > > To use cleancache, fs must explicitly enable cleancache by calling > > > cleanca

[f2fs-dev] [PATCH 2/3] f2fs: submit bio for node blocks in the reclaim path

2014-11-19 Thread Jaegeuk Kim
If a node page is request to be written during the reclaiming path, we should submit the bio to avoid pending to recliam it. Signed-off-by: Jaegeuk Kim --- fs/f2fs/node.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 478ce1e..dbf49cc 100644 --- a/f

[f2fs-dev] [PATCH 3/3] f2fs: write SSA pages under memory pressure

2014-11-19 Thread Jaegeuk Kim
Under memory pressure, we don't need to skip SSA page writes. Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 838e8ed..20a917b 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/

[f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-19 Thread Jaegeuk Kim
Whenever f2fs updates mapped pages, it needs to call flush_dcache_page. Signed-off-by: Jaegeuk Kim --- fs/f2fs/dir.c| 7 ++- fs/f2fs/inline.c | 4 +++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 5a49995..312fbfc 100644 --- a/fs/f2fs

Re: [f2fs-dev] [PATCH 2/2] f2fs: put the inode page when error was occurred

2014-11-19 Thread Jaegeuk Kim
On Tue, Nov 18, 2014 at 01:30:46PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Tuesday, November 18, 2014 9:58 AM > > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > > linux-f2fs-devel@lists.sou