Hi Jaegeuk,
I've modified as you mentioned. Review again, please.
Changes from V1
o introduce gc_inode_list containing ilist and iradix
o use local variable
o call radix_tree_delete before iput
o retry to add inode into radix_tree
o call list_del explicitly
Thanks,
Changman
-- >8 --
>From
On Thu, Nov 27, 2014 at 07:55:14PM -0800, Jaegeuk Kim wrote:
> Hi Changman,
>
> On Thu, Nov 27, 2014 at 06:42:54PM +0900, Changman Lee wrote:
> > There in no any lock to protect gc_inode list so let's move into
> > gc_mutex, otherwise it might be lost links of list.
>
> Could you explain why the
Hi,
As you said, I will resend a patch. Thanks for your review.
On Thu, Nov 27, 2014 at 08:24:21PM -0800, Jaegeuk Kim wrote:
> Hi,
>
> On Thu, Nov 27, 2014 at 06:11:51PM +0900, Changman Lee wrote:
> > If there are many inodes that have data blocks in victim segment,
> > it takes long time to fin
Hi,
On Thu, Nov 27, 2014 at 06:11:51PM +0900, Changman Lee wrote:
> If there are many inodes that have data blocks in victim segment,
> it takes long time to find a inode in gc_inode list.
> Let's use radix_tree to reduce lookup time.
>
> Signed-off-by: Changman Lee
> ---
> fs/f2fs/gc.c | 21 ++
Hi Changman,
On Thu, Nov 27, 2014 at 06:42:54PM +0900, Changman Lee wrote:
> There in no any lock to protect gc_inode list so let's move into
> gc_mutex, otherwise it might be lost links of list.
Could you explain why the links can be lost?
Cause the ilist is a local variable.
IIRC, the reason w
There in no any lock to protect gc_inode list so let's move into
gc_mutex, otherwise it might be lost links of list.
Signed-off-by: Changman Lee
---
fs/f2fs/gc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 657683c9..99e1720 100644
---
If there are many inodes that have data blocks in victim segment,
it takes long time to find a inode in gc_inode list.
Let's use radix_tree to reduce lookup time.
Signed-off-by: Changman Lee
---
fs/f2fs/gc.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git
