Re: [f2fs-dev] [PATCH] f2fs: check if inode's state is dirty or not before skip fsync

2014-12-02 Thread Changman Lee
Hi Jaegeuk, Thanks for explanation. On Tue, Dec 02, 2014 at 11:42:19AM -0800, Jaegeuk Kim wrote: > On Tue, Dec 02, 2014 at 01:21:31PM +0900, Changman Lee wrote: > > Hi, > > > > f2fs_dirty_inode just set fi->flag as FI_DIRTY_INODE not to > > call update_inode_page. Instead, we do it when f2fs_wri

Re: [f2fs-dev] [PATCH] f2fs: check if inode's state is dirty or not before skip fsync

2014-12-02 Thread Jaegeuk Kim
On Tue, Dec 02, 2014 at 01:21:31PM +0900, Changman Lee wrote: > Hi, > > f2fs_dirty_inode just set fi->flag as FI_DIRTY_INODE not to > call update_inode_page. Instead, we do it when f2fs_write_indoe is called. > Do you have any reason to do like this? Actually, I'd like to use inode caches instead

Re: [f2fs-dev] [PATCH V2] f2fs: more fast lookup for gc_inode list

2014-12-02 Thread Changman Lee
Hi Yu, Thanks for your review. Changes from V3 o check if entry exists to avoid many kmem_cache_{alloc, free} Changes from V2 o rename iradix to iroot o declare gc_inode_list in gc.h Changes from V1 o introduce gc_inode_list containing ilist and iradix o use local variable o call r

Re: [f2fs-dev] [PATCH V2] f2fs: more fast lookup for gc_inode list

2014-12-02 Thread Chao Yu
Hi Changman, > -Original Message- > From: Changman Lee [mailto:cm224@samsung.com] > Sent: Tuesday, December 02, 2014 8:38 AM > To: Jaegeuk Kim > Cc: linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH V2] f2fs: more fast lookup for gc_