Re: [f2fs-dev] [PATCH 1/3] f2fs: fix missing kmem_cache_free

2014-12-04 Thread Gu Zheng
Hi Jaegeuk, On 12/05/2014 08:49 AM, Jaegeuk Kim wrote: > This patch fixes missing kmem_cache_free when handling errors. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/node.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index b1466c

Re: [f2fs-dev] [PATCH] f2fs: check if inode's state is dirty or not before skip fsync

2014-12-04 Thread Changman Lee
On Thu, Dec 04, 2014 at 04:58:29PM -0800, Jaegeuk Kim wrote: > On Wed, Dec 03, 2014 at 10:46:38AM +0900, Changman Lee wrote: > > Hi Jaegeuk, > > > > Thanks for explanation. > > > > On Tue, Dec 02, 2014 at 11:42:19AM -0800, Jaegeuk Kim wrote: > > > On Tue, Dec 02, 2014 at 01:21:31PM +0900, Changma

Re: [f2fs-dev] [PATCH] f2fs: check if inode's state is dirty or not before skip fsync

2014-12-04 Thread Jaegeuk Kim
On Wed, Dec 03, 2014 at 10:46:38AM +0900, Changman Lee wrote: > Hi Jaegeuk, > > Thanks for explanation. > > On Tue, Dec 02, 2014 at 11:42:19AM -0800, Jaegeuk Kim wrote: > > On Tue, Dec 02, 2014 at 01:21:31PM +0900, Changman Lee wrote: > > > Hi, > > > > > > f2fs_dirty_inode just set fi->flag as F

[f2fs-dev] [PATCH 3/3] f2fs: call radix_tree_preload before radix_tree_insert

2014-12-04 Thread Jaegeuk Kim
This patch tries to fix: BUG: using smp_processor_id() in preemptible [] code: f2fs_gc-254:0/384 (radix_tree_node_alloc+0x14/0x74) from [] (radix_tree_insert+0x110/0x200) (radix_tree_insert+0x110/0x200) from [] (gc_data_segment+0x340/0x52c) (gc_data_segment+0x340/0x52c) from [] (f

[f2fs-dev] [PATCH 2/3] f2fs: use rw_semaphore for nat entry lock

2014-12-04 Thread Jaegeuk Kim
Previoulsy, we used rwlock for nat_entry lock. But, now we have a lot of complex operations in set_node_addr. (e.g., allocating kernel memories, handling radix_trees, and so on) So, this patches tries to change spinlock to rw_semaphore to give CPUs to other threads. Signed-off-by: Jaegeuk Kim --

[f2fs-dev] [PATCH 1/3] f2fs: fix missing kmem_cache_free

2014-12-04 Thread Jaegeuk Kim
This patch fixes missing kmem_cache_free when handling errors. Signed-off-by: Jaegeuk Kim --- fs/f2fs/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index b1466cf..c59341d 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -158,7 +158,