Re: [f2fs-dev] [PATCH 2/6 v2] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Dave Chinner
On Thu, Jan 08, 2015 at 05:40:06PM -0800, Jaegeuk Kim wrote: Change log from v1: o introduce FS_IOC_GOINGDOWN ioctl o introduce three options: FS_GOING_DOWN_FULLSYNC, FS_GOING_DOWN_METASYNC, and FS_GOING_DOWN_NOSYNC . diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h

Re: [f2fs-dev] [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Jaegeuk Kim
On Fri, Jan 09, 2015 at 09:04:12AM +1100, Dave Chinner wrote: On Thu, Jan 08, 2015 at 01:21:29PM -0800, Jaegeuk Kim wrote: On Fri, Jan 09, 2015 at 07:54:16AM +1100, Dave Chinner wrote: On Thu, Jan 08, 2015 at 02:33:17PM -0600, Eric Sandeen wrote: On 1/8/15 2:18 PM, Jaegeuk Kim wrote:

Re: [f2fs-dev] [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Dave Chinner
On Thu, Jan 08, 2015 at 01:21:29PM -0800, Jaegeuk Kim wrote: On Fri, Jan 09, 2015 at 07:54:16AM +1100, Dave Chinner wrote: On Thu, Jan 08, 2015 at 02:33:17PM -0600, Eric Sandeen wrote: On 1/8/15 2:18 PM, Jaegeuk Kim wrote: On Thu, Jan 08, 2015 at 01:54:20PM -0600, Eric Sandeen wrote:

[f2fs-dev] [PATCH 2/2 v2] xfs/087: move to shared/087

2015-01-08 Thread Jaegeuk Kim
This patch moves xfs/087 to shared/. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/shared/087 | 169 ++ tests/shared/087.out | 389 +++ tests/shared/group | 1 + tests/xfs/087| 169

[f2fs-dev] [PATCH 1/2 v2] xfs/087: test f2fs selectively

2015-01-08 Thread Jaegeuk Kim
This patch add the f2fs support for xfs/087 with goingdown. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/xfs/087 | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/tests/xfs/087 b/tests/xfs/087 index 3a3fb49..9dc81c7 100755 ---

[f2fs-dev] [PATCH 3/6] f2fs: free radix_tree_nodes used by nat_set entries

2015-01-08 Thread Jaegeuk Kim
In the normal case, the radix_tree_nodes are freed successfully. But, when cp_error was detected, we should destroy them forcefully. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/node.c | 21 +++-- fs/f2fs/node.h | 1 + 2 files changed, 20 insertions(+), 2

[f2fs-dev] [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Jaegeuk Kim
This patch add an ioctl to shutdown f2fs, which stops all the further block writes after this point. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 14 ++ 2 files changed, 15 insertions(+) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index

[f2fs-dev] [PATCH 4/6] f2fs: add nat/sit entries into status

2015-01-08 Thread Jaegeuk Kim
This patch adds NAT/SIT entry informations. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/debug.c | 8 +--- fs/f2fs/f2fs.h | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c index dd7835b..1f0fb58 100644 --- a/fs/f2fs/debug.c

[f2fs-dev] [PATCH 6/6] f2fs: add f2fs_destroy_trace_ios to free radix tree

2015-01-08 Thread Jaegeuk Kim
This patch removes radix tree after finishing tracing IOs. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/super.c | 1 + fs/f2fs/trace.c | 37 + fs/f2fs/trace.h | 2 ++ 3 files changed, 40 insertions(+) diff --git a/fs/f2fs/super.c

[f2fs-dev] [PATCH 2/2] f2fs/087: test power failure test using godown

2015-01-08 Thread Jaegeuk Kim
This patch adds f2fs/087 to test power failure by using godown. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/f2fs/087 | 88 ++ tests/f2fs/087.out | 21 + tests/f2fs/group | 1 + 3 files changed, 110 insertions(+)

Re: [f2fs-dev] [PATCH 1/2] src/godown: support f2fs triggering specific ioctl

2015-01-08 Thread Eric Sandeen
On 1/8/15 12:31 PM, Jaegeuk Kim wrote: This patch triggers the F2FS-related ioctl for godown. hohum, wouldn't it be a whole lot easier to just re-use the XFS ioctl number in f2fs? Then you wouldn't have to duplicate all this code. If you really want your own unique ioctl number, what about

Re: [f2fs-dev] [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Jaegeuk Kim
On Thu, Jan 08, 2015 at 01:54:20PM -0600, Eric Sandeen wrote: On 1/8/15 12:10 PM, Jaegeuk Kim wrote: This patch add an ioctl to shutdown f2fs, which stops all the further block writes after this point. would it make sense to just re-use the xfs ioctl nr, if the semantics are the same?

Re: [f2fs-dev] [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Eric Sandeen
On 1/8/15 2:18 PM, Jaegeuk Kim wrote: On Thu, Jan 08, 2015 at 01:54:20PM -0600, Eric Sandeen wrote: On 1/8/15 12:10 PM, Jaegeuk Kim wrote: This patch add an ioctl to shutdown f2fs, which stops all the further block writes after this point. would it make sense to just re-use the xfs ioctl nr,

Re: [f2fs-dev] [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Dave Chinner
On Thu, Jan 08, 2015 at 02:33:17PM -0600, Eric Sandeen wrote: On 1/8/15 2:18 PM, Jaegeuk Kim wrote: On Thu, Jan 08, 2015 at 01:54:20PM -0600, Eric Sandeen wrote: On 1/8/15 12:10 PM, Jaegeuk Kim wrote: This patch add an ioctl to shutdown f2fs, which stops all the further block writes

Re: [f2fs-dev] [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Jaegeuk Kim
On Fri, Jan 09, 2015 at 07:54:16AM +1100, Dave Chinner wrote: On Thu, Jan 08, 2015 at 02:33:17PM -0600, Eric Sandeen wrote: On 1/8/15 2:18 PM, Jaegeuk Kim wrote: On Thu, Jan 08, 2015 at 01:54:20PM -0600, Eric Sandeen wrote: On 1/8/15 12:10 PM, Jaegeuk Kim wrote: This patch add an ioctl

[f2fs-dev] [PATCH f2fs] f2fs: pids_lock can be static

2015-01-08 Thread kbuild test robot
fs/f2fs/trace.c:19:12: sparse: symbol 'pids_lock' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- trace.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/trace.c b/fs/f2fs/trace.c index 92fa38a..517dfe5 100644 ---

[f2fs-dev] [f2fs:linux-3.4 31/33] fs/f2fs/trace.c:19:12: sparse: symbol 'pids_lock' was not declared. Should it be static?

2015-01-08 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs linux-3.4 head: a725baf7b8472a0b97dc12ed4d1c147cad2f3e8c commit: 37a78eb5019798c94d4543c48e1d6490a552e1c7 [31/33] f2fs: add spin_lock to cover radix operations in IO tracer reproduce: # apt-get install sparse git checkout

Re: [f2fs-dev] [PATCH 1/2] src/godown: support f2fs triggering specific ioctl

2015-01-08 Thread Jaegeuk Kim
On Thu, Jan 08, 2015 at 12:44:56PM -0600, Eric Sandeen wrote: On 1/8/15 12:31 PM, Jaegeuk Kim wrote: This patch triggers the F2FS-related ioctl for godown. hohum, wouldn't it be a whole lot easier to just re-use the XFS ioctl number in f2fs? Then you wouldn't have to duplicate all this