Re: [f2fs-dev] [PATCH 2/2 v3] f2fs: skip checkpoint if there is no dirty segments

2015-08-12 Thread Jaegeuk Kim
Change log from v2: - consider omitting current dirty segments >From 181cb245f6a406e89c00976f65a5727956a72942 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Tue, 11 Aug 2015 21:59:49 -0700 Subject: [PATCH] f2fs: skip checkpoint if there is no dirty and prefree segments We should avoid needle

Re: [f2fs-dev] general stability of f2fs?

2015-08-12 Thread Marc Lehmann
On Mon, Aug 10, 2015 at 02:58:06PM -0700, Jaegeuk Kim wrote: > IMO, it's similar to flash drives too. Indeed, I believe host-managed > SMR/flash > drives are likely to show much better performance than drive-managed ones. If I had one, its performance would be abysmal, as filesystems (and indee

Re: [f2fs-dev] f2fs: callers take care of the page from bio error

2015-08-12 Thread Dan Carpenter
On Wed, Aug 12, 2015 at 10:18:37AM -0700, Jaegeuk Kim wrote: > > 1041 err = read_node_page(apage, READA); > > 1042 f2fs_put_page(apage, err ? 1 : 0); > > > > In the old code we took errors into consideration but now we treat them > > as LOCKED_PAGE. Is that intentional? A l

Re: [f2fs-dev] f2fs: callers take care of the page from bio error

2015-08-12 Thread Jaegeuk Kim
Hi Dan, On Wed, Aug 12, 2015 at 01:40:10PM +0300, Dan Carpenter wrote: > Hello Jaegeuk Kim, > > The patch 86531d6b84bc: "f2fs: callers take care of the page from bio > error" from Jul 15, 2015, leads to the following static checker > warning: > > fs/f2fs/node.c:1042 ra_node_page() >

Re: [f2fs-dev] [PATCH v2] f2fs: do not write any node pages related to orphan inodes

2015-08-12 Thread Jaegeuk Kim
Chang log from v1: - remove inappropriate remained flag ops suggested by Chao Thanks, >From 8ab2c8bacedb74d35dfe481d43a8fb1291650c39 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Tue, 11 Aug 2015 12:45:39 -0700 Subject: [PATCH] f2fs: do not write any node pages related to orphan inodes We s

Re: [f2fs-dev] f2fs: callers take care of the page from bio error

2015-08-12 Thread Dan Carpenter
Hello Jaegeuk Kim, The patch 86531d6b84bc: "f2fs: callers take care of the page from bio error" from Jul 15, 2015, leads to the following static checker warning: fs/f2fs/node.c:1042 ra_node_page() warn: 'err' can be either negative or positive fs/f2fs/node.c 1025 void ra_node_

[f2fs-dev] [PATCH] f2fs: avoid clear valid page

2015-08-12 Thread Chao Yu
In f2fs_delete_entry, if last dirent is remove from the dentry page, we will try to punch that page since it has no valid date in it. But truncate_hole which is used for punching could fail because of no memory or IO error, if that happened, we'd better skip clearing this valid dentry page. Signe

[f2fs-dev] [PATCH] MAINTAINERS: add myself as a dedicated reviewer of f2fs

2015-08-12 Thread Chao Yu
I volunteer to be a dedicated reviewer of f2fs, add my email address in maintainship entry of f2fs. Signed-off-by: Chao Yu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index cbf6113..bb5e3a9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4406,6 +4

Re: [f2fs-dev] [PATCH] f2fs: do not write any node pages related to orphan inodes

2015-08-12 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, August 12, 2015 6:03 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH] f2fs: do n

Re: [f2fs-dev] [PATCH] f2fs: do not assing a new segment for dio under space shortage

2015-08-12 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, August 12, 2015 2:34 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH] f2fs: do not assing a n

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: skip checkpoint if there is no dirty segments

2015-08-12 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, August 12, 2015 1:09 PM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: skip checkpoint if there

Re: [f2fs-dev] [PATCH 1/2] f2fs: increase the number of max hard links

2015-08-12 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Tuesday, August 11, 2015 9:23 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 1/2] f2fs: increase the nu