Re: [f2fs-dev] [RFC PATCH v2] mkfs.f2fs: recalculate sit_segments by max_sit_bitmap_size

2016-02-22 Thread Junling Zheng
On 2016/2/23 13:28, Chao Yu wrote: > Hi all, > >> -Original Message- >> From: Junling Zheng [mailto:zhengjunl...@huawei.com] >> Sent: Tuesday, February 23, 2016 11:47 AM >> To: linux-f2fs-devel@lists.sourceforge.net; jaeg...@kernel.org >> Subject: [f2fs-dev] [RFC PATCH v2] mkfs.f2fs:

Re: [f2fs-dev] [PATCH] f2fs: avoid hungtask problem caused by losing wake_up

2016-02-22 Thread He YunLei
On 2016/2/23 13:44, Chao Yu wrote: > Hi Yunlei, Hi Chao, > >> -Original Message- >> From: Yunlei He [mailto:heyun...@huawei.com] >> Sent: Tuesday, February 23, 2016 12:08 PM >> To: chao2...@samsung.com; jaeg...@kernel.org; >> linux-f2fs-devel@lists.sourceforge.net >> Cc:

Re: [f2fs-dev] [PATCH] f2fs: avoid hungtask problem caused by losing wake_up

2016-02-22 Thread Chao Yu
Hi Yunlei, > -Original Message- > From: Yunlei He [mailto:heyun...@huawei.com] > Sent: Tuesday, February 23, 2016 12:08 PM > To: chao2...@samsung.com; jaeg...@kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: bintian.w...@huawei.com; Yunlei He; Biao He > Subject: [f2fs-dev]

Re: [f2fs-dev] [RFC PATCH v2] mkfs.f2fs: recalculate sit_segments by max_sit_bitmap_size

2016-02-22 Thread Chao Yu
Hi all, > -Original Message- > From: Junling Zheng [mailto:zhengjunl...@huawei.com] > Sent: Tuesday, February 23, 2016 11:47 AM > To: linux-f2fs-devel@lists.sourceforge.net; jaeg...@kernel.org > Subject: [f2fs-dev] [RFC PATCH v2] mkfs.f2fs: recalculate sit_segments by >

[f2fs-dev] [RFC PATCH v2] mkfs.f2fs: recalculate sit_segments by max_sit_bitmap_size

2016-02-22 Thread Junling Zheng
In most cases, sit_bitmap_size is smaller than MAX_SIT_BITMAP_SIZE. However, in some extreme scenarios, such as 16TB, sit_bitmap_size could be larger than MAX_SIT_BITMAP_SIZE. In this case, we should recalculate the sit_segments through max_sit_bitmap_size to prevent sit_ver_bitmap_bytesize got

Re: [f2fs-dev] [PATCH] mkfs.f2fs: recalculate sit_segments by max_sit_bitmap_size

2016-02-22 Thread Junling Zheng
On 2016/2/23 1:31, Jaegeuk Kim wrote: > Hi Junling, > > On Thu, Feb 18, 2016 at 04:59:04PM +0800, Junling Zheng wrote: >> In most cases, sit_bitmap_size is smaller than MAX_SIT_BITMAP_SIZE. >> >> However, in some extreme scenarios, such as 16TB, sit_bitmap_size >> could be larger than

Re: [f2fs-dev] [PATCH v7] F2FS support

2016-02-22 Thread Jaegeuk Kim
Chang log from v6: o remove redundant filesize check in ->read o check consistency in ->open regarding to inline_data -- >8 -- From 51c120612fdbc4bc315e9c4c6e91ca888c3f3596 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Tue, 17 Nov 2015 12:45:13 -0800 Subject: [PATCH]

Re: [f2fs-dev] [PATCH v6] F2FS support

2016-02-22 Thread Jaegeuk Kim
Hi Andrei, I'll send v7 which addresses your comment. Thanks, On Mon, Feb 22, 2016 at 12:25:26PM +0300, Andrei Borzenkov wrote: > 08.01.2016 22:41, Jaegeuk Kim пишет: > > Change log from v5: > > o fix build warning for ARM, reported by Michael Zimmermann > > > > Thanks to Michael for testing

Re: [f2fs-dev] [PATCH] fsck.f2fs: check nat_entry->ino for all nodes

2016-02-22 Thread Jaegeuk Kim
Hi Sheng, On Mon, Feb 22, 2016 at 05:01:15PM +, Sheng Yong wrote: > Commit 843f5b9388c4652a ("fsck.f2fs: check ino of an inode") checks > nat_entry->ino for inode. However, the checking is irrelevant to node > type, and if ino of other kinds of nodes gets corrupted, fsck.f2fs > cannot detect

Re: [f2fs-dev] [PATCH] mkfs.f2fs: recalculate sit_segments by max_sit_bitmap_size

2016-02-22 Thread Jaegeuk Kim
Hi Junling, On Thu, Feb 18, 2016 at 04:59:04PM +0800, Junling Zheng wrote: > In most cases, sit_bitmap_size is smaller than MAX_SIT_BITMAP_SIZE. > > However, in some extreme scenarios, such as 16TB, sit_bitmap_size > could be larger than MAX_SIT_BITMAP_SIZE. > > In this case, we should

[f2fs-dev] [PATCH] fsck.f2fs: check /proc/mounts first to detect readonly

2016-02-22 Thread Jaegeuk Kim
Once f2fs_stop_checkpoint makes f2fs as readonly, only /proc/mounts shows RDONLY whereas /etc/mtab does not. Signed-off-by: Jaegeuk Kim --- lib/libf2fs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/libf2fs.c b/lib/libf2fs.c index

Re: [f2fs-dev] [PATCH 5/5] f2fs crypto: fix incorrect positioning for GCing encrypted data page

2016-02-22 Thread Chao Yu
On 2016/2/22 18:38, Chao Yu wrote: > For now, flow of GCing an encrypted data page will be: > 1) try to grab meta page in meta inode's mapping with index of old block > address of that data page > 2) load data of ciphertext into meta page > 3) allocate new block address > 4) write the meta page

[f2fs-dev] [PATCH 5/5] f2fs crypto: fix incorrect positioning for GCing encrypted data page

2016-02-22 Thread Chao Yu
For now, flow of GCing an encrypted data page will be: 1) try to grab meta page in meta inode's mapping with index of old block address of that data page 2) load data of ciphertext into meta page 3) allocate new block address 4) write the meta page into new block address 5) update block address

[f2fs-dev] [PATCH 4/5] f2fs: trace old block address for CoWed page

2016-02-22 Thread Chao Yu
This patch enables to trace old block address of CoWed page for better debugging. f2fs_submit_page_mbio: dev = (1,0), ino = 1, page_index = 0x1d4f0, oldaddr = 0xfe8ab, newaddr = 0xfee90 rw = WRITE_SYNC, type = NODE f2fs_submit_page_mbio: dev = (1,0), ino = 1, page_index = 0x1d4f8, oldaddr =

[f2fs-dev] [PATCH 3/5] f2fs: try to flush inode after merging inline data

2016-02-22 Thread Chao Yu
When flushing node pages, if current node page is an inline inode page, we will try to merge inline data from data page into inline inode page, then skip flushing current node page, it will decrease the number of nodes to be flushed in batch in this round, which may lead to worse performance.

[f2fs-dev] [PATCH 2/5] f2fs: show more info about superblock recovery

2016-02-22 Thread Chao Yu
This patch changes to show more info in message log about the recovery of the corrupted superblock during ->mount, e.g. the index of corrupted superblock and the result of recovery. Signed-off-by: Chao Yu --- fs/f2fs/super.c | 6 -- 1 file changed, 4 insertions(+), 2

[f2fs-dev] [PATCH 1/5] f2fs: fix the wrong stat count of calling gc

2016-02-22 Thread Chao Yu
With a partition which was formated as multi segments in one section, we stated incorrectly for count of gc operation. e.g., for a partition with segs_per_sec = 4 cat /sys/kernel/debug/f2fs/status GC calls: 208 (BG: 7) - data segments : 104 (52) - node segments : 104 (24) GC called count

Re: [f2fs-dev] [PATCH v6] F2FS support

2016-02-22 Thread Andrei Borzenkov
08.01.2016 22:41, Jaegeuk Kim пишет: > Change log from v5: > o fix build warning for ARM, reported by Michael Zimmermann > > Thanks to Michael for testing this patch. > > -- >8 -- > From 284fd2a6d5e07770cc021c8f59b538471c35 Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim >