Re: [f2fs-dev] [PATCH v2] f2fs-tools: set segment_count in super block correctly

2016-02-29 Thread Junling Zheng
Hi, Fan, On 2016/3/1 13:58, Fan Li wrote: > > >> -Original Message- >> From: Junling Zheng [mailto:zhengjunl...@huawei.com] >> Sent: Wednesday, February 24, 2016 4:34 PM >> To: Fan Li; 'Jaegeuk Kim' >> Cc: heyun...@huawei.com; linux-f2fs-devel@lists.sourceforge.net >> Subject: Re: [f2fs-

Re: [f2fs-dev] [PATCH v2] f2fs-tools: set segment_count in super block correctly

2016-02-29 Thread Fan Li
> -Original Message- > From: Junling Zheng [mailto:zhengjunl...@huawei.com] > Sent: Wednesday, February 24, 2016 4:34 PM > To: Fan Li; 'Jaegeuk Kim' > Cc: heyun...@huawei.com; linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH v2] f2fs-tools: set segment_count in supe

Re: [f2fs-dev] [PATCH 06/10] fs crypto: add Makefile and Kconfig

2016-02-29 Thread Jaegeuk Kim
On Sun, Feb 28, 2016 at 09:39:39PM -0800, Randy Dunlap wrote: > On 02/25/16 11:26, Jaegeuk Kim wrote: > > This patch adds a facility to enable per-file encryption. > > > > Arnd fixes a missing CONFIG_BLOCK check in the original patch. > > "The newly added generic crypto abstraction for file system

Re: [f2fs-dev] [PATCH 01/10] fs crypto: add basic definitions for per-file encryption

2016-02-29 Thread Jaegeuk Kim
On Sun, Feb 28, 2016 at 09:41:22PM -0800, Randy Dunlap wrote: > On 02/25/16 11:25, Jaegeuk Kim wrote: > > This patch adds definitions for per-file encryption used by ext4 and f2fs. > > > > Signed-off-by: Jaegeuk Kim > > --- > > include/linux/fs.h | 8 ++ > > include/linux/fscrypto.h | 23

[f2fs-dev] [PATCH] f2fs: Use crypto crc32 functions

2016-02-29 Thread Keith Mok
The crc function is done bit by bit and painfully slow, switch to use crypto crc32 function which is backed by h/w/ acceleration. Signed-off-by: Keith Mok --- fs/f2fs/Kconfig | 2 ++ fs/f2fs/checkpoint.c | 6 +++--- fs/f2fs/f2fs.h | 52 +++

[f2fs-dev] [PATCH] f2fs: mutex can't be used by down_write_nest_lock()

2016-02-29 Thread Yang Shi
fsf2_lock_all() calls down_write_nest_lock() to acquire a rw_sem and check a mutex, but down_write_nest_lock() is designed for two rw_sem accoring to the comment in include/linux/rwsem.h. And, other than f2fs, it is just called in mm/mmap.c with two rwsem. So, it looks it is used wrongly by f2fs.

Re: [f2fs-dev] [PATCH 00/35 v4] separate operations from flags in the bio/request structs

2016-02-29 Thread Mike Christie
On 02/29/2016 11:13 AM, Christoph Hellwig wrote: > Any reason you've dropped my ACK for the previous version? Sorry. I think I accidentally dropped it when I rebased back over to linux-next. It looks like it only got stuck on the first patch. I will fix that up on the resend for those kbuild error

Re: [f2fs-dev] [PATCH 00/35 v4] separate operations from flags in the bio/request structs

2016-02-29 Thread Christoph Hellwig
Any reason you've dropped my ACK for the previous version? Jens, is this something you're fine with? Would be great to figure out a way to get this into 4.6. There's probably going to be plenty of conflicts, so having some sort of stable base tree would be nice.. (Talking about conflicts, seems