Re: [f2fs-dev] [PATCH v3] f2fs: fix to avoid data update racing between GC and DIO

2016-07-12 Thread Jaegeuk Kim
On Tue, Jul 12, 2016 at 09:28:26AM +0800, Chao Yu wrote: > On 2016/7/10 0:22, Jaegeuk Kim wrote: > > On Fri, Jul 08, 2016 at 11:50:02PM +0800, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2016/7/8 11:19, Jaegeuk Kim wrote: > >>> Hi Chao, > >>> > >>> Could you take a look at this in xfstests/generic

Re: [f2fs-dev] [PATCH 3/7] f2fs: drop any block plugging

2016-07-12 Thread Jaegeuk Kim
Hi Chao, On Tue, Jul 12, 2016 at 09:38:11AM +0800, Chao Yu wrote: > On 2016/7/10 0:32, Jaegeuk Kim wrote: > > On Sat, Jul 09, 2016 at 10:28:49AM +0800, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2016/6/9 1:24, Jaegeuk Kim wrote: > >>> In f2fs, we don't need to keep block plugging for NODE and DA

Re: [f2fs-dev] [bug report] f2fs: fix to avoid reading out encrypted data in page cache

2016-07-12 Thread Jaegeuk Kim
Hello, It seems we can write just one patch to resolve this. Thoughts? >From f2bd632963409ff969aa2567a38f42f4b493a4b4 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Tue, 12 Jul 2016 09:38:48 -0700 Subject: [PATCH] f2fs: fix ERR_PTR returned by bio This is to fix wrong error pointer handling f

[f2fs-dev] [PATCH v2 1/4] f2fs: fix to avoid reading out encrypted data in page cache

2016-07-12 Thread Chao Yu
From: Chao Yu For encrypted inode, if user overwrites data of the inode, f2fs will read encrypted data into page cache, and then do the decryption. However reader can race with overwriter, and it will see encrypted data which has not been decrypted by overwriter yet. Fix it by moving decrypting

Re: [f2fs-dev] [bug report] f2fs: fix to avoid reading out encrypted data in page cache

2016-07-12 Thread Chao Yu
Hi Dan, Thanks for your report, please check v2. Thanks, On 2016/7/12 21:29, Dan Carpenter wrote: > Hello Chao Yu, > > The patch 78682f794479: "f2fs: fix to avoid reading out encrypted > data in page cache" from Jul 3, 2016, leads to the following static > checker warning: > > fs/f2fs/da

[f2fs-dev] [bug report] f2fs: fix to avoid reading out encrypted data in page cache

2016-07-12 Thread Dan Carpenter
Hello Chao Yu, The patch 78682f794479: "f2fs: fix to avoid reading out encrypted data in page cache" from Jul 3, 2016, leads to the following static checker warning: fs/f2fs/data.c:1123 f2fs_mpage_readpages() error: 'bio' dereferencing possible ERR_PTR() fs/f2fs/data.c 1093