Re: [f2fs-dev] [PATCH 04/28] f2fs: replace a build-time warning with runtime WARN_ON

2016-10-26 Thread Arnd Bergmann
On Wednesday, October 26, 2016 10:05:00 PM CEST Chao Yu wrote: > On 2016/10/18 6:05, Arnd Bergmann wrote: > > gcc is unsure about the use of last_ofs_in_node, which might happen > > without a prior initialization: > > > > fs/f2fs//git/arm-soc/fs/f2fs/data.c: In function ‘f2fs_map_blocks’: > > fs/f

Re: [f2fs-dev] [PATCH 04/28] f2fs: replace a build-time warning with runtime WARN_ON

2016-10-26 Thread Chao Yu
Hi Arnd, On 2016/10/18 6:05, Arnd Bergmann wrote: > gcc is unsure about the use of last_ofs_in_node, which might happen > without a prior initialization: > > fs/f2fs//git/arm-soc/fs/f2fs/data.c: In function ‘f2fs_map_blocks’: > fs/f2fs/data.c:799:54: warning: ‘last_ofs_in_node’ may be used uninit

Re: [f2fs-dev] [PATCH 1/3] f2fs: count dirty inodes to flush node pages during checkpoint

2016-10-26 Thread Chao Yu
On 2016/10/18 5:56, Jaegeuk Kim wrote: > If there are a lot of dirty inodes, we need to flush all of them when doing > checkpoint. So, we need to count this for enough free space. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu -

Re: [f2fs-dev] [PATCH 2/3] f2fs: call f2fs_balance_fs for setattr

2016-10-26 Thread Chao Yu
On 2016/10/18 5:56, Jaegeuk Kim wrote: > If inode becomes dirty, we need to check the # of dirty inodes whether or not > further checkpoint would be required. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu -- The