Re: [f2fs-dev] [PATCH] f2fs: improve definition of statistic macros

2017-04-19 Thread Chao Yu
On 2017/4/20 1:38, Arnd Bergmann wrote: > With a recent addition of f2fs_lookup_extent_tree(), we get a warning about > the use of empty macros: > > fs/f2fs/extent_cache.c: In function 'f2fs_lookup_extent_tree': > fs/f2fs/extent_cache.c:358:32: error: suggest braces around empty body in an > 'els

Re: [f2fs-dev] [PATCH] fscrypt: use 32 bytes of encrypted filename

2017-04-19 Thread Jaegeuk Kim
On 04/18, Eric Biggers wrote: > On Tue, Apr 18, 2017 at 06:42:09PM -0700, Jaegeuk Kim wrote: > > Hi Eric, > > > > On 04/18, Eric Biggers wrote: > > > On Tue, Apr 18, 2017 at 04:01:36PM -0700, Eric Biggers wrote: > > > > > > > > Strangely, f2fs and ubifs do not use the bytes from the filename at a

Re: [f2fs-dev] [PATCH] fscrypt: use 32 bytes of encrypted filename

2017-04-19 Thread Gwendal Grignou
On Tue, Apr 18, 2017 at 5:10 PM, Eric Biggers wrote: > On Tue, Apr 18, 2017 at 04:01:36PM -0700, Eric Biggers wrote: >> >> Strangely, f2fs and ubifs do not use the bytes from the filename at all when >> trying to find a specific directory entry in this case. So this patch >> doesn't >> really af

[f2fs-dev] [PATCH] f2fs: improve definition of statistic macros

2017-04-19 Thread Arnd Bergmann
With a recent addition of f2fs_lookup_extent_tree(), we get a warning about the use of empty macros: fs/f2fs/extent_cache.c: In function 'f2fs_lookup_extent_tree': fs/f2fs/extent_cache.c:358:32: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body] stat_inc_rbtree

Re: [f2fs-dev] [PATCH] fscrypt: use 32 bytes of encrypted filename

2017-04-19 Thread Richard Weinberger
Am 19.04.2017 um 19:16 schrieb Eric Biggers: > On Wed, Apr 19, 2017 at 03:40:13PM +0200, Richard Weinberger wrote: >>> Strangely, f2fs and ubifs do not use the bytes from the filename at all when >>> trying to find a specific directory entry in this case. So this patch >>> doesn't >>> really affe

Re: [f2fs-dev] [PATCH] fscrypt: use 32 bytes of encrypted filename

2017-04-19 Thread Eric Biggers
On Wed, Apr 19, 2017 at 03:40:13PM +0200, Richard Weinberger wrote: > > Strangely, f2fs and ubifs do not use the bytes from the filename at all when > > trying to find a specific directory entry in this case. So this patch > > doesn't > > really affect them. This seems unreliable; perhaps we sho

Re: [f2fs-dev] [PATCH] fscrypt: use 32 bytes of encrypted filename

2017-04-19 Thread Richard Weinberger
Eric, On Wed, Apr 19, 2017 at 1:01 AM, Eric Biggers wrote: > +Cc linux-f2fs-devel@lists.sourceforge.net > +Cc linux-...@lists.infradead.org (for ubifs) > > Hi Gwendal, > > On Tue, Apr 18, 2017 at 02:06:42PM -0700, Gwendal Grignou wrote: >> If we use only 16 bytes, due to how CBC works, if the nam