Re: [f2fs-dev] [RFC PATCH v2 2/2] f2fs: do not set LOST_PINO for renamed dir

2017-07-01 Thread Sheng Yong
Hi, Jaegeuk On 2017/7/1 23:10, Jaegeuk Kim wrote: Hi, On 06/26, Sheng Yong wrote: After renaming a directory, fsck could detect unmatched pino. The scenario can be reproduced as the following: $ mkdir /bar/subbar /foo $ rename /bar/subbar /foo Then fsck will report: [ASSERT]

Re: [f2fs-dev] [PATCH 2/2] f2fs: reuse original mount option in ->remount_fs

2017-07-01 Thread Chao Yu
On 2017/7/1 15:48, Jaegeuk Kim wrote: > On 06/29, Chao Yu wrote: >> From: Chao Yu >> >> Don't clear old mount option before parse new option during ->remount_fs >> like other generic filesystems> > So, what happened on your original patch? > > commit

Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid deadlock caused by lock order of page and lock_op

2017-07-01 Thread Jaegeuk Kim
On 07/01, Chao Yu wrote: > On 2017/7/1 15:28, Jaegeuk Kim wrote: > > On 06/26, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2017/6/26 22:54, Jaegeuk Kim wrote: > >>> Hi Chao, > >>> > >>> On 06/26, Chao Yu wrote: > Hi Jaegeuk, > > On 2017/6/25 0:25, Jaegeuk Kim wrote: > > -

Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid deadlock caused by lock order of page and lock_op

2017-07-01 Thread Chao Yu
On 2017/7/1 15:28, Jaegeuk Kim wrote: > On 06/26, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2017/6/26 22:54, Jaegeuk Kim wrote: >>> Hi Chao, >>> >>> On 06/26, Chao Yu wrote: Hi Jaegeuk, On 2017/6/25 0:25, Jaegeuk Kim wrote: > - punch_hole > - fill_zero > - f2fs_lock_op

Re: [f2fs-dev] [PATCH 2/2] f2fs: report # of free inodes more precisely

2017-07-01 Thread Chao Yu
On 2017/7/1 15:27, Jaegeuk Kim wrote: > On 06/28, Chao Yu wrote: >> On 2017/6/26 22:58, Jaegeuk Kim wrote: >>> On 06/26, Chao Yu wrote: Hi Jaegeuk, On 2017/6/25 0:25, Jaegeuk Kim wrote: > If the partition is small, we don't need to report total # of inodes > including >

Re: [f2fs-dev] [PATCH 2/2] f2fs: reuse original mount option in ->remount_fs

2017-07-01 Thread Jaegeuk Kim
On 06/29, Chao Yu wrote: > From: Chao Yu > > Don't clear old mount option before parse new option during ->remount_fs > like other generic filesystems. So, what happened on your original patch? commit 2c8a4366debae30ae37d0688b2bec92d196a f2fs: fix to clean previous

Re: [f2fs-dev] [PATCH] f2fs: avoid unnecessary function call

2017-07-01 Thread Jaegeuk Kim
On 07/01, Tiezhu Yang wrote: > It should call the function fscrypt_fname_free_buffer() in the exception > handling only after the function fscrypt_fname_alloc_buffer() returns 0, > otherwise it is unnecessary. Hi, fscrypt_fname_free_buffer returns if crypto_str is null. So, this flow has no

Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid deadlock caused by lock order of page and lock_op

2017-07-01 Thread Jaegeuk Kim
On 06/26, Chao Yu wrote: > Hi Jaegeuk, > > On 2017/6/26 22:54, Jaegeuk Kim wrote: > > Hi Chao, > > > > On 06/26, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2017/6/25 0:25, Jaegeuk Kim wrote: > >>> - punch_hole > >>> - fill_zero > >>> - f2fs_lock_op > >>> - get_new_data_page > >>>-

Re: [f2fs-dev] [PATCH 2/2] f2fs: report # of free inodes more precisely

2017-07-01 Thread Jaegeuk Kim
On 06/28, Chao Yu wrote: > On 2017/6/26 22:58, Jaegeuk Kim wrote: > > On 06/26, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2017/6/25 0:25, Jaegeuk Kim wrote: > >>> If the partition is small, we don't need to report total # of inodes > >>> including > >>> hidden free nodes. > >>> > >>>