Re: [f2fs-dev] [PATCH 2/2] f2fs: relax EIO injection for quota file

2017-10-22 Thread Jaegeuk Kim
On 10/22, Chao Yu wrote: > On 2017/10/20 0:56, Jaegeuk Kim wrote: > > This case is not happening easily. > > Actually it can happen, so why not just keep it? Okay, so let me keep this patch for local stress tests only. Thanks, > > Thanks, > > > > > Signed-off-by: Jaegeuk Kim > > --- > > f

Re: [f2fs-dev] [PATCH] f2fs: turn quota off when error occurs

2017-10-22 Thread Jaegeuk Kim
On 10/22, Chao Yu wrote: > On 2017/10/20 23:53, Jaegeuk Kim wrote: > > Before changing readonly, it needs to turn quota off. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/checkpoint.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoi

Re: [f2fs-dev] [PATCH] f2fs: turn quota off when error occurs

2017-10-22 Thread Chao Yu
On 2017/10/20 23:53, Jaegeuk Kim wrote: > Before changing readonly, it needs to turn quota off. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/checkpoint.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 201608281681..ff74665d7f2d 100

Re: [f2fs-dev] [PATCH 2/2] f2fs: relax EIO injection for quota file

2017-10-22 Thread Chao Yu
On 2017/10/20 0:56, Jaegeuk Kim wrote: > This case is not happening easily. Actually it can happen, so why not just keep it? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/f2fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h

Re: [f2fs-dev] [PATCH] f2fs: return error number for quota_write

2017-10-22 Thread Chao Yu
On 2017/10/20 3:08, Jaegeuk Kim wrote: > On 10/18, Chao Yu wrote: >> On 2017/10/18 2:17, Jaegeuk Kim wrote: >>> On 10/17, Chao Yu wrote: On 2017/10/17 7:04, Jaegeuk Kim wrote: > On 10/16, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2017/10/13 7:15, Jaegeuk Kim wrote: >

Re: [f2fs-dev] [PATCH 1/2] f2fs: retry ENOMEM for quota_read|write

2017-10-22 Thread Chao Yu
On 2017/10/20 0:56, Jaegeuk Kim wrote: > This gives another chance to read or write quota data. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, > --- > fs/f2fs/super.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/super.c b/fs/f2

Re: [f2fs-dev] [PATCH] f2fs: handle error case when adding xattr entry

2017-10-22 Thread Chao Yu
On 2017/10/20 2:54, Jaegeuk Kim wrote: > On 10/18, Chao Yu wrote: >> On 2017/10/18 0:41, Jaegeuk Kim wrote: >>> On 10/17, Chao Yu wrote: On 2017/10/17 7:06, Jaegeuk Kim wrote: > This patch fixes recovering incomplete xattr entries remaining in inline > xattr > and xattr block, cau

Re: [f2fs-dev] [PATCH][f2fs-next] f2fs: remove several redundant assignments

2017-10-22 Thread Chao Yu
On 2017/10/19 18:58, Colin King wrote: > From: Colin Ian King > > There are several assignments to variables that are redundant > as the values are never read when the variables are updated later > and so the redundant statements can be safely removed. > > Cleans up clang warnings: > fs/f2fs/seg

Re: [f2fs-dev] [PATCH] f2fs: avoid using timespec

2017-10-22 Thread Chao Yu
On 2017/10/19 17:52, Arnd Bergmann wrote: > All uses of timespec are deprecated, and this one is not particularly > useful, as the documented method for converting seconds to jiffies > is to multiply by 'HZ'. > > Signed-off-by: Arnd Bergmann Reviewed-by: Chao Yu Thanks, > --- > fs/f2fs/f2fs.