Re: [f2fs-dev] question about find_next_free_block in f2fs-tools

2017-12-14 Thread gaoxiang (P)
Hi Jaegeuk, ping.. I am reading f2fs-tools and doing some work on it. Could you give me some hints if section has 2 or more segments in f2fs? 1) the whole section should have the same type? I think so since GC operates sections and I have observed some clues in "get_new_segment":

Re: [f2fs-dev] [PATCH RFC] f2fs: fix an error case of missing update inode page

2017-12-14 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Friday, December 15, 2017 12:21 PM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Jianing >(Euler) >Subject: Re: [f2fs-dev][PATCH RFC] f2fs: fix an error case of missing update

[f2fs-dev] [PATCH] fsck.f2fs: check nid range before use to avoid segmentation fault

2017-12-14 Thread Yunlong Song
Signed-off-by: Yunlong Song --- fsck/fsck.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index 11b8b0b..2212aa3 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.c @@ -14,6 +14,15 @@ char *tree_mark; uint32_t tree_mark_size = 256; +static in

[f2fs-dev] [PATCH] fsck.f2fs: check and fix i_namelen to avoid double free

2017-12-14 Thread Yunlong Song
Signed-off-by: Yunlong Song --- fsck/fsck.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index 2212aa3..8ff4e4b 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.c @@ -643,7 +643,7 @@ void fsck_chk_inode_blk(struct f2fs_sb_info *sbi, u3

Re: [f2fs-dev] [PATCH v4 08/73] xarray: Add documentation

2017-12-14 Thread Matthew Wilcox
On Mon, Dec 11, 2017 at 03:10:22PM -0800, Randy Dunlap wrote: > > +A freshly-initialised XArray contains a ``NULL`` pointer at every index. > > +Each non-``NULL`` entry in the array has three bits associated with > > +it called tags. Each tag may be flipped on or off independently of > > +the othe

Re: [f2fs-dev] [PATCH RFC] f2fs: fix an error case of missing update inode page

2017-12-14 Thread Jaegeuk Kim
On 12/15, heyunlei wrote: > > > >-Original Message- > >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > >Sent: Friday, December 15, 2017 3:46 AM > >To: heyunlei > >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Jianing > >(Euler) > >Subject: Re: [f2fs-dev][PATCH RFC]

Re: [f2fs-dev] [PATCH RFC] f2fs: fix an error case of missing update inode page

2017-12-14 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Friday, December 15, 2017 3:46 AM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Jianing >(Euler) >Subject: Re: [f2fs-dev][PATCH RFC] f2fs: fix an error case of missing update

Re: [f2fs-dev] [PATCH] f2fs: uses the same naming scheme for struct nat_entry and f2fs_nat_entry

2017-12-14 Thread Jaegeuk Kim
Hi Yunlei, Thank you for the work, however, when considering backporting effort, this would be likely to generate somewhat merge conflicts. Thanks, On 12/14, Yunlei He wrote: > Uses the same naming scheme for struct nat_entry and f2fs_nat_entry > as in function __flush_nat_entry_set. No function

Re: [f2fs-dev] [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-14 Thread Jaegeuk Kim
On 12/14, Hyunchul Lee wrote: > Hi Jaegeuk, > > I need your comment about the fs_iohint mount option. > > a) w/o fs_iohint, propagate user hints to low layer. > b) w/ fs_iohint, ignore user hints, and use hints which is generated > with F2FS. > > Chao suggests this option. because user hints are

Re: [f2fs-dev] [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-14 Thread Jaegeuk Kim
Hello, On 12/01, Hyunchul Lee wrote: > Hi Jaegeuk, > > On 12/01/2017 04:28 PM, Jaegeuk Kim wrote: > > On 11/30, Chao Yu wrote: > >> On 2017/11/28 8:23, Hyunchul Lee wrote: > >>> From: Hyunchul Lee > >>> > >>> This implements which hint is passed down to block layer > >>> for datas from the speci

Re: [f2fs-dev] [PATCH] fs/*/Kconfig: drop links to 404-compliant http://acl.bestbits.at

2017-12-14 Thread Jaegeuk Kim
On 12/13, Adam Borowski wrote: > This link is replicated in most filesystems' config stanzas. Referring > to an archived version of that site is pointless as it mostly deals with > patches; user documentation is available elsewhere. > > Signed-off-by: Adam Borowski > --- > Sending this as one pi

Re: [f2fs-dev] [PATCH v2] f2fs: add an ioctl to disable GC for specific file

2017-12-14 Thread Jaegeuk Kim
On 12/12, Chao Yu wrote: > Hi Jaegeuk, > > On 2017/12/9 3:37, Jaegeuk Kim wrote: > > Change log from v1: > > - fix bug in error handling of ioctl > > > >>From b905e03d8aad7d25ecaf9bde05411a68d3d2460e Mon Sep 17 00:00:00 2001 > > From: Jaegeuk Kim > > Date: Thu, 7 Dec 2017 16:25:39 -0800 > > Su

Re: [f2fs-dev] [PATCH RFC] f2fs: fix an error case of missing update inode page

2017-12-14 Thread Jaegeuk Kim
On 12/05, Yunlei He wrote: > -Thread A Thread B > > -write_checkpoint > -block_operations > -f2fs_unlock_all-f2fs_sync_file > -f2fs_write_inode >

Re: [f2fs-dev] [PATCH v4] f2fs: obsolete free nid list approach

2017-12-14 Thread Jaegeuk Kim
On 12/11, Chao Yu wrote: > Hi Jaegeuk, > > On 2017/12/1 15:36, Jaegeuk Kim wrote: > > Hi Chao, > > > > This is really hard to review and risky a lot to apply it shortly. Do we > > have a > > I can understand your concern. > > > strong reason we have to do this? The original design goal was to

[f2fs-dev] [PATCH] mkfs.f2fs: Limit pragma pack(1) only for Windows Host

2017-12-14 Thread Jaegeuk Kim
From: Hyojun Kim A side-effect was found for #pragma pack(1), which were added for Windows SDK support. Limiting it with ANDROID_WINDOWS_HOST. Signed-off-by: Hyojun Kim --- include/f2fs_fs.h | 52 include/quota.h | 6 ++ 2 files chang

Re: [f2fs-dev] [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-14 Thread Joe Perches
On Mon, 2017-12-11 at 14:43 -0800, Matthew Wilcox wrote: > - There's no warning for the first paragraph of section 6: > > 6) Functions > > > Functions should be short and sweet, and do just one thing. They should > fit on one or two screenfuls of text (the ISO/ANSI screen size is 8

Re: [f2fs-dev] [PATCH v3] f2fs: avoid dead loop in function find_fsync_dnodes

2017-12-14 Thread Chao Yu
On 2017/12/14 11:54, Yunlei He wrote: > Came across a dead loop in recovery like this: > > .. > [ 24.680480s][pid:320,cpu0,init]find_fsync_dnodes: blkaddr =13597696 > [ 24.698394s][pid:320,cpu0,init]find_fsync_dnodes: blkaddr =13597697 > [ 24.724334s][pid:320,cpu0,init]find_fsync_dnodes:

Re: [f2fs-dev] [PATCH] fs/*/Kconfig: drop links to 404-compliant http://acl.bestbits.at

2017-12-14 Thread Chao Yu
On 2017/12/13 13:38, Adam Borowski wrote: > This link is replicated in most filesystems' config stanzas. Referring > to an archived version of that site is pointless as it mostly deals with > patches; user documentation is available elsewhere. > > Signed-off-by: Adam Borowski [skip] > diff --g