[f2fs-dev] 答复: [PATCH] f2fs: prevent newly created inode from being dirtied incorrectly

2018-01-11 Thread zhangzhikang
Hi Daeho: We had tried to msleep(1) after f2fs_mark_inode_dirty_sync() in creating a new file, and then write checkpoint in another thread. But it didn't cause a kernel panic. So can you tell me what test case did you use, and provide the call trace? Thank you! Best regards, Zhikang Zhang

Re: [f2fs-dev] [PATCH v2 00/11] fscrypt: symlink helpers and fscrypt.h cleanup

2018-01-11 Thread Theodore Ts'o
I've taken the v2 version of this series, plus the ext4-specific patches to use the new symlink helpers (from the v1 patch series). After testing and validating them, I included the patches to convert f2fs and ubifs to use the symlink helpers, so I could also grab the cleanup patches from the V1

[f2fs-dev] [PATCH] f2fs: prevent newly created inode from being dirtied incorrectly

2018-01-11 Thread Daeho Jeong
Now, we invoke f2fs_mark_inode_dirty_sync() to make an inode dirty in advance of creating a new node page for the inode. By this, some inodes whose node page is not created yet can be linked into the global dirty list. If the checkpoint is executed at this moment, the inode will be written back

Re: [f2fs-dev] [PATCH v2] f2fs: handle newly created page when revoking inmem pages

2018-01-11 Thread 정대호
Yes, Chao, you're right. :)   - Original Message - Sender : Chao Yu  Date : 2018-01-11 18:55 (GMT+9) Title : Re: [PATCH v2] f2fs: handle newly created page when revoking inmem pages     > I guess Daeho want to say "Partially successful"?   > Thanks,      

[f2fs-dev] [PATCH RFC v4] mkfs.f2fs: binary decision to calculate SIT/NAT/SSA

2018-01-11 Thread Gaoxiang (OS)
Use binary decision approach to calculate SIT/NAT/SSA segments it has some benefits when the partition size >= 512G: (bsearch) psize main_segments main_seaments ... 512G261509 261510 1 T523141 523143 2 T1046405 1046409 4 T

Re: [f2fs-dev] [PATCH] f2fs: avoid hungtask when gc encrypted block if io_bits is set

2018-01-11 Thread Chao Yu
On 2018/1/11 11:52, Sheng Yong wrote: > When io_bits is set, gc encrypted block may trigger the following hungtask. > Since io_bits requires aligned block address, f2fs_submit_page_write may > return -EAGAIN if new_blkaddr does not satisify io_bits alignment. > > So let's try to alloc new block

Re: [f2fs-dev] [PATCH v2] f2fs: handle newly created page when revoking inmem pages

2018-01-11 Thread Chao Yu
On 2018/1/11 14:50, Yunlong Song wrote: > Should it be "When committing inmem pages is not successful" ? I guess Daeho want to say "Partially successful"? Thanks, -- Check out the vibrant tech community on one of the

Re: [f2fs-dev] [PATCH] f2fs: prevent newly created inode from being dirtied incorrectly

2018-01-11 Thread Chao Yu
On 2018/1/11 10:26, Daeho Jeong wrote: > Now, we invoke f2fs_mark_inode_dirty_sync() to make an inode dirty in > advance of creating a new node page for the inode. By this, some inodes > whose node page is not created yet can be linked into the global dirty > list. > > If the checkpoint is

Re: [f2fs-dev] [PATCH 3/3] dump.f2fs: do not write nat bits when dumping info

2018-01-11 Thread Chao Yu
On 2018/1/11 10:17, Sheng Yong wrote: > Signed-off-by: Sheng Yong Reviewed-by: Chao Yu Thanks, -- Check out the vibrant tech community on one of the world's most engaging

Re: [f2fs-dev] [PATCH 2/3] mkfs.f2fs: set seed for random checkpoint_ver

2018-01-11 Thread Chao Yu
On 2018/1/11 10:17, Sheng Yong wrote: > If seed is not set, rand always uses 1 as the default seed. > > Signed-off-by: Liu Xue > Signed-off-by: Sheng Yong Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH 1/3] fsck.f2fs: show encoded name when unlinking corrupted dentry

2018-01-11 Thread Chao Yu
On 2018/1/11 10:17, Sheng Yong wrote: > For dentry name, we should check if parent directory is encrypted. If it > is, show digest-encoded name instead of cipher text when unlink corrupted > dir entries. > > Signed-off-by: Sheng Yong Reviewed-by: Chao Yu