Then the GCed data pages are totally mixed with the inmem atomic pages,
this will cause the atomic commit ops write the GCed data pages twice
(the first write happens in GC).
How about using the early two patches to separate the inmem data pages
and GCed data pages, and use dio_rwsem instead of t
We can change the next block offsets sometimes, so we have to check it's
free or not all the time. This fixes that SSR type makes a hole for it.
Signed-off-by: Jaegeuk Kim
---
fsck/fsck.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fsck/fsck.c b/fsck/fsck.c
index 29823a1.
Some minor nits for when you send your next patch for stable:
On Tue, Feb 06, 2018 at 03:53:53PM -0800, Jin Qian wrote:
> From: Jin Qian
The original patch was written by Al Viro, please do not take the
original authorship off, that's not good.
> partial backport from 21fc61c73c3903c4c312d0802d
On 2018/2/6 11:49, Yunlong Song wrote:
> This patch adds fi->commit_lock to avoid the case that GCed node pages
> are committed but GCed data pages are not committed. This can avoid the
> db file run into inconsistent state when sudden-power-off happens if
> data pages of atomic file is allowed to
On 2018/2/6 1:43, Ju Hyung Park wrote:
> I'm not entirely familiar with how cold and hot files are treated in f2fs,
> but I'm going to assume it has to do something with GC and
> less-prioritizing for random R/W operations.
>
> If my assumption is correct, I see some things problematic here.
>
>
On 2018/2/6 8:21, Tiezhu Yang wrote:
> This patch removes redundant check of page type when submit bio to
> make the logic more clear.
>
> Signed-off-by: Tiezhu Yang
Reviewed-by: Chao Yu
Thanks,
--
Check out the vibra
On 2018/2/7 18:01, Sheng Yong wrote:
[...]
+
+/* lookup lost+found in root directory */
+lpf_ino = f2fs_lookup(sbi, node, (u8 *) LPF, strlen(LPF));
The 4th parameter should be namelen but not strlen(LPF).
Sorry for the noise. The comment here is wrong :(
[...]
+
+static int fs
On 2018/2/6 12:31, Sheng Yong wrote:
This patch introduces lost+found feature to fsck. If a file is found
unreachable by fsck. Fsck tries to reconnect the file to lost+found
directory:
1. Scan all unreachable file inodes, ignore non-inodes ones and
directories.
2. Check them and fix