[f2fs-dev] [PATCH] f2fs: remove unneed reada during build free nids

2018-02-08 Thread Yunlei He
This patch remove unneed reada during build free nids. If few nids left, three will introduce a lot of no hit read io. Signed-off-by: Yunlei He --- fs/f2fs/node.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/fs/f2fs/node.c

Re: [f2fs-dev] [RFC PATCH 2/2] f2fs: introduce lost+found feature

2018-02-08 Thread Sheng Yong
Hi, Chao On 2018/2/8 21:29, Chao Yu wrote: On 2018/2/6 12:31, Sheng Yong wrote: Introduce lost+found feature. The lost+found is a directory which saves Nitpick, lost_found feature... Needs to add /sys/fs/f2fs/features/lost_found sysfs entry, and show 'lost_found' in /sys/fs/f2fs//features.

Re: [f2fs-dev] [RFC PATCH 4/5] mkfs.f2fs: create lost+found directory

2018-02-08 Thread Sheng Yong
Hi, Chao On 2018/2/8 23:08, Chao Yu wrote: On 2018/2/6 12:31, Sheng Yong wrote: This patch introduces a new feature F2FS_FEATURE_LOST_FOUND. It can be switched on by indicating a new option `lost+found' with -O. If Not sure, do we need to change this option to 'lost_found' to follow other

Re: [f2fs-dev] [RFC PATCH 1/5] mkfs.f2fs: introduce mkfs parameters in f2fs_configuration

2018-02-08 Thread Sheng Yong
Hi, Chao Add Hyojun. On 2018/2/8 21:30, Chao Yu wrote: On 2018/2/6 12:31, Sheng Yong wrote: /* only root inode was written before truncating dnodes */ last_inode_pos = start_inode_pos + - c.cur_seg[CURSEG_HOT_NODE] * c.blks_per_seg + quota_inum; +

[f2fs-dev] [PATCH] mkfs.f2fs: fix to handle endianness in f2fs_write_check_point_pack

2018-02-08 Thread Chao Yu
From: Chao Yu This patch fixes to handle missing endianness in f2fs_write_check_point_pack. Signed-off-by: Chao Yu --- mkfs/f2fs_format.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c index

Re: [f2fs-dev] [RFC PATCH 4/5] mkfs.f2fs: create lost+found directory

2018-02-08 Thread Chao Yu
On 2018/2/6 12:31, Sheng Yong wrote: > This patch introduces a new feature F2FS_FEATURE_LOST_FOUND. It can be > switched on by indicating a new option `lost+found' with -O. If Not sure, do we need to change this option to 'lost_found' to follow other generic -O options? > F2FS_FEATUER_LOST_FOUND

Re: [f2fs-dev] [RFC PATCH 3/5] fsck.f2fs: integrate sanity_check_inode to __check_inode_mode

2018-02-08 Thread Chao Yu
On 2018/2/6 12:31, Sheng Yong wrote: > In sanity_check_nid, __check_inode_mode will check i_mode value of an > inode. So integrate sanity_check_inode to __check_inode_mode to clean > up the code. > > Signed-off-by: Sheng Yong > --- > fsck/fsck.c | 26

Re: [f2fs-dev] [RFC PATCH 2/5] f2fs-tools: init f2fs_configuration as 0

2018-02-08 Thread Chao Yu
On 2018/2/6 12:31, Sheng Yong wrote: > Signed-off-by: Sheng Yong Reviewed-by: Chao Yu Thanks, -- Check out the vibrant tech community on one of the world's most engaging tech

Re: [f2fs-dev] [RFC PATCH 1/5] mkfs.f2fs: introduce mkfs parameters in f2fs_configuration

2018-02-08 Thread Chao Yu
On 2018/2/6 12:31, Sheng Yong wrote: > /* only root inode was written before truncating dnodes */ > last_inode_pos = start_inode_pos + > - c.cur_seg[CURSEG_HOT_NODE] * c.blks_per_seg + quota_inum; > + c.cur_seg[CURSEG_HOT_NODE] * c.blks_per_seg + c.quota_inum;

Re: [f2fs-dev] [RFC PATCH 2/2] f2fs: introduce lost+found feature

2018-02-08 Thread Chao Yu
On 2018/2/6 12:31, Sheng Yong wrote: > Introduce lost+found feature. The lost+found is a directory which saves Nitpick, lost_found feature... Needs to add /sys/fs/f2fs/features/lost_found sysfs entry, and show 'lost_found' in /sys/fs/f2fs//features. Thanks, > unreachable files. If f2fsck finds

Re: [f2fs-dev] [RFC PATCH 1/2] f2fs: clean up f2fs_sb_has_xxx functions

2018-02-08 Thread Chao Yu
On 2018/2/6 12:31, Sheng Yong wrote: > This patch introduces F2FS_FEATURE_FUNCS to clean up the definitions of > different f2fs_sb_has_xxx functions. > > Signed-off-by: Sheng Yong Reviewed-by: Chao Yu Thanks,

[f2fs-dev] [PATCH] f2fs: set_code_data in move_data_block

2018-02-08 Thread Yunlong Song
Signed-off-by: Yunlong Song --- fs/f2fs/gc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index b9d93fd..2095630 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -692,6 +692,7 @@ static void move_data_block(struct inode *inode, block_t