Re: [f2fs-dev] [PATCH] libf2fs: reset wanted_total_sectors by new sector_size

2018-04-02 Thread Chao Yu
On 2018/4/3 4:03, Jaegeuk Kim wrote: > On 04/02, Chao Yu wrote: >> On 2018/3/30 23:39, Jaegeuk Kim wrote: >>> On 03/30, Junling Zheng wrote: On 2018/3/30 19:26, Chao Yu wrote: > On 2018/3/30 18:51, Junling Zheng wrote: >> Hi, >> >> On 2018/3/30 17:28, Chao Yu wrote: >>> Hi

Re: [f2fs-dev] [PATCH v2] f2fs: remain written times to update inode during fsync

2018-04-02 Thread Jaegeuk Kim
On 04/03, Chao Yu wrote: > On 2018/3/31 0:30, Jaegeuk Kim wrote: > > Change log from v1: > > - add more description > > > > This fixes xfstests/generic/392. > > > > The failure was caused by different times between 1) one marked in the last > > fsync(2) call and 2) the other given by roll-forwar

Re: [f2fs-dev] [PATCH v3] f2fs: remain written times to update inode during fsync

2018-04-02 Thread Jaegeuk Kim
Change log from v2: - update do_read_inode Change log from v1: - add more description This fixes xfstests/generic/392. The failure was caused by different times between 1) one marked in the last fsync(2) call and 2) the other given by roll-forward recovery after power-cut. The reason was that

Re: [f2fs-dev] [PATCH 1/4] mkfs.f2fs: update extension lists

2018-04-02 Thread Chao Yu
Hi Park, On 2018/3/30 21:13, Ju Hyung Park wrote: > Hi Chao, > >> As I said, now we'd better to add a option in mkfs to disable default list >> first. If you have time to work on this, I'm glad to review the patch.;) > > Yeah, I'll add that to my TODOs list :) > >> What I mean is we'd better to

Re: [f2fs-dev] [PATCH] f2fs: make assignment of t->dentry_bitmap more readable

2018-04-02 Thread Chao Yu
On 2018/4/2 20:22, Yunlong Song wrote: > In make_dentry_ptr_block, it is confused with "&" for t->dentry_bitmap > but without "&" for t->dentry, so delete "&" to make code more readable. > > Signed-off-by: Yunlong Song Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH] f2fs: truncate preallocated blocks in error case

2018-04-02 Thread Chao Yu
On 2018/3/31 9:57, Jaegeuk Kim wrote: > If write is failed, we must deallocate the blocks that we couldn't write. > > Cc: sta...@vger.kernel.org > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, -- Check out

Re: [f2fs-dev] [PATCH v2] f2fs: remain written times to update inode during fsync

2018-04-02 Thread Chao Yu
On 2018/3/31 0:30, Jaegeuk Kim wrote: > Change log from v1: > - add more description > > This fixes xfstests/generic/392. > > The failure was caused by different times between 1) one marked in the last > fsync(2) call and 2) the other given by roll-forward recovery after power-cut. > The reason

Re: [f2fs-dev] [PATCH] mkfs.f2fs: support multiple features with one "-O"

2018-04-02 Thread Junling Zheng
Hi, Chao On 2018/4/2 21:35, Chao Yu wrote: > On 2018/4/2 12:19, Junling Zheng wrote: >> Now one "-O" option can support multiple features separated >> by a comma or blank, such as: >> feature1,feature2,... or "feature1 feature2 ..." > > At a glance, can last sector number be parsed as feature nam

Re: [f2fs-dev] [PATCH] f2fs: reserve bits for fs-verity

2018-04-02 Thread Eric Biggers via Linux-f2fs-devel
On Tue, Apr 03, 2018 at 07:49:59AM +1000, Dave Chinner wrote: > On Mon, Apr 02, 2018 at 11:48:37AM -0700, Eric Biggers wrote: > > [+Cc linux-ext4, linux-fsdevel] > > > > On Mon, Apr 02, 2018 at 06:07:10PM +0800, Chao Yu wrote: > > > Hi Eric and Jaegeuk, > > > > > > On 2018/3/31 2:34, Eric Biggers

Re: [f2fs-dev] [PATCH] f2fs: reserve bits for fs-verity

2018-04-02 Thread Dave Chinner
On Mon, Apr 02, 2018 at 11:48:37AM -0700, Eric Biggers wrote: > [+Cc linux-ext4, linux-fsdevel] > > On Mon, Apr 02, 2018 at 06:07:10PM +0800, Chao Yu wrote: > > Hi Eric and Jaegeuk, > > > > On 2018/3/31 2:34, Eric Biggers wrote: > > > Hi Chao and Jaegeuk, > > > > > > On Fri, Mar 30, 2018 at 09:4

Re: [f2fs-dev] [PATCH] f2fs: fix to show encrypt flag in FS_IOC_GETFLAGS

2018-04-02 Thread Jaegeuk Kim
On 04/02, Chao Yu wrote: > This patch fixes to show encrypt flag in FS_IOC_GETFLAGS like ext4 does. Actually, we have to show internal flags owned by f2fs, not generic ones. We may need to define all of them separately? > > Signed-off-by: Chao Yu > --- > fs/f2fs/file.c | 9 +++-- > 1 file

Re: [f2fs-dev] [PATCH] libf2fs: reset wanted_total_sectors by new sector_size

2018-04-02 Thread Jaegeuk Kim
On 04/02, Chao Yu wrote: > On 2018/3/30 23:39, Jaegeuk Kim wrote: > > On 03/30, Junling Zheng wrote: > >> On 2018/3/30 19:26, Chao Yu wrote: > >>> On 2018/3/30 18:51, Junling Zheng wrote: > Hi, > > On 2018/3/30 17:28, Chao Yu wrote: > > Hi All, > > > > On 2018/3/28 1:19,

Re: [f2fs-dev] [PATCH] f2fs: reserve bits for fs-verity

2018-04-02 Thread Eric Biggers via Linux-f2fs-devel
[+Cc linux-ext4, linux-fsdevel] On Mon, Apr 02, 2018 at 06:07:10PM +0800, Chao Yu wrote: > Hi Eric and Jaegeuk, > > On 2018/3/31 2:34, Eric Biggers wrote: > > Hi Chao and Jaegeuk, > > > > On Fri, Mar 30, 2018 at 09:41:36AM -0700, Jaegeuk Kim wrote: > >> On 03/30, Chao Yu wrote: > >>> Hi Eric, >

Re: [f2fs-dev] [PATCH] mkfs.f2fs: support multiple features with one "-O"

2018-04-02 Thread Chao Yu
On 2018/4/2 12:19, Junling Zheng wrote: > Now one "-O" option can support multiple features separated > by a comma or blank, such as: > feature1,feature2,... or "feature1 feature2 ..." At a glance, can last sector number be parsed as feature name? Thanks, > > Signed-off-by: Junling Zheng > ---

[f2fs-dev] [PATCH] f2fs: make assignment of t->dentry_bitmap more readable

2018-04-02 Thread Yunlong Song
In make_dentry_ptr_block, it is confused with "&" for t->dentry_bitmap but without "&" for t->dentry, so delete "&" to make code more readable. Signed-off-by: Yunlong Song --- fs/f2fs/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index

Re: [f2fs-dev] [PATCH] f2fs: fix a wrong condition in f2fs_skip_inode_update

2018-04-02 Thread Chao Yu
On 2018/3/29 19:27, Junling Zheng wrote: > Fix commit 97dd26ad8347 (f2fs: fix wrong AUTO_RECOVER condition). > We should use ~PAGE_MASK to determine whether i_size is aligned to > the f2fs's block size or not. > > Signed-off-by: Junling Zheng Reviewed-by: Chao Yu Thanks,

[f2fs-dev] [PATCH] f2fs: fix to show encrypt flag in FS_IOC_GETFLAGS

2018-04-02 Thread Chao Yu
This patch fixes to show encrypt flag in FS_IOC_GETFLAGS like ext4 does. Signed-off-by: Chao Yu --- fs/f2fs/file.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 8068b015ece5..271fadadaa36 100644 --- a/fs/f2fs/file.c +++ b/fs/f2

Re: [f2fs-dev] [PATCH] f2fs: reserve bits for fs-verity

2018-04-02 Thread Chao Yu
Hi Eric and Jaegeuk, On 2018/3/31 2:34, Eric Biggers wrote: > Hi Chao and Jaegeuk, > > On Fri, Mar 30, 2018 at 09:41:36AM -0700, Jaegeuk Kim wrote: >> On 03/30, Chao Yu wrote: >>> Hi Eric, >>> >>> On 2018/3/29 2:15, Eric Biggers wrote: Reserve an F2FS feature flag and inode flag for fs-verit

Re: [f2fs-dev] [PATCH] libf2fs: reset wanted_total_sectors by new sector_size

2018-04-02 Thread Chao Yu
On 2018/3/30 23:39, Jaegeuk Kim wrote: > On 03/30, Junling Zheng wrote: >> On 2018/3/30 19:26, Chao Yu wrote: >>> On 2018/3/30 18:51, Junling Zheng wrote: Hi, On 2018/3/30 17:28, Chao Yu wrote: > Hi All, > > On 2018/3/28 1:19, Jaegeuk Kim wrote: >> From: katao >>